Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36B7BC001DF for ; Sat, 15 Jul 2023 15:04:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8827A8628F; Sat, 15 Jul 2023 17:03:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="EAw1ClBP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E18A18622E; Sat, 15 Jul 2023 17:03:28 +0200 (CEST) Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7678186281 for ; Sat, 15 Jul 2023 17:03:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-ot1-x32d.google.com with SMTP id 46e09a7af769-6b9cf1997c4so160262a34.3 for ; Sat, 15 Jul 2023 08:03:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1689433405; x=1692025405; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aIPOxd/227Tt/f7hp4cOEKNr1qbwid1AABNCb2G7qmA=; b=EAw1ClBP/nnLdUJUOw6ypT0FnsYhBWldXwwla5UUlTZ/GWCzCFUZgjzvlRa/XcJ5uf hmRHQApcZnddBvo8MQmVWFzyTLw/aqVyHwUBk8/gp0dLnTnpdbT3yuesSRH0lG8kqXYk Ak2IAoQGiFwH9MNbspMkeOOW6mFx9fXkzmA2k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689433405; x=1692025405; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aIPOxd/227Tt/f7hp4cOEKNr1qbwid1AABNCb2G7qmA=; b=Kc6mEC43pirLLnHHORY1yvTt2IL0/Wb+KYZcc5v3qgiQRrWIuEP7twYNM38j00XYee JBDsIZf3PI6lgqe8uxm38D2f3h0CyLr/R5TwBUfgAgaS0uK+3LDteiP3UuxmRXdXmed8 NR16C71XQHJAwjpqV2tL2u6/NYDEtw7uij7NF8+j1C/rPM9nbVTRrD+iM11GSsbRI3jx /sDlA1g/XgqRA7o75PABHD+z3FthBDShUvtS9XckGwSpBiIvsDF9RvRxHp7GwDzOFImS 8YtVabpn5ifxZWs9aC/3El33KbcPQ4DSJ3g6AHesMKou0EHDIK7/bxGrR1ep1c0FJ5Cb v3ww== X-Gm-Message-State: ABy/qLbqFZAscGzi0E0dZjNy7N7iJonNBxz6O1Xnh6FtmL/DLfcwMSgS nc81lOE2dbY04YS/2ueQN6UItQ== X-Google-Smtp-Source: APBJJlHECR43boTvdqa3/NmIsrydm459Hxlx+keksyAdOFjfaovDP3maK5AQntWZlk2Sj3qsGXZzoA== X-Received: by 2002:a05:6870:d293:b0:1b0:7661:dd18 with SMTP id d19-20020a056870d29300b001b07661dd18mr9000344oae.23.1689433405178; Sat, 15 Jul 2023 08:03:25 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-2ff3-b443-1227-0d00.res6.spectrum.com. [2603:6081:7b00:6400:2ff3:b443:1227:d00]) by smtp.gmail.com with ESMTPSA id m140-20020a0dca92000000b00576c727498dsm2867284ywd.92.2023.07.15.08.03.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jul 2023 08:03:24 -0700 (PDT) Date: Sat, 15 Jul 2023 11:03:23 -0400 From: Tom Rini To: Andreas Dannenberg Cc: u-boot@lists.denx.de, Joe Hershberger , Ramon Fried , Ravi Gunasekaran , Grygorii Strashko , Simon Glass , Siddharth Vadapalli Subject: Re: [PATCH] net: ti: am65-cpsw-nuss: Use dedicated port mode control registers Message-ID: <20230715150323.GG2066889@bill-the-cat> References: <20230614222853.574427-1-dannenberg@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="adQKUCU+N751af6l" Content-Disposition: inline In-Reply-To: <20230614222853.574427-1-dannenberg@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --adQKUCU+N751af6l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 14, 2023 at 05:28:53PM -0500, Andreas Dannenberg wrote: > The different CPSW sub-system Ethernet ports have different PHY mode > control registers. In order to allow the modes to get configured > independently only the register for the port in question must be > accessed, otherwise we would just be re-configuring the mode for port 1, > while leaving all others at their power-on defaults. Fix this issue by > adding a port-number based offset to the mode control base register > address based on the fact that the control registers for the different > ports are spaced exactly 0x4 bytes apart. >=20 > Fixes: 9d0dca1199d1 ("net: ethernet: ti: Introduce am654 gigabit eth swit= ch subsystem driver") > Signed-off-by: Andreas Dannenberg > Reviewed-by: Siddharth Vadapalli Applied to u-boot/master, thanks! --=20 Tom --adQKUCU+N751af6l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmSytToACgkQFHw5/5Y0 tyyYVgv+IFgsGB6jyZVZ+D/idukE8znw9xksIBV68/m1QH5s9k9w0P8SKX3u0ESk HcOsOR1112FPBbcc5GT5xRMj4muQPCtwsbbU+RYhy+DICICqUmX717GbOmlgPqrq JSRelpHjQkPvCSup19/UWPlvSv05C4/SdYGLRwWpVL4dr4lchKj4VgC3SQSTWyAZ JV8vQE+6m+P9vApniRqIEuedVph3gl5QL4Ag62tNxKC4+nxlFajb+PYzfePVRgoB +eZzrCm6Gb41F+FqzWYE0hwnwUiesPVC3iai3ksdvdo/FU0iRxmojSKGwmS9y1bb gC7vpamVzw9DzNzNaDotpzLKCHlIomJFrByyAhtLcRojyf5H2bdFHojgMFkbAar2 eTnNNZf3X9LdT8zZhMuYYaNV2Yf8KZ5ueoiowbKJKWo1VqyORH3ik0KDpDNyNM5Q zYQFF7ZWRptRQQjRhB7cIyO/u/BlmWiDKXBjRivvCDh6H2nvPRfme9G65/3mnP4M EhYSETUY =A9WV -----END PGP SIGNATURE----- --adQKUCU+N751af6l--