Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B442210EC for ; Mon, 24 Jul 2023 01:34:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A647C433CA; Mon, 24 Jul 2023 01:34:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690162478; bh=7/AE+pqIuZxmEbNYF2RAsJ9Vg9QulCzhxXO9kEtGqEg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=boh0Na/XtgeZv/P1lT/Z3leKsYaGtxeZySz1DcHSoyocwps0wrh6eVNZGfT3nw/hy 4j8aTB7XK23hZKblrTHYTLq2N+WKQzEWjVF/WOrvXRYrZbWc25eEubhquMoOuweTWP VYDN6WHaq38D09myfZ+r1JBdDh9Z0gqRqSvaraOCx/QUFpHT8V6S35K/+0IodGUMjU TVmbm1xUCWHO/tsXZTVnWtAXnKQ1wBG0VjGUERD6J1cB/R2BnY2bwZUYQAYzC4IWaH okXuHfT2Jj1ZQpeTkCVcmGc2o25Cj4QPNKpjGNH9wtETovv4GyVpilpS5db6qV0Xo8 Ee5uqubVyNGig== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhengping Jiang , Luiz Augusto von Dentz , Jakub Kicinski , Sasha Levin , marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com, davem@davemloft.net, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 08/12] Bluetooth: L2CAP: Fix use-after-free Date: Sun, 23 Jul 2023 21:34:21 -0400 Message-Id: <20230724013426.2333833-8-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230724013426.2333833-1-sashal@kernel.org> References: <20230724013426.2333833-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.249 Content-Transfer-Encoding: 8bit From: Zhengping Jiang [ Upstream commit f752a0b334bb95fe9b42ecb511e0864e2768046f ] Fix potential use-after-free in l2cap_le_command_rej. Signed-off-by: Zhengping Jiang Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/bluetooth/l2cap_core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index e56863587ea2e..61bf489265505 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c @@ -5723,9 +5723,14 @@ static inline int l2cap_le_command_rej(struct l2cap_conn *conn, if (!chan) goto done; + chan = l2cap_chan_hold_unless_zero(chan); + if (!chan) + goto done; + l2cap_chan_lock(chan); l2cap_chan_del(chan, ECONNREFUSED); l2cap_chan_unlock(chan); + l2cap_chan_put(chan); done: mutex_unlock(&conn->chan_lock); -- 2.39.2