Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D3F815B8 for ; Mon, 24 Jul 2023 01:35:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87CD6C433C8; Mon, 24 Jul 2023 01:35:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690162525; bh=sVCoWPlfoz1TDH352SXVh3AMw2hQTj1ciCayBnwKgXs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jyjIus/VN8RY7jFggvJH7TXgMUeQ4PYLcvaoBNG7Jxzl4x/WP+MM03N+4Acq9savf s6N0jxxX8pTF05k4n28elFgA/bhmV2nn47GPl5/LlJ7wSggZU7zXz27K734od8KlGK GTt+h015DjetsTlHMK880Ma4sKMI340zgIgIZMz15VpRoRFxE/YEP48oVXXyfEhZSZ lKoq0aXoEJCo1qqNywMhZd1a8sNx5oMLPDWi3mP64eG8qUqVGXnVhOkR5/YXY/PA2c mvXfXZzck1+N5cgl0V3wwghJGfHQ3ZTrqeQc9imHGELux/ZjhG+9rMVV1M2nLwDZB6 7ZAsfpwrFUaWw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhengping Jiang , Luiz Augusto von Dentz , Jakub Kicinski , Sasha Levin , marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com, davem@davemloft.net, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 7/9] Bluetooth: L2CAP: Fix use-after-free Date: Sun, 23 Jul 2023 21:34:43 -0400 Message-Id: <20230724013445.2334326-7-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230724013445.2334326-1-sashal@kernel.org> References: <20230724013445.2334326-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.288 Content-Transfer-Encoding: 8bit From: Zhengping Jiang [ Upstream commit f752a0b334bb95fe9b42ecb511e0864e2768046f ] Fix potential use-after-free in l2cap_le_command_rej. Signed-off-by: Zhengping Jiang Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/bluetooth/l2cap_core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index fcc471f921895..9346fae5d664b 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c @@ -5705,9 +5705,14 @@ static inline int l2cap_le_command_rej(struct l2cap_conn *conn, if (!chan) goto done; + chan = l2cap_chan_hold_unless_zero(chan); + if (!chan) + goto done; + l2cap_chan_lock(chan); l2cap_chan_del(chan, ECONNREFUSED); l2cap_chan_unlock(chan); + l2cap_chan_put(chan); done: mutex_unlock(&conn->chan_lock); -- 2.39.2