Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54BB1C001DF for ; Tue, 25 Jul 2023 17:54:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EE00886603; Tue, 25 Jul 2023 19:54:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="QSLVFZy5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6D29086604; Tue, 25 Jul 2023 19:54:52 +0200 (CEST) Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [IPv6:2607:f8b0:4864:20::e32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7815786205 for ; Tue, 25 Jul 2023 19:54:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-vs1-xe32.google.com with SMTP id ada2fe7eead31-4474f20cd19so170099137.0 for ; Tue, 25 Jul 2023 10:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1690307688; x=1690912488; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KMQ8Rvfrvkh47DJrEaYFk2GMsJ8lqE2EYM1F1+XaaO8=; b=QSLVFZy54OdZXuFLJ4HkbTMf0AdvuwGdmYN06sI7GGwVoOuYTfgxnWLVnCVg/T9lMk RUrX3umbXQACQwOm882hZdxbv4plHIHpUns826N1ZSqkb775UFoO8/xG1ixNpIi4yPDO mXT9G0dcUTYouvQxPxjt53uFoba6PmzGXKgE4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690307688; x=1690912488; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KMQ8Rvfrvkh47DJrEaYFk2GMsJ8lqE2EYM1F1+XaaO8=; b=lodHU8LGcDAJvQYPatIK5mqIOCFUl/efC7wTroAZYiL9xmRNDRV8y6jHrABRp3IH/j f+GbSR6aBfw2EEknhWeViQsL2/riMeiC7g0Vsf3uc00lflLkosTLpCn0y5OMnVEwVl1j wrCRVTOAbo0sKgBvdfW8EBeO0fqpf8Y0km8AFPx1i0wg1evaVCEhomRRxc7FJWn6Ty21 sObEkupOgPc+RHraiOwX2m4oX2CjE+1O5pbWW1THo0dAlvRP2tMontcg8p9j5tY4ZTHw nMG5rvUEPzA0wgz9bAzjXyQG14QJCerpwyDPagu28NVBs3anqceo5ah8356naAu8UlgG ucwA== X-Gm-Message-State: ABy/qLbRLVLZFhjUfpOQbtIoUEJ7/Muq36VMhVxS3u1sE0klcOUutxaq FO7wzxGQT4SUaKZPpbH0Z04ISQ== X-Google-Smtp-Source: APBJJlGOJINvL5WEkrOhQbQp5fGV157JYGsaQbeqxtNHeFuOItVUZWi4HAdgzY/1fX/89pX0i24X1w== X-Received: by 2002:a67:fdcc:0:b0:443:8b27:6dac with SMTP id l12-20020a67fdcc000000b004438b276dacmr5162374vsq.9.1690307688175; Tue, 25 Jul 2023 10:54:48 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-b236-e3a5-57be-379d.res6.spectrum.com. [2603:6081:7b00:6400:b236:e3a5:57be:379d]) by smtp.gmail.com with ESMTPSA id e6-20020ab031c6000000b00786fd01f05bsm1755060uan.24.2023.07.25.10.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jul 2023 10:54:47 -0700 (PDT) Date: Tue, 25 Jul 2023 13:54:45 -0400 From: Tom Rini To: Andrew Davis Cc: Simon Glass , Nishanth Menon , Vignesh Raghavendra , u-boot@lists.denx.de Subject: Re: [PATCH 1/2] configs: keystone2: Unwind KERNEL_MTD_PARTS definition Message-ID: <20230725175445.GA3630934@bill-the-cat> References: <20230725164059.593455-1-afd@ti.com> <20230725171811.GU3630934@bill-the-cat> <431a4601-beda-21c4-13e8-81ef9be453de@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cbFPsEXlSWK0eT0U" Content-Disposition: inline In-Reply-To: <431a4601-beda-21c4-13e8-81ef9be453de@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --cbFPsEXlSWK0eT0U Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 25, 2023 at 12:47:10PM -0500, Andrew Davis wrote: > On 7/25/23 12:18 PM, Tom Rini wrote: > > On Tue, Jul 25, 2023 at 11:40:58AM -0500, Andrew Davis wrote: > >=20 > > > This is more complex than it needs to be and makes converting these > > > boards over to plain text env files more difficult. Simplify this > > > environment variable scheme. > > >=20 > > > Signed-off-by: Andrew Davis > > > --- > > > include/configs/k2e_evm.h | 5 +---- > > > include/configs/k2g_evm.h | 4 +--- > > > include/configs/k2hk_evm.h | 5 +---- > > > include/configs/k2l_evm.h | 5 +---- > > > include/configs/ti_armv7_keystone2.h | 6 +----- > > > include/environment/ti/spi.h | 14 -------------- > > > 6 files changed, 5 insertions(+), 34 deletions(-) > > > delete mode 100644 include/environment/ti/spi.h > >=20 > > So this unwinding isn't quite enough as the defconfigs also set > > CONFIG_MTDPARTS_DEFAULT and that's the best way. >=20 > The one in CONFIG_MTDPARTS_DEFAULT is different from the one defined in k= 2*_evm.h, > so switching would change the env. This patch was attempting to make no c= hanges. >=20 > Maybe a better question is do we need these anymore? They don't seem to d= o anything > anymore and these partitions are board specific, so couldn't be set unive= rsally in > defconfig anyway. Plus They are instead already defined (correctly too) i= n the DTS > files for each board. Should we just drop mtdparts=3D? So, CONFIG_MTDPARTS_DEFAULT (and related) largely just results in setting mtdparts=3D in the default environment. So yes, if they're correct in the DTS files the best thing to do is remove the CONFIG options and remove the environment settings and then there won't be confusion about which one is the source of truth. --=20 Tom --cbFPsEXlSWK0eT0U Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmTADGIACgkQFHw5/5Y0 tywvRwv8C5QYcjQMUsIuzCiTy4ZLjVgIBd/l6lbNC+0L0595XC7nnpjlyte1S5HQ vDiZQUurAK0kfbmEm6aAZq14wEGh5PyrJ28gKOO5nY10CaRdF0o8dT+lbviqcSHV WeUn0V13lwMKfXeAxdUd2Yz+ArOdKaHwLJF8iyps+IKO5G6cSgxsNCqOuhC3DwE8 qrGcdBY97Y/ikVvjvfckRBokliSBLHmZbO4nwSXspBZu6E8DvpePB4PsJk4WTNId eWYryQUd/AgkEKExquy9IAOLYMAOT16aR1QpgOE3NaaWKSMWBxPEHhdxz3medSFp veZIa5BE90jXGEMB5vFq8Ie1MOJWcUhN2IRFucvt/57KRRWF91gH2s9lFOCtT3EA lrlvMNY7ZhQ1911Y3BRnqM+aiDoNUn8Y6FyabbMEMxnbFkupm2zHA8rC7SXRjCnF otIJR7VxEihxU/OXOQD+SfNPgSxoL1oCoc64UAy6eNWT8YtuIOqHiZp5q3tI4o+Z RIKMLjJp =FBvT -----END PGP SIGNATURE----- --cbFPsEXlSWK0eT0U--