Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66373C001DC for ; Wed, 26 Jul 2023 16:34:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BB8DD8681E; Wed, 26 Jul 2023 18:34:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="du4YTkJl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 126BC867F6; Wed, 26 Jul 2023 18:34:39 +0200 (CEST) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E3A44868C6 for ; Wed, 26 Jul 2023 18:34:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-403a85eb723so58318891cf.1 for ; Wed, 26 Jul 2023 09:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1690389265; x=1690994065; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gQcC67/LJGmaMyp0WrmVm7fEeeGwr/mWiGXSa4ZDr2w=; b=du4YTkJlT6S+ZKH6VXcg0rs9lCncYkslwV7jWYH4WEON+ASoWqXh+af7Ah7toz+Pp3 Pgdgy4YLTgvA9Q7vXPCUd8AN4wl0ssYySMuuiYHdyAkeTHL+JZKDgjL6ae/FKN9YAl95 gtX/HGlOz6EkaPh8guFBRBxdUe34cd+/edT3c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690389265; x=1690994065; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gQcC67/LJGmaMyp0WrmVm7fEeeGwr/mWiGXSa4ZDr2w=; b=b4UktFmazLGwUDbcCOXWYO9BUYzYoULd7NmASa+rO2lVeU5RbCcEiY52I315EYqMCY lNnXRzZaHFtGCVYuwpwXgwGzVg6+UFpKWrNpWmrITdrMRWUM0iiGwX+WL15qh3j4euH0 ukCUHRslMnkyLhPc4vtuWbzpZpcpGyXno6yhSJqrsfSNf/eTsamKuMUpdEb5wnXgGlPT 4dHam2IExdAKhTEC88SwiMTT+XwVQ1m+GEBBXEl0COQ88v4a4D7QTq3//P0L8jiOujdJ gUdLbkXHu3iRSnwx01QUmyJK95IcJM047PtqcTRnmQ0bbwXNS32FS2pmE1jUK+HtOQdJ xkuw== X-Gm-Message-State: ABy/qLZ1Yp7YjN0wUvkue3NYE7T6ErEpYlkYXXGn04aTdN1j4P0m5Eoo TGPlR6neaxebKxkWTmf9uu48RSvShVLVPw4jZDXreg== X-Google-Smtp-Source: APBJJlFGiiCHMm3FJZ/kNLNwOO8jcfyCGzQjFTMX0TdE0Jb8jDc9RV6yYD7E9dkG13D1cuTKhKGldw== X-Received: by 2002:a0d:df97:0:b0:579:9cae:e0ee with SMTP id i145-20020a0ddf97000000b005799caee0eemr1933466ywe.20.1690378590955; Wed, 26 Jul 2023 06:36:30 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-08f6-b38b-1fda-25aa.res6.spectrum.com. [2603:6081:7b00:6400:8f6:b38b:1fda:25aa]) by smtp.gmail.com with ESMTPSA id h12-20020a816c0c000000b00583d5c6de1dsm59292ywc.17.2023.07.26.06.36.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jul 2023 06:36:30 -0700 (PDT) Date: Wed, 26 Jul 2023 09:36:28 -0400 From: Tom Rini To: Nishanth Menon Cc: Maxime Ripard , Ravi Gunasekaran , u-boot@lists.denx.de, Wadim Egorov , Francesco Dolcini , Sjoerd Simons , Neha Malcom Francis , Bryan Brattlof , Vignesh Raghavendra , Mattijs Korpershoek , Marcel Ziswiler , Roger Quadros Subject: Re: [PATCH 3/3] arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1 Message-ID: <20230726133628.GQ3630934@bill-the-cat> References: <20230725125856.1807742-1-nm@ti.com> <20230725125856.1807742-4-nm@ti.com> <20230725140934.wxo7ndfkfvem5xhs@excitable> <20230725181742.GB3630934@bill-the-cat> <932d1dd9-c9e2-5853-fdd7-210d7fb15106@ti.com> <20230726125115.bugzqulyicy5gwef@study> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wIlCZSdv8oshuuSO" Content-Disposition: inline In-Reply-To: <20230726125115.bugzqulyicy5gwef@study> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --wIlCZSdv8oshuuSO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 26, 2023 at 07:51:15AM -0500, Nishanth Menon wrote: > On 10:15-20230726, Maxime Ripard wrote: > > On Wed, Jul 26, 2023 at 11:26:05AM +0530, Ravi Gunasekaran wrote: > > > On 7/25/23 11:47 PM, Tom Rini wrote: > > > > On Tue, Jul 25, 2023 at 09:09:34AM -0500, Nishanth Menon wrote: > > > >> On 15:56-20230725, Maxime Ripard wrote: > > > >>> Hi, > > > >>> > > > >>> On Tue, Jul 25, 2023 at 07:58:56AM -0500, Nishanth Menon wrote: > > > >>>> Update the am62 and am625 device-trees from linux v6.3-rc5 This = needed the followin > > > >>>> tweaks to the u-boot specific dtsi as well: > > > >>>> - Switch tick-timer to the main_timer as it's now defined in the= main dtsi > > > >>>> - Secure proxies are defined in Soc dtsis > > > >>>> - Drop duplicate nodes - u-boot.dtsi is includes in r5-sk, no ne= ed for > > > >>>> either the definitions from main.dtsi OR duplication from u-bo= ot.dtsi > > > >>>> - Add mdio pins to the cpsw3g pinctrl in u-boot dtsi. It moved t= o a subnode in the > > > >>>> linux dtsi that u-boot doesn't use/support > > > >>>> > > > >>>> Cc: Francesco Dolcini > > > >>>> Cc: Sjoerd Simons > > > >>>> Cc: Wadim Egorov > > > >>>> Signed-off-by: Nishanth Menon > > > >>>> --- > > > >>>> > > > >>>> I decided not to pick up changes from Roger and Maxime as they a= re'nt > > > >>>> regression fixes, instead the fixups can be done on top of the b= asic > > > >>>> sync. > > > >>> > > > >>> This breaks Linux network interfaces so I very much considers thi= s a regression. > > > >> The current u-boot.dtsi I am confused - pinctrl mdio is still a > > > >> problem, is'nt it? > > > >> https://github.com/u-boot/u-boot/blob/master/arch/arm/dts/k3-am625= -sk-u-boot.dtsi#L132 > > > >> The follow on fixups from both your and Roger's series should fix = things > > > >> up, correct? > > > >=20 > > > > I'm a little confused here too. For each of these cases, what happ= ens? > > > > - Today, one of these platforms, we pass the kernel the in-memory U= -Boot > > > > device tree. And if this is functional for networking, how/why? > > >=20 > > > In here, the mdio pinctrl configuration is present only in one node (= CPSW). > > > So there is no conflict when the in-memory DT is passed by U-Boot to = kernel. > > >=20 > > > > - "Tomorrow", one of these platforms, with Nishanth's series applie= d, we > > > > pass the in-memory U-Boot device tree > > >=20 > > > In this case, the DT passed by U-Boot has the mdio pinctrl info prese= nt in > > > two nodes - one in CPSW and other in MDIO. This causes failure in Lin= ux as > > > both nodes refer to same pinctrl configuration. > >=20 > > Yeah, exactly. The "Tomorrow" case probably makes it functional for > > U-Boot but breaks Linux in the process. It was functional in Linux > > before because it has everything needed to set up the network and didn't > > rely on U-Boot for that at all. > >=20 >=20 > https://github.com/nmenon/fix-k3-dt-u-boot/commits/fdt-fixup-s1-am625-rev= 3.1 > If we are willing to add the dependency of: >=20 > https://lore.kernel.org/r/20230724-ti-mdio-pinmux-v4-1-18541f976501@kerne= l.org > https://lore.kernel.org/r/20230722193151.117345-2-rogerq@kernel.org > https://lore.kernel.org/r/20230722193151.117345-3-rogerq@kernel.org >=20 > Tom, >=20 > I need some guidance here - i can squash the fixup if the > dependencies queued. So we need to update the cpsw driver in U-Boot first, to handle what the DT looks like now. Yes, this is fine with me. --=20 Tom --wIlCZSdv8oshuuSO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmTBIVMACgkQFHw5/5Y0 tyyDkgv+NcQ3rH1yFpWijkC5BIrLMooyI/L+z7n2O/3lY1KyBK07zL8cSpOt9R7g Y4ibAffobKoWQGSbfeySlVLAAMRQFllig8DHsMSQRnjDTwVp3GVQL1gxO5OE21A5 P3DmpRcXY//VllrCUi2VWC3LzrD15eghWH/PaZc2TXJkpZxKNu46gHUyda3MtpH8 SUVpxgTwqwe+qr/fOiBjCdWu1qFxE2rNvldvg/HCobsb4nUCKMSSrg9qKUrZ54l+ RsaTDfEQMGnXJ65eNrQoMdKHg0MDv9PwviB5kN5h+7JogsrUqVgIlcJJsML2Jf9g CMZluPpmW8CxapiQ4rYktGL/9RXST4lgBJXA8NCOeRLXhACHLwngW3xDO2Ea31jr iMNF0zQIT0SpumaNSrL7e2GqcRgAHdG46DEofpNuRhIlkDs0BbDoXIbI60aNsTq1 UGpJpYurvXjpUivF9rqJ0sWrR7IFUSVZ/kBTlRoEbW2JpuNt19F6D30wmJS1ZcC6 K13wCWNn =lwjh -----END PGP SIGNATURE----- --wIlCZSdv8oshuuSO--