Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED3E5C00528 for ; Mon, 31 Jul 2023 18:59:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E46468699D; Mon, 31 Jul 2023 20:59:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="A7ICD4nk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B7FBC869ED; Mon, 31 Jul 2023 20:59:18 +0200 (CEST) Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7B52086988 for ; Mon, 31 Jul 2023 20:59:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-bff89873d34so3896755276.2 for ; Mon, 31 Jul 2023 11:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1690829955; x=1691434755; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3InLPersTLiT62qlKbRQMznvx7R9cMRuJR0xrHqxC00=; b=A7ICD4nk2ocWZR3DSREyErbWU/IfnBIbXR5c0Hvfw0jZUvv8sJszY2snnNICB7N76x RZLdifzy1spSqigcJ44YwnKJKXTDvqwWcuQwZmxC/YAupNUCy1ZinYL2CLfrBe1gVnPB HLM4OCnnGJ4uTTYW00nW0PZFg/rdpxl4kvVn0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690829955; x=1691434755; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3InLPersTLiT62qlKbRQMznvx7R9cMRuJR0xrHqxC00=; b=d6bGPuZwuoDQ8Cip8BWSmKG+qfHbQrKNH+k5hRETBgToiZ/XQiRuppr7YEb67EMMTn t671qpYk+ugAcGmEmysS2HjMHjOoUM/jzlYS0Pe2P+zZ/nATKAtBaQLqa5h75of6YFBw BtpARXfUx6GECFfJT1tusMGqVyFApnN9u0JtYK/hPTHZTiParjfnsZ6uNchhAoPdmys4 d0UAr35dD2nxw1P26HhZJhnIA+w4nyST9z+UPhxfX7XA8Uv3xjmcLV79e9vT1KXmVkpE Ibs4SLa0WS6ApsdW34SjnJFLpbMtO5WIsn6SHIwB7Hf3UBtGbgTH0JMD/8qF7dK52uLQ nB2g== X-Gm-Message-State: ABy/qLYrQAsqHhcJoDAAbeP8DwOVC4ZOXJ0gGYSQuApgxo15xWKYMw4u N/OlN3vR5iXdX3iVZZYW0T4c3g== X-Google-Smtp-Source: APBJJlFr5VOzZOdzLVKiGlfPtoH3EGEhL+b344epw2Xn6CT6OdXR/82fciB0GFBOT36X8GlUuKNMeg== X-Received: by 2002:a0d:f1c4:0:b0:573:c70b:f4ca with SMTP id a187-20020a0df1c4000000b00573c70bf4camr7184650ywf.49.1690829955075; Mon, 31 Jul 2023 11:59:15 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-7e50-54e3-e9cb-536d.res6.spectrum.com. [2603:6081:7b00:6400:7e50:54e3:e9cb:536d]) by smtp.gmail.com with ESMTPSA id g67-20020a816b46000000b00576c534115bsm3200456ywc.34.2023.07.31.11.59.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 11:59:14 -0700 (PDT) Date: Mon, 31 Jul 2023 14:59:13 -0400 From: Tom Rini To: Sergei Antonov Cc: u-boot@lists.denx.de, sjg@chromium.org Subject: Re: [PATCH] arm: moxa: add nport6600 platform Message-ID: <20230731185913.GA3630934@bill-the-cat> References: <20230731184329.1789323-1-saproj@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DRYxis4uWnTOY2jr" Content-Disposition: inline In-Reply-To: <20230731184329.1789323-1-saproj@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --DRYxis4uWnTOY2jr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 31, 2023 at 09:43:29PM +0300, Sergei Antonov wrote: > Support for NPort 6600 Series RS-232/422/485 secure terminal servers. >=20 > Technical specifications: > FA526 ARMv4 CPU, 64 MB of RAM, 16 MB NOR flash, 100 Mbit/s Ethernet, > optional expansion modules, up to 32 RS-232/422/485 ports. >=20 > Signed-off-by: Sergei Antonov > --- > arch/arm/Kconfig | 9 +++ > arch/arm/dts/nport6600.dts | 134 +++++++++++++++++++++++++++++++ Where does the device tree come from? > diff --git a/board/moxa/nport6600/nport6600.c b/board/moxa/nport6600/npor= t6600.c > new file mode 100644 > index 000000000000..88fa98c315fd > --- /dev/null > +++ b/board/moxa/nport6600/nport6600.c > @@ -0,0 +1,78 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > + > +#include New files must not add common.h > diff --git a/include/configs/nport6600.h b/include/configs/nport6600.h > new file mode 100644 > index 000000000000..c70cc7e1ac72 > --- /dev/null > +++ b/include/configs/nport6600.h [snip] > +#define __io What's this for? --=20 Tom --DRYxis4uWnTOY2jr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmTIBH0ACgkQFHw5/5Y0 tyy0gAv/bnKULwkFur7/Av20NcoixBihiPnBzEWPRJ71T3tumPKjiz2sKvHeiQhy Znk9VCvbj9/UsJR9YmlWhDYeh1+yL58LYLs8mH/y0Esm6tMpLqMMY/qQ5M4yOpTi wF702xNEHORwJ4Je0ip1MexVZQuWQL2p+WxaPJYu1aBRf4jj2TZhoON9EmBUMJtN D96Di4vAh/1bekQWyWITeg/G+KLD4zECF+lxQJrmOLxij5KXG805tiJQ/kABoY/c c7fOw15vQxWRMBOygZdcehjGXHckPyUEQTe07imHwI2xUUoZFHlyOou6xApwupju gq9uROqWoRHJVzohj7VrAjdbGWLpfb1Ms0imLsK/m0KqXy7Vp/BbXVXNWc0px9Cq E3/qmqd/o1DfKpDppF3dI2j5T5GWq5kjPZMm1oVt25SwUsobHbrvhu+yANRdHR5W 53VB5GYP3xhJ5EDvnebjNqmfvvaILUgrV0wLNbT6pJSNC4w8e0qmcCwi625hWUGU tit5F8fw =1cEl -----END PGP SIGNATURE----- --DRYxis4uWnTOY2jr--