Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B776C001DF for ; Wed, 2 Aug 2023 16:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229495AbjHBQZR (ORCPT ); Wed, 2 Aug 2023 12:25:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229932AbjHBQZQ (ORCPT ); Wed, 2 Aug 2023 12:25:16 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2F331FFA for ; Wed, 2 Aug 2023 09:25:15 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id EE95968AA6; Wed, 2 Aug 2023 18:25:11 +0200 (CEST) Date: Wed, 2 Aug 2023 18:25:11 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Chaitanya Kulkarni , Jeff Moyer , "dan.j.williams@intel.com" , "vishal.l.verma@intel.com" , "dave.jiang@intel.com" , "ira.weiny@intel.com" , "nvdimm@lists.linux.dev" , linux-block@vger.kernel.org Subject: Re: [PATCH V2 1/1] pmem: set QUEUE_FLAG_NOWAIT Message-ID: <20230802162511.GA3520@lst.de> References: <20230731224617.8665-1-kch@nvidia.com> <20230731224617.8665-2-kch@nvidia.com> <20230801155943.GA13111@lst.de> <0a2d86d6-34a1-0c8d-389c-1dc2f886f108@nvidia.com> <20230802123010.GB30792@lst.de> <17c5d907-d276-bffc-17ca-d796156a2b78@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17c5d907-d276-bffc-17ca-d796156a2b78@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Aug 02, 2023 at 09:36:32AM -0600, Jens Axboe wrote: > You can do a LOT of looping over a giant bio and still come out way > ahead compared to needing to punt to a different thread. So I do think > it's the right choice. But I'm making assumptions here on what it looks > like, as I haven't seen the patch... "a LOT" is relative. A GB or two will block the submission thread for quite a while.