Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 522C5C04A6A for ; Wed, 2 Aug 2023 17:18:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1E42F86C25; Wed, 2 Aug 2023 19:17:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="j/enugCx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 55F7E86771; Wed, 2 Aug 2023 19:05:49 +0200 (CEST) Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6695D86785 for ; Wed, 2 Aug 2023 19:05:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=massimo.pegorer@gmail.com Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-522bc9556f5so6167643a12.0 for ; Wed, 02 Aug 2023 10:05:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690995947; x=1691600747; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KZvIA9jQYqWu66cavUrScry7R00P0eWtZa8dKhohTB8=; b=j/enugCx5DQQ5VZTT9CraEUDfiXm1MLvsG4k/GK/uRwi1gb+yKLAeGRcXaO44Q97Hp 0rVwO1XSLWB/3obzYnckl9je9m6kw4aQwH5MSLHxvCKiMRlx4715HJ1iFNo0YdNMmAzr ZY2rLqvB1+WJiRvY+JgrwdBj7vkjbVnQT9QXgXE5qdoKNU4qsUrLFTd+weQ9fsobyu0E S6UdCH5EfRAluq9jC9u9Y6Wh0B5pdIxYKnu/fADadfWyJtVFbnRtvWDOdW4TtmuNmo/H 7ftlKj2IgGmuuRqWIKfJrihVX2TY3WOawprUwydGyrxrBri23zx0j82f8puuWSHBAS/d A1QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690995947; x=1691600747; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KZvIA9jQYqWu66cavUrScry7R00P0eWtZa8dKhohTB8=; b=IWmV9sFsEtPYJT6m8n/iIUruSE8S9TkVStTliHCw0dUZ/WtU7ZPMwKrq8sbN7tiiYH YPtZvLqNUSDUYHy5z8znhoQnG7fNo/0SNVbJFH4BHNapn+/Qn/oUImuag6Aqyu5T7Hw2 SLlUvnABzzTWv4kRdJl66GR15PznAoUzwjRGjT6P1peNVtWO5PSXRuX3KhJk/0kPlOnt nTtWtpGrYPwy+2wRE3XJGABQdnYpNm4fDd7+X1XbX1nKL9IYZUY0ElvwErteXAWXz7do gEw7oGRgT3ldyfh2AqoraaAz0fIrLQmbIHJPySdwy3M0elfYRcUxWpyxrEByXgdlI/m+ AiZA== X-Gm-Message-State: ABy/qLaJNv4g80B0wgWwMz2sQCaWvMGAtM8KSwz1GTU37EqGjxVZFfkV 3Q0M5eYiTBSVUZymFPjFd/OvIBZf1xI= X-Google-Smtp-Source: APBJJlFIKcrjuPVcTs5j0ma4H3K0u7qj/e7KRPsD5PxFg516FUZrp7nt7FvEQRhk98cTSxiFyq2IeA== X-Received: by 2002:a50:ec94:0:b0:522:2fec:3e60 with SMTP id e20-20020a50ec94000000b005222fec3e60mr6047350edr.20.1690995946117; Wed, 02 Aug 2023 10:05:46 -0700 (PDT) Received: from pegmas-T15.fritz.box ([151.71.155.227]) by smtp.gmail.com with ESMTPSA id e8-20020a056402148800b0052227c4384esm8854198edv.34.2023.08.02.10.05.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 10:05:45 -0700 (PDT) From: Massimo Pegorer X-Google-Original-From: Massimo Pegorer To: u-boot@lists.denx.de, Simon Glass , Philipp Tomsich , Kever Yang Cc: Massimo Pegorer Subject: [PATCH 1/2] rockchip: spl: Drop useless call to debug_uart_init Date: Wed, 2 Aug 2023 19:05:23 +0200 Message-Id: <20230802170524.150654-2-massimo.pegorer+oss@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230802170524.150654-1-massimo.pegorer+oss@gmail.com> References: <20230802170524.150654-1-massimo.pegorer+oss@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Wed, 02 Aug 2023 19:17:53 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Since commit 0dba45864b2a ("arm: Init the debug UART") function debug_uart_init is called in crt files _main before calling board_init_f. Therefore, there is no need to call it again inside board_init_f implementation in arm/mach-rockchip/spl.c. Signed-off-by: Massimo Pegorer --- arch/arm/mach-rockchip/spl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/mach-rockchip/spl.c b/arch/arm/mach-rockchip/spl.c index 30be640425..a6396b3c42 100644 --- a/arch/arm/mach-rockchip/spl.c +++ b/arch/arm/mach-rockchip/spl.c @@ -116,12 +116,10 @@ void board_init_f(ulong dummy) /* * Debug UART can be used from here if required: * - * debug_uart_init(); * printch('a'); * printhex8(0x1234); * printascii("string"); */ - debug_uart_init(); debug("\nspl:debug uart enabled in %s\n", __func__); #endif -- 2.34.1