Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A005DC001DF for ; Thu, 3 Aug 2023 12:02:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C894286C9E; Thu, 3 Aug 2023 14:02:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="dDa1V+o0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 21C1286C1D; Thu, 3 Aug 2023 14:02:18 +0200 (CEST) Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 143CF865DA for ; Thu, 3 Aug 2023 14:02:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-583fe10bb3cso9595657b3.2 for ; Thu, 03 Aug 2023 05:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1691064133; x=1691668933; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UEfp4Kk4XXDQ1Xutx9rQM6LwikA2P/2bb4m+rJT4XZs=; b=dDa1V+o0zrqmqdRPgCG9ffnZlgWbFW67+JJsgdEIjlN8wup3ZnbbxTrdommfBUAjRE IICSyvm89wJHgLCN4Cmb4MstaYvB1jA7zDbY858BWJrnLBC4pMvSLNZ/JadTN86/PTKn U24xy9oIOLtNjUJqLETzm/ZQ4dxrywNnzlPjk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691064133; x=1691668933; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UEfp4Kk4XXDQ1Xutx9rQM6LwikA2P/2bb4m+rJT4XZs=; b=FN4DV07kcBFjPJhEVORAdUaTIz2+EbeOVUZGOjaAY5tIlZgdAvraISGer+O7ih2jNR rs41iTOvNXTzXMPzlY7wYRdE1wlprokZl/QU33gZ72r4A/TdlYtq3GLHf4Fgz5or/K3m wGlFjdx0lb/MMkPUsh8QxGzASmTLh6Nj0GSjttm7LKr2F5XfqzlLZHhmqkyJGW0jGmns 8YBpr+6HcKXemXxCclx23lA2D1Y0GA5arGmTuSiVFbOv1cN/itT17XrIRUQDu5RXDx/M soAIx5eKlYbC8K/DyCYVjcqeYmphyxK8R81IlsCtmSWTiG7VaPZPfk8uo+RGudH5fSqo 2yIg== X-Gm-Message-State: ABy/qLYu8mEK8apZ2EosXzJ/pJ7V2qgaQvz6i1fmYEcUe6zcrGD4bYJ7 /4seERpoA3f+282+TbH52/PsRqez2G1Uh0rbckWQ3A== X-Google-Smtp-Source: APBJJlEvSCAaFfIlly0N9HgGvu2peqMphqI4nDEux7QIJtQ4fg8F/jb4fUsx2RJKks33T23UokHlPw== X-Received: by 2002:a25:2385:0:b0:d08:5a25:e6b4 with SMTP id j127-20020a252385000000b00d085a25e6b4mr18540786ybj.28.1691064132775; Thu, 03 Aug 2023 05:02:12 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-68ac-3ac0-af0b-6541.res6.spectrum.com. [2603:6081:7b00:6400:68ac:3ac0:af0b:6541]) by smtp.gmail.com with ESMTPSA id k22-20020a25b296000000b00cf79d3a503fsm2504300ybj.42.2023.08.03.05.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 05:02:12 -0700 (PDT) Date: Thu, 3 Aug 2023 08:02:10 -0400 From: Tom Rini To: Simon Glass Cc: u-boot@lists.denx.de Subject: Re: [PATCH] Kconfigs: Correct default of "0" on hex type entries Message-ID: <20230803120210.GM3630934@bill-the-cat> References: <20230802150943.377769-1-trini@konsulko.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8r2G/cBry3U3QbCQ" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --8r2G/cBry3U3QbCQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 02, 2023 at 03:31:22PM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Wed, 2 Aug 2023 at 09:10, Tom Rini wrote: > > > > It is not a parse error to have a default value of "0" for a "hex" type > > entry, instead of "0x0". However, "0" and "0x0" are not treated the > > same even by the tools themselves. Correct this by changing the default > > value from "0" to "0x0" for all hex type questions that had the > > incorrect default. Fix one instance (in two configs) of a default of "0" > > being used on a hex question to be "0x0". Remove the cases where a > > defconfig had set a value of "0x0" to be used as the default had been > > "0". > > > > Signed-off-by: Tom Rini > > --- > > arch/arm/cpu/armv7/ls102xa/Kconfig | 1 - > > arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 2 +- > > arch/arm/mach-imx/Kconfig | 2 +- > > arch/arm/mach-imx/imx8/Kconfig | 4 ++-- > > arch/arm/mach-rockchip/Kconfig | 2 +- > > arch/arm/mach-sunxi/Kconfig | 4 ++-- > > arch/powerpc/cpu/mpc8xx/Kconfig | 2 +- > > boot/Kconfig | 2 +- > > cmd/Kconfig | 8 ++++---- > > common/Kconfig | 2 +- > > common/spl/Kconfig | 2 +- > > common/spl/Kconfig.tpl | 2 +- > > configs/am335x_guardian_defconfig | 1 - > > configs/efi-x86_app32_defconfig | 2 +- > > configs/efi-x86_app64_defconfig | 2 +- > > configs/evb-rk3229_defconfig | 1 - > > configs/evb-rk3308_defconfig | 1 - > > configs/imx6q_logic_defconfig | 1 - > > configs/imx8mm_data_modul_edm_sbc_defconfig | 1 - > > configs/imx8mn_beacon_2g_defconfig | 1 - > > configs/imx8mn_beacon_defconfig | 1 - > > configs/imx8mn_beacon_fspi_defconfig | 1 - > > configs/imx8mp_beacon_defconfig | 1 - > > configs/imx8mp_data_modul_edm_sbc_defconfig | 1 - > > configs/imx8mp_dhcom_pdk2_defconfig | 1 - > > configs/imx8mp_dhcom_pdk3_defconfig | 1 - > > configs/kontron_sl28_defconfig | 2 -- > > configs/lion-rk3368_defconfig | 1 - > > configs/roc-cc-rk3308_defconfig | 1 - > > configs/rock-pi-s-rk3308_defconfig | 1 - > > configs/sandbox64_defconfig | 1 - > > configs/sandbox_defconfig | 1 - > > configs/sandbox_flattree_defconfig | 1 - > > configs/sandbox_noinst_defconfig | 1 - > > configs/sandbox_spl_defconfig | 1 - > > configs/sandbox_vpl_defconfig | 1 - > > configs/xilinx_versal_net_virt_defconfig | 1 - > > configs/xilinx_zynqmp_virt_defconfig | 1 - > > drivers/block/Kconfig | 2 +- > > drivers/fastboot/Kconfig | 2 +- > > drivers/i2c/Kconfig | 16 ++++++++-------- > > drivers/misc/Kconfig | 2 +- > > drivers/serial/Kconfig | 6 +++--- > > drivers/usb/gadget/Kconfig | 2 +- > > drivers/video/Kconfig | 4 ++-- > > env/Kconfig | 4 ++-- > > lib/Kconfig | 2 +- > > 47 files changed, 38 insertions(+), 64 deletions(-) > > >=20 > I'm not sure how you found all those, but it looks good to me from a spot= check. Manually. It's thankfully not many cases of "default 0". > Can we have a checkpatch check? Sadly, no. But I think if we spent some time fixing other issues too, kconfiglib could be used as a tool to catch these. --=20 Tom --8r2G/cBry3U3QbCQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmTLl0IACgkQFHw5/5Y0 tyxH4Qv/cEHZqlNcF96Ih9XzjrCHFwa4X8AXuSx7Vbb21GNNhOH3KT7Q1HAeCC8U K1Qw1bxQmkOdzlrCMYOeHcmtFsxvN+ysqv+cAWHhgAnjhyh0AQevyDLKvIMpdRKt tdpracUbOhY9i5mX0SrRxrCZacoFNC9VKhQutyWOck7AvgFuubGT4ha2swCOy8tc lybTL5wBksw8HZVSfTM9wCDRlasCgh3J3I2pyz9m3LgJ7P9VvKTEi+Q/4/XmCqJ3 hZ2N97bZr62gdX58eSffl0BK3s91qfj8Gdq/31av5Jt/whnq9NZjwG/z1pHlSUEw dTdaJYY3pfnMKKs7xrPqfsx3z18CKGoX8d3hpe6MdQxNI7CRK8RYEfOwDFVV1U+Y HJT0bOpT744OwRXRrIynO7kBzEgI4WXJCQ3QvIwcPZpj3D+53wqC9hfPM2yIyqye 18n7Qfq06oyqnI8lNVFTB3WpdZeVyBsvv7tCXKG+9CWWYJ4FXHhGwLuP7IdGpiLm jlYyXNvy =hOTy -----END PGP SIGNATURE----- --8r2G/cBry3U3QbCQ--