Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 900A8C001DF for ; Fri, 4 Aug 2023 13:54:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A27BB867B6; Fri, 4 Aug 2023 15:54:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="aTsWU5E/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 74815868BB; Fri, 4 Aug 2023 15:54:41 +0200 (CEST) Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 319DD86722 for ; Fri, 4 Aug 2023 15:54:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-585ff234cd1so23175467b3.3 for ; Fri, 04 Aug 2023 06:54:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1691157278; x=1691762078; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UbLinscImMrAVgt17JGVUf+8aPctxRaxhqA0DYZCh+8=; b=aTsWU5E/GKQQm8XvmRsptFQmfAIWLk8Kg6UulOK6prrga6vsg1KFpAazhebLVYmi0T hhe3p6u43Qwq/BrYPGiexNcCuUN/03V3JrCIYDFLui9kXt9gQLd4DQWu0WYMyM096gvU 1ctM4gYWo1XJKXeTs/CK+SdsbjHRV7xkg9uJ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691157278; x=1691762078; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UbLinscImMrAVgt17JGVUf+8aPctxRaxhqA0DYZCh+8=; b=Ow957plLorIVkdsNiF5zWHoAqDb/F+r7Gx7zu/hX7ATqrmS0Bc2sddpBFFrfjYGkvX bs226FvWFvq8j19+reqx9tz3QL33MVumLucs10S25tVBSdtopjP8vAdb7NvSA00XLmH3 zcFXXLvYBafYCYDAWp0eVZE8ntaS6d90eYis9JD+N8msN874fgn92STbKcQl2LOxGPBc XUkQdfGf/+Cdue0YPIHTZWCrU1CyrLR5823xd9egEPYrbQnmTroKu+1GwvvOjzoaxdCW 0PDSV9A0JEsGVsOjVTvJXzJYEAtkPlJwjUUZgu8KvI0rNXJ1sNeXXFa9wG+6+veg4Usz CIIw== X-Gm-Message-State: AOJu0Yxd2MfkEBXz8eEeleQAVCtxt85CzXDdP4xynm9944c4IhWVmg0f 4jM2MUgkC/8LjdEQAJOhliPZig== X-Google-Smtp-Source: AGHT+IHiubEdqdfeSN9NJZqASntvz2cUt4NxslVAyVjG9F7riPSgTyFeZLjXL8mmpMA0xEvmkpv4wQ== X-Received: by 2002:a81:4e15:0:b0:583:b7d0:cc7a with SMTP id c21-20020a814e15000000b00583b7d0cc7amr1803156ywb.42.1691157277906; Fri, 04 Aug 2023 06:54:37 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-c37f-6e0c-fce7-d587.res6.spectrum.com. [2603:6081:7b00:6400:c37f:6e0c:fce7:d587]) by smtp.gmail.com with ESMTPSA id s5-20020a0de905000000b00576e5af0249sm717999ywe.20.2023.08.04.06.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Aug 2023 06:54:37 -0700 (PDT) Date: Fri, 4 Aug 2023 09:54:34 -0400 From: Tom Rini To: Macpaul Lin Cc: u-boot@lists.denx.de, Fabien Parent , Amjad Ouled-Ameur , Simon Glass , Marek Vasut , Bear Wang , Pablo Sun , Macpaul Lin , Chunfeng Yun , GSS_MTK_Uboot_upstream , Ryder Lee , Sam Shih , Weijie Gao Subject: Re: [PATCH v5 2/2] board: mediatek: add mt8195 demo board Message-ID: <20230804135434.GL3630934@bill-the-cat> References: <20230804110448.24589-1-macpaul.lin@mediatek.com> <20230804110448.24589-2-macpaul.lin@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XvT/30OuhRiMBZl8" Content-Disposition: inline In-Reply-To: <20230804110448.24589-2-macpaul.lin@mediatek.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --XvT/30OuhRiMBZl8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 04, 2023 at 07:04:48PM +0800, Macpaul Lin wrote: > From: Fabien Parent >=20 > Add mt8195-demo board support. > This demo purpose board uses MediaTek's MT8195 SoC. >=20 > Signed-off-by: Fabien Parent > Signed-off-by: Amjad Ouled-Ameur > Signed-off-by: Macpaul Lin [snip] > diff --git a/board/mediatek/mt8195/MAINTAINERS b/board/mediatek/mt8195/MA= INTAINERS > new file mode 100644 > index 0000000000..01fa25115d > --- /dev/null > +++ b/board/mediatek/mt8195/MAINTAINERS > @@ -0,0 +1,6 @@ > +MT8195 Demo > +M: Macpaul Lin > +S: Maintained > +F: board/mediatek/mt8195 > +F: include/configs/mt8195.h > +F: configs/mt8195_demo_defconfig Please list the dts files here too, and these are being synced with Linux, yes? [snip] > diff --git a/include/configs/mt8195.h b/include/configs/mt8195.h > new file mode 100644 > index 0000000000..7af06da6ea > --- /dev/null > +++ b/include/configs/mt8195.h > @@ -0,0 +1,46 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * Configuration for MT8195 based boards > + * > + * Copyright (C) 2023 MediaTek Inc. > + * Copyright (C) 2023 BayLibre, SAS > + * Author: Macpaul Lin > + * Author: Fabien Parent > + */ > + > +#ifndef __MT8195_H > +#define __MT8195_H > + > +#include Drop this, especially as there was just some time spent fixing "need in a generic header" mediatek code. > +/* Environment settings */ > +#include > + > +#if IS_ENABLED(CONFIG_CMD_MMC) > +#define BOOT_TARGET_MMC(func) func(MMC, mmc, 0) > +#else > +#define BOOT_TARGET_MMC(func) > +#endif > + > +#if IS_ENABLED(CONFIG_CMD_USB) > +#define BOOT_TARGET_USB(func) func(USB, usb, 0) > +#else > +#define BOOT_TARGET_USB(func) > +#endif > + > +#define BOOT_TARGET_DEVICES(func) \ > + BOOT_TARGET_MMC(func) \ > + BOOT_TARGET_USB(func) > + > +#if !defined(CFG_EXTRA_ENV_SETTINGS) > +#define CFG_EXTRA_ENV_SETTINGS \ > + "scriptaddr=3D0x40000000\0" \ > + "fdt_addr_r=3D0x44000000\0" \ > + "fdtoverlay_addr_r=3D0x44c00000\0" \ > + "kernel_addr_r=3D0x45000000\0" \ > + "ramdisk_addr_r=3D0x46000000\0" \ > + "fdtfile=3D" CONFIG_DEFAULT_DEVICE_TREE ".dtb\0" \ > + BOOTENV > +#endif Please look at moving to plain text environment, thanks. --=20 Tom --XvT/30OuhRiMBZl8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmTNAxcACgkQFHw5/5Y0 tyxADQv+PQx41X35EJQmFzB24ZVA8oG3HSmIeqWUt9CCLDetXg3DegAKwFBzvZCg xyM2bqUGtuFwPKLzvUgRQsOhQa0CKDHiPTup4fXDTG0dbpWD9mOSG8w2rkYuIHiw 2z3HW6uVu/qXzteMSEFDWynGy2lndjrCXnqGyVcZATpLAYbuK5L2vJqh6+9wfh7L CzQEqbElqIRil5ATEFBdJ3R+eD/6EOm9o570DJSIMbe7TgyH0F4bdk0DAa4LZ9sh MkMeO6UwDZoLd4qf/Ki4n38NGlh26yyF8Hua1IHWnIEw91ojMRAvNjtX20/Ol9tR nYZyuPkD3NUX2+7S1S35pnll8jYYUoGBSnMqbrNLjiOPpzyMWsJEIqUqCS1Awftp FW/JOKx9PweH+ir+5nWsy+0M1pA+USdjrsi4be+CZnZH3CfTthWSqr53P3eEUUPV uT2l5EcmUrpcl9qkSZH+E8dg3bLwKfchweoA6dK0G9FYdtYAsvPRcx17kpsfvgVe jgW7Fh3+ =gokf -----END PGP SIGNATURE----- --XvT/30OuhRiMBZl8--