Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64B8D440E for ; Fri, 4 Aug 2023 19:40:59 +0000 (UTC) Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FFE3E7; Fri, 4 Aug 2023 12:40:58 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qS0fP-0007ip-9T; Fri, 04 Aug 2023 21:40:55 +0200 Date: Fri, 4 Aug 2023 21:40:55 +0200 From: Florian Westphal To: Maciej =?utf-8?Q?=C5=BBenczykowski?= Cc: Florian Westphal , coreteam@netfilter.org, kadlec@netfilter.org, Pablo Neira Ayuso , Linux Network Development Mailing List , Netfilter Development Mailing List , Martin KaFai Lau Subject: Re: [PATCH netfilter] netfilter: nfnetlink_log: always add a timestamp Message-ID: <20230804194055.GO30550@breakpoint.cc> References: <20230725085443.2102634-1-maze@google.com> <20230727135825.GF2963@breakpoint.cc> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Maciej Żenczykowski wrote: > On Thu, Jul 27, 2023 at 3:58 PM Florian Westphal wrote: > > > > Maciej Żenczykowski wrote: > > > Compared to all the other work we're already doing to deliver > > > an skb to userspace this is very cheap - at worse an extra > > > call to ktime_get_real() - and very useful. > > > > Reviewed-by: Florian Westphal > > I'm not sure if there's anything else that needs to happen for this to > get merged. This is fine, it'll be merged for -next.