From: Christoph Hellwig Subject: Re: [PATCH 06/12] fs: use the super_block as holder when mounting file systems Date: Sat, 5 Aug 2023 10:36:17 +0200 Message-ID: <20230805083617.GB29780@lst.de> References: <20230802154131.2221419-1-hch@lst.de> <20230802154131.2221419-7-hch@lst.de> <20230803115131.w6hbhjvvkqnv4qbq@quack3> <20230803133330.dstks7aogjogqdd5@quack3> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20230803133330.dstks7aogjogqdd5@quack3> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jan Kara Cc: Christoph Hellwig , Al Viro , Christian Brauner , Chris Mason , Josef Bacik , David Sterba , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Chao Yu , Ryusuke Konishi , "Darrick J. Wong" , Jens Axboe , linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-f2fs-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Thu, Aug 03, 2023 at 03:33:30PM +0200, Jan Kara wrote: > As a side note, after this patch we can also remove bdev->bd_super and > transition the two real users (mark_buffer_write_io_error() and two places > in ocfs2) to use bd_holder. Ext4 also uses bd_super but there it is really > pointless as we have the superblock directly available in that function > anyway. I actually have a series to kill bd_super, but it uses b_assoc_map as the replacement, as nothing in buffer.c should poke into the holder and the buffer_head codes uses b_assoc_map a lot anyway. Let me rebase it and send it out.