Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D00CC001B0 for ; Sun, 6 Aug 2023 15:54:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 74D6E8660E; Sun, 6 Aug 2023 17:54:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="h8KyDMiB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9B0C686679; Sun, 6 Aug 2023 17:54:14 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5528D865D9 for ; Sun, 6 Aug 2023 17:54:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6F3646119D; Sun, 6 Aug 2023 15:54:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A77DFC433C8; Sun, 6 Aug 2023 15:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691337249; bh=i1+Kv3K6BMKkv6GSYMh4z3SVncIi6VbJDgIK7C4aiKo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h8KyDMiBGOGeuy5L1zXKkS6lehTp6k1JkRvJ3amsw1XijyAub53NJGHzLKFX0PRXC +eM99SOCUfNDHY7Nh8mncT51yBuleeFYwuGNQACTFUHidq0DYRlwUPzg7qhLronm/e M/UsmfjK81imjG7otdOG9xd4IhqlGqOtYCRFzLQjGTt8HEP/Mkw1CTiHD/5hs1Ec+o t0AiFS1BPl+aH2PRV2g8slpYfODF6g5NjM7LOhp3cUdAGX1BbUoFaKg6JZZ7fhqkP/ ZiUiVsmpV8UsoZtxjZlvkcMEm4wxSgH1UxQydcfVyeKrjQRGAN2tlPM26zpYmekAKR 4tXtgKTaIYDdg== Received: by pali.im (Postfix) id A627E80E; Sun, 6 Aug 2023 17:54:06 +0200 (CEST) Date: Sun, 6 Aug 2023 17:54:06 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Simon Glass Cc: U-Boot Mailing List , Bin Meng , Alper Nebi Yasak , Daniel Golle , Heinrich Schuchardt , Mattijs Korpershoek , Safae Ouajih Subject: Re: [PATCH 00/16] bootstd: Improve ChromiumOS support Message-ID: <20230806155406.dk55mwpl54ozsbuu@pali> References: <20230730171709.917352-1-sjg@chromium.org> <20230806110027.cucgnik34psuwv6h@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Sunday 06 August 2023 08:28:12 Simon Glass wrote: > Hi Pali, > > On Sun, 6 Aug 2023 at 05:00, Pali Rohár wrote: > > > > I have never asked to want receive emails related to chromiumos, so do > > not send these changes to me. > > You received the last patch (and therefore the cover letter) because > you committed to boot/bootm.c recently, which is affected by that > patch. So stop sending me these emails. I'm not going to review any chromiumos changes. > > > > On Sunday 30 July 2023 11:16:46 Simon Glass wrote: > > > The ChromiumOS bootmeth is fairly basic at present. It is able to boot > > > only x86 kernels and contains quite a few hard-coded offsets. > > > > > > This series tidies it up by bringing in some vboot structures and adding > > > support for ARM. > > > > > > It adds a few more features to bootstd, including display of x86 setup > > > information. > > > > > > So far this does not actually boot correctly on any ARM Chromebook: > > > > > > jerry - hangs when booting kernel > > > bob - Bad Linux ARM64 Image magic! with lz4-compressed kernel > > > > > > Further work can address these issues. > > > > > > > > > Simon Glass (16): > > > bootstd: cros: Correct reporting of I/O errors > > > bootstd: cros: Move partition reading into a function > > > bootstd: cros: Bring in some ChromiumOS structures > > > bootstd: cros: Support a kernel on either partition > > > bootstd: cros: Decode some kernel preamble fields > > > bootstd: cros: Simplify setup and cmdline expressions > > > bootstd: Move common zimage functions to bootm.h > > > bootstd: cros: Add docs for the kernel layout > > > bootstd: cros: Add private info for ChromiumOS > > > bootstd: Add private bootmeth data to the bootflow > > > bootstd: cros: Add a function to read info from partition > > > bootstd: cros: Add a function to read a kernel > > > bootstd: cros: Split up reading info and kernel > > > bootstd: Allow display of the x86 setup information > > > bootstd: Add a command to read all files for a bootflow > > > bootstd: cros: Add ARM support > > > > > > arch/x86/include/asm/zimage.h | 37 ---- > > > arch/x86/lib/zimage.c | 8 +- > > > boot/Kconfig | 4 +- > > > boot/bootflow.c | 15 ++ > > > boot/bootm.c | 37 ++++ > > > boot/bootmeth-uclass.c | 10 + > > > boot/bootmeth_cros.c | 363 ++++++++++++++++++++++++++++------ > > > boot/bootmeth_cros.h | 197 ++++++++++++++++++ > > > cmd/bootflow.c | 47 ++++- > > > doc/usage/cmd/bootflow.rst | 139 ++++++++++++- > > > include/bootflow.h | 15 +- > > > include/bootm.h | 47 +++++ > > > include/bootmeth.h | 23 +++ > > > 13 files changed, 836 insertions(+), 106 deletions(-) > > > create mode 100644 boot/bootmeth_cros.h > > > > > > -- > > > 2.41.0.487.g6d72f3e995-goog > > > > > Regards, > Simon