Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FE62EB64DD for ; Mon, 7 Aug 2023 12:17:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EAD5380771; Mon, 7 Aug 2023 14:17:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="a6qOasKv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5458F86915; Mon, 7 Aug 2023 09:00:19 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4D2E284788 for ; Mon, 7 Aug 2023 09:00:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mwalle@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6054961049; Mon, 7 Aug 2023 07:00:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A64D2C433C7; Mon, 7 Aug 2023 07:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691391614; bh=+yrC8fUlSq4T7MAkeZuvurAbFCM1eEPHHQ3gI/LK3A8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a6qOasKv4flWKX1E5eKOWRT+Va9Rwdz9Tlr4GVztQ0THrGLBOiHZ8GXX75vmDqRPj 6EkKTv7gIzIGQYUnwWA82PdO4ZstTwP1vVne7BKVpEsvSXiCv8JlVAJ5jjfFwXAHRS tarGFbRhfiIVEmmxreCpuEyDaN4LXNYkdhEFnPzEyD//PtrWVHsTcYYwPESiC2k0+0 LfITiQvU8xvwcu9QXsOvov64I7g+amtCINx38OOeXAPND+RGJs0IuKChSJl6AjXs20 WfU+SrUp2WEhq3TgHZWWu+TsIGB4AACXpc0+sSmO95jf7JjyhKAc2MzAWif98kmSvi Bq0pB7gcP5Lbw== From: Michael Walle To: macpaul.lin@mediatek.com Cc: GSS_MTK_Uboot_upstream@mediatek.com, Ryder.Lee@mediatek.com, aouledameur@baylibre.com, bear.wang@mediatek.com, chunfeng.yun@mediatek.com, fparent@baylibre.com, macpaul@gmail.com, marex@denx.de, pablo.sun@mediatek.com, sam.shih@mediatek.com, sjg@chromium.org, trini@konsulko.com, u-boot@lists.denx.de, weijie.gao@mediatek.com, Michael Walle Subject: Re: [PATCH v5 2/2] board: mediatek: add mt8195 demo board Date: Mon, 7 Aug 2023 08:59:47 +0200 Message-Id: <20230807065947.2188484-1-mwalle@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230804110448.24589-2-macpaul.lin@mediatek.com> References: <20230804110448.24589-2-macpaul.lin@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Mon, 07 Aug 2023 14:17:55 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi, > + printf("Disabling WDT\n"); > + writel(0, 0x10007000); Please don't use magic numbers. Also, I guess this should be a real watchdog driver and u-boot will take care of disabling it if the user wants to. > + > + printf("Enabling SCP SRAM\n"); > + for (unsigned int val = 0xFFFFFFFF; val != 0U;) { > + val = val >> 1; > + writel(val, 0x1072102C); Even more magic numbers. > + } Thanks, -michael