Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D595EB64DD for ; Mon, 7 Aug 2023 07:53:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y4duE2yX6cM6zL8MGlBSnsK9cyQJcZigP25pwX6ffWI=; b=uMqcFzST6lYt98 jQtaGc85oSfGXCheEzPXL2xavXT/AwQu9C+YOhPCwhzo4lpHDiLIRjBugHg34+gi5hX2kOF9L3Z6r SSlG+AXhPi5Wgw0YZcN/6cMbiBXfF2z/JNZa9IOD4zOf2mgh3sshDnD+2DjXI8QOTfDzajtIZbudR cEvZzsevY71aZb+IsklqPdq0H8TUfoPmk5p8MHwpIwXRZPVgLcJVud1RZlvPcF9qpO2LpItX+CUHa uA8s+2LfSJdwhNJzsF+U4KgkhzG5QEOyAgKSU5maZ99lHClDV6YTyPS7cwlJLxqWYfZFPaDfU0f3Y b8ML+NtG+xzqyNTWlBYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSv3N-00GOpj-28; Mon, 07 Aug 2023 07:53:25 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qSv3K-00GOpA-2S for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 07:53:24 +0000 X-UUID: 74af755e34f711ee83ed1395ce914268-20230807 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=LkWwtZsl/ZS2ofti0t2kC2R0Fufo15InoHqryA/vhoA=; b=ZbkBirJnxdcW2Wb91f84BI/K9t2jkpCNbCPfHHTZP0xMuzofUkoYh5bDH49O8kTzqt4WM9IEidqxxj8O5QiZx6HfoCB3iRzhrZQMDz8JvZwyXQEReeoKuIfjvBJepxDJ2EP1lPYmEFMmXNMNaUwzuoJZAedflFDTT1YnlSu/Lak=; X-CID-UNFAMILIAR: 1 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.30,REQID:2c10eb6c-a2fb-41c7-a3d7-ad9275f7f53e,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:54,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:54 X-CID-INFO: VERSION:1.1.30,REQID:2c10eb6c-a2fb-41c7-a3d7-ad9275f7f53e,IP:0,URL :0,TC:0,Content:0,EDM:0,RT:0,SF:54,FILE:0,BULK:0,RULE:Release_HamU,ACTION: release,TS:54 X-CID-META: VersionHash:1fcc6f8,CLOUDID:b259f8a0-0933-4333-8d4f-6c3c53ebd55b,B ulkID:230807155314HNJ7Q37Q,BulkQuantity:0,Recheck:0,SF:29|28|16|19|48|102, TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL: 0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SDM,TF_CID_SPAM_USA,TF_CID_SPAM_FSD,TF_CID_SPAM_ULS, TF_CID_SPAM_SNR X-UUID: 74af755e34f711ee83ed1395ce914268-20230807 Received: from mtkmbs14n2.mediatek.inc [(172.21.101.76)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 400226140; Mon, 07 Aug 2023 00:53:11 -0700 Received: from mtkmbs13n2.mediatek.inc (172.21.101.108) by MTKMBS14N2.mediatek.inc (172.21.101.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Mon, 7 Aug 2023 15:53:09 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Mon, 7 Aug 2023 15:53:09 +0800 From: Lecopzer Chen To: CC: , , , , , Subject: Re: [PATCH] ARM: ptrace: fix scno of -1 cause SIGILL Date: Mon, 7 Aug 2023 15:53:09 +0800 Message-ID: <20230807075309.6188-1-lecopzer.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20230724121655.7894-1-lecopzer.chen@mediatek.com> References: <20230724121655.7894-1-lecopzer.chen@mediatek.com> MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_005322_804299_D5CC51F3 X-CRM114-Status: UNSURE ( 9.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > In commit [1], the -1 scno is used as a special scno when the task's > syscall is traced. > After commit [2], PTRACE_SET_SYSCALL will always mask syscall with > __NR_SYSCALL_MASK, this makes the condition `cmp scno, #-1` broken, > and some test like Android VTS[3] is also failed because SIGILL > interrupt the test program. > Let's test with `and` logic with #0x0ff000. Instead of #__NR_SYSCALL_MASK > because of the constraint of ARM Operand2 rules and avoid conflicting > with ARM private syscall. ... Please follow the commit from Kees below and ignore this patch, thanks. https://lore.kernel.org/all/20230804071045.never.134-kees@kernel.org/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel