Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E6FAC001B0 for ; Sat, 12 Aug 2023 10:00:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4678086974; Sat, 12 Aug 2023 12:00:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="T3wS/XX1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E48B586974; Sat, 12 Aug 2023 12:00:24 +0200 (CEST) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BFC6486962 for ; Sat, 12 Aug 2023 12:00:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=clamor95@gmail.com Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-98377c5d53eso369309366b.0 for ; Sat, 12 Aug 2023 03:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691834422; x=1692439222; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7ME9sT9ak4mqAm+M5T7oQpxV5/F7KRiY5Skg77ueEUE=; b=T3wS/XX11MB1m6Z2sLNgCabAjweW4T4YtezxL9QSUo7j4d8TSeb6OI2EyG8Zoc931M AQTyVr7+zXty53VG5a/sMePqYWfOEDl/v1c+AueWRsnGTDlHIhuNinvU9vNjSHLGrD80 exkdQmjCqNHKD0f1WbDfJPZ68qHZmLnGHK0ERRQfkyvJl6TOuj+IU3bxpQIjjFVzkszg j3a1mVTQdf103tjSVJ4ZipY/l3hx7mnUcYp/6Q7pg5/kp1D833U96b4SjNlxNDn3PVyH DH9iPBynUGgpDMNmti4C1bFlNqckMjIfOeQRPPP2qF8H7GwFCCLCa1jmDMpDwG70gzzg QFOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691834422; x=1692439222; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7ME9sT9ak4mqAm+M5T7oQpxV5/F7KRiY5Skg77ueEUE=; b=T2KAf6tBbzU2LooPgHNlxj9IhAUHAWFeg3H1zTkspUgH9sVK4O++1ZH3nObfwRAvBe S6UEE/SYjv18h1+YkJYHEjSauGotLd8JrPsBQfePCA5b4xDTuWybTTSifjUFAsU2TbqH b98lkc1n9J8FgZNODYdH8QS/YOEat4if+XzP3RBPD6dt2axw5jC5U7gbWTgOHCzlPvJg 9jHANrvWXi1Nhs1eSnS/13hAYJWImxXMkqMHq2yuDSM8EUMecWUoNlL4yJC3B7bvr5wi l0wVdO6UQpSXYzTrUnIylxKEv+DPfrJ9lLnYxtq3NpaeZpeoPHOptSWrQWRTrwHyCJ0D /FOA== X-Gm-Message-State: AOJu0YxiTHVmH80bC4c28mEdZcSp/Wj/W47sYV3hYfgVaIQq0kas+W3k YHkSbO9Wam3uBubZaeTXvcw= X-Google-Smtp-Source: AGHT+IGvZdb8b6c1WlAxioq7pbMW3ZoDvlNDTjOhnyo18M4KsgVtzHrsiIwNNxPzSxnId7wU3s1Kjw== X-Received: by 2002:a17:906:1041:b0:988:f93:32e8 with SMTP id j1-20020a170906104100b009880f9332e8mr3753869ejj.26.1691834421915; Sat, 12 Aug 2023 03:00:21 -0700 (PDT) Received: from xeon.. ([188.163.112.48]) by smtp.gmail.com with ESMTPSA id e3-20020a170906248300b0099d02ca4327sm3265453ejb.54.2023.08.12.03.00.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Aug 2023 03:00:21 -0700 (PDT) From: Svyatoslav Ryhel To: Anatolij Gustschin , Simon Glass , Jonas Karlman , Svyatoslav Ryhel Cc: u-boot@lists.denx.de Subject: [PATCH v1 1/3] video: pwm_backlight: use regulator_set_enable_if_allowed Date: Sat, 12 Aug 2023 12:59:50 +0300 Message-Id: <20230812095952.27380-2-clamor95@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230812095952.27380-1-clamor95@gmail.com> References: <20230812095952.27380-1-clamor95@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean With the commit 4fcba5d556b4 ("regulator: implement basic reference counter") the return value of regulator_set_enable may be EALREADY or EBUSY for fixed/gpio regulators and may be further expanded on all regulators. Change to use the more relaxed regulator_set_enable_if_allowed to continue if regulator already was enabled or disabled. Signed-off-by: Svyatoslav Ryhel --- drivers/video/pwm_backlight.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/video/pwm_backlight.c b/drivers/video/pwm_backlight.c index 46c16a8f44..4b35e2b120 100644 --- a/drivers/video/pwm_backlight.c +++ b/drivers/video/pwm_backlight.c @@ -97,7 +97,7 @@ static int enable_sequence(struct udevice *dev, int seq) plat = dev_get_uclass_plat(priv->reg); log_debug("Enable '%s', regulator '%s'/'%s'\n", dev->name, priv->reg->name, plat->name); - ret = regulator_set_enable(priv->reg, true); + ret = regulator_set_enable_if_allowed(priv->reg, true); if (ret) { log_debug("Cannot enable regulator for PWM '%s'\n", dev->name); @@ -178,11 +178,10 @@ static int pwm_backlight_set_brightness(struct udevice *dev, int percent) } if (disable) { dm_gpio_set_value(&priv->enable, 0); - if (priv->reg) { - ret = regulator_set_enable(priv->reg, false); - if (ret) - return log_ret(ret); - } + ret = regulator_set_enable_if_allowed(priv->reg, false); + if (ret) + return log_ret(ret); + priv->enabled = false; } -- 2.39.2