Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47FB4C0015E for ; Sat, 12 Aug 2023 10:00:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8C0188697A; Sat, 12 Aug 2023 12:00:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GEkZdZVc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B93F086974; Sat, 12 Aug 2023 12:00:25 +0200 (CEST) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E548086951 for ; Sat, 12 Aug 2023 12:00:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=clamor95@gmail.com Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-99bed101b70so377466066b.3 for ; Sat, 12 Aug 2023 03:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691834423; x=1692439223; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3f+BeQOuZNN0I9kPeyaE7gW/Knz9qwCxa7jBviJTzb4=; b=GEkZdZVcQ5FHfWqmEMo0l3NNUGqojtE0R8lJlmWxHfsAzMVZbrHC87yY0o2Rkxoc7j KnQyW8R1OdzIxpcpzjJgZjix3k68sMKfmTjho5TizNS19uConOHwECSDljZYZr8IotKA p/OjZ6y/0VmSICSX9ece5id2UGSzdz1THHvvZ//BmI1WBwSSDjlEGbnSHT9l+jFNXV+K GuN+7DyAA7hkh1tsOApg91rPRCzUaIuRb3FOjK3t5ppBcO4aZHDk+wToRs7L6jKjGrWo ey4dALFjRFf0+3f+XLKKP0fkGYPt3PCWOGc88YYgzvsLsfSDOcIKxKoPByQiEAWlmial 3zJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691834423; x=1692439223; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3f+BeQOuZNN0I9kPeyaE7gW/Knz9qwCxa7jBviJTzb4=; b=NDpVH6PvmVLtFPdQzAF4dFpWSj4gd6KfrDNZXrQab8KVqWDeY7ghUudwWmK9Vt1s0o XubYd1LPm0A3hTW2xVzoy5vV8YgjcA3VznmUc1b5KoXjkBJyv8pnSPwniHNQ/ECZzBfQ DWRvNxN24NEi7OvgsglS1nR4eSNw0h14frLyZLyaP+O0Gs9x8VytOmn6RVqUTDVt/tsb O4C0sdYWwHt0s1J59FBfc6I1PuMMZ0rjZAD1BmBJDMxVlpxYsnNJgHTcRLrI1tOa+k26 8jycT+8dlR+PiZShv03VvPM7AiJD+mU7GFnlFh4bvWRrzlcbiNgyxht6PslEdE74n+mo ok4w== X-Gm-Message-State: AOJu0YzM26NQXT82deZGPtdG7TTakLpkSO6Mg0vZMPkCfGMxniQ17ilX RHL75xTqcof6MJR6Zpo99ug= X-Google-Smtp-Source: AGHT+IHeJpvYf+N8HYaQs/XFrlVYjQF4+Uh4WLI7uTPhGtm5VNYOgFM12gz3AVAJgKg5TkmL/Jt3GA== X-Received: by 2002:a17:906:cc14:b0:99b:ff9d:93f2 with SMTP id ml20-20020a170906cc1400b0099bff9d93f2mr3899072ejb.42.1691834423290; Sat, 12 Aug 2023 03:00:23 -0700 (PDT) Received: from xeon.. ([188.163.112.48]) by smtp.gmail.com with ESMTPSA id e3-20020a170906248300b0099d02ca4327sm3265453ejb.54.2023.08.12.03.00.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Aug 2023 03:00:22 -0700 (PDT) From: Svyatoslav Ryhel To: Anatolij Gustschin , Simon Glass , Jonas Karlman , Svyatoslav Ryhel Cc: u-boot@lists.denx.de Subject: [PATCH v1 2/3] video: simple_panel: use regulator_set_enable_if_allowed Date: Sat, 12 Aug 2023 12:59:51 +0300 Message-Id: <20230812095952.27380-3-clamor95@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230812095952.27380-1-clamor95@gmail.com> References: <20230812095952.27380-1-clamor95@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean With the commit 4fcba5d556b4 ("regulator: implement basic reference counter") the return value of regulator_set_enable may be EALREADY or EBUSY for fixed/gpio regulators and may be further expanded on all regulators. Change to use the more relaxed regulator_set_enable_if_allowed to continue if regulator already was enabled or disabled. Signed-off-by: Svyatoslav Ryhel --- drivers/video/simple_panel.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/simple_panel.c b/drivers/video/simple_panel.c index 6a6473eb0e..eb4eed217d 100644 --- a/drivers/video/simple_panel.c +++ b/drivers/video/simple_panel.c @@ -114,11 +114,11 @@ static int simple_panel_probe(struct udevice *dev) const u32 dsi_data = dev_get_driver_data(dev); int ret; - if (CONFIG_IS_ENABLED(DM_REGULATOR) && priv->reg) { - debug("%s: Enable regulator '%s'\n", __func__, priv->reg->name); - ret = regulator_set_enable(priv->reg, true); - if (ret) - return ret; + ret = regulator_set_enable_if_allowed(priv->reg, true); + if (ret) { + debug("%s: failed to enable regulator '%s' %d\n", + __func__, priv->reg->name, ret); + return ret; } switch (dsi_data) { -- 2.39.2