Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48584C001B0 for ; Sat, 12 Aug 2023 10:46:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0278F86951; Sat, 12 Aug 2023 12:46:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="J0GGVbPQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5A2F286974; Sat, 12 Aug 2023 12:46:15 +0200 (CEST) Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9EF3086963 for ; Sat, 12 Aug 2023 12:46:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=clamor95@gmail.com Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-99bf1f632b8so390697266b.1 for ; Sat, 12 Aug 2023 03:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691837172; x=1692441972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cOAMR8uQ7AIukEgE07sxvY580KQDj+NcF1W0RijSo6o=; b=J0GGVbPQ4hN2yHj0OnraGni+YaGCoiy67d5s7XRLYTKBqDOP6unTb5RQqPhZEViutD jaAtF70bVp8IGi/j2AHYH5xhM2SO6P075NZLJTrfgx1DWpC/9R9UOSt2vwO844HdsXFm U/U2MY3KMofZnzFA0WP5HZt37sq9ljFyL/5hajrlKpBXXEa3DIMuqpEwUg5S+Qyx+KPI JFyRUAKPVmnH+qfoJRliph2ZBg0of5ZT0pLsgw7UsIO66cgIz4nmAqQ/VjI61CYSoK+5 eGKfuX2nMa6dvK7MmLDXCo0Jc6r18UHDjDLmgTpBYLj/s0OvXHYFQznv1wXf32pmXBkJ XWFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691837172; x=1692441972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cOAMR8uQ7AIukEgE07sxvY580KQDj+NcF1W0RijSo6o=; b=f2mksrDDAhzkuvVVRDLO87JF980sHouBXy+YLpAZ8ZXCRinf7VVrdwciNx+Ltud8in VLiK8kUglYZ7dNcGfXzdLPJXGtgILykyrMVM0OMGxNyjuLLmj4g7aSR3L/rYvQmHx8kO TRqtwDO9Y0HckxlMIzH+RF4iXnwL4nOSVmz3yaJ95CU9CXZQ1VX78f3zxlfZ8lyMY645 jUIbbK1DDuROwHqHAsyzWSYUeoIQx+TiCBifNAtXu6URmN2svrNMiJ33NlMr9/Xp4eh8 dRpKnzkEfb1k0Se+dBKKhvfe+82M8Wqkgl6i67pMl6KFO3doHpsV+qQ5z0G7e6Z/kJ+1 YYZQ== X-Gm-Message-State: AOJu0YxUiaimN/c9MD5TUrcd25A3ms4rjDEz8OdrkDtgg78x1JG47DrE I3pDCrSMkvNJUWPofX4oP6o= X-Google-Smtp-Source: AGHT+IEbpaGBQW3ILstGLiyiuciuE0bvx51/QJcJ3kZTI1WYx+n5lX1k88Bz+rlmfWde36rXI+GUHA== X-Received: by 2002:a17:906:538d:b0:991:d2a8:658a with SMTP id g13-20020a170906538d00b00991d2a8658amr3585757ejo.34.1691837172130; Sat, 12 Aug 2023 03:46:12 -0700 (PDT) Received: from xeon.. ([188.163.112.48]) by smtp.gmail.com with ESMTPSA id kd28-20020a17090798dc00b009937e7c4e54sm3342484ejc.39.2023.08.12.03.46.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Aug 2023 03:46:11 -0700 (PDT) From: Svyatoslav Ryhel To: Anatolij Gustschin , Simon Glass , Jonas Karlman , Svyatoslav Ryhel Cc: u-boot@lists.denx.de Subject: [PATCH v2 2/3] video: simple_panel: use regulator_set_enable_if_allowed Date: Sat, 12 Aug 2023 13:45:51 +0300 Message-Id: <20230812104552.32043-3-clamor95@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230812104552.32043-1-clamor95@gmail.com> References: <20230812104552.32043-1-clamor95@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean With the commit 4fcba5d556b4 ("regulator: implement basic reference counter") the return value of regulator_set_enable may be EALREADY or EBUSY for fixed/gpio regulators and may be further expanded on all regulators. Change to use the more relaxed regulator_set_enable_if_allowed to continue if regulator already was enabled or disabled. Signed-off-by: Svyatoslav Ryhel --- drivers/video/simple_panel.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/simple_panel.c b/drivers/video/simple_panel.c index 6a6473eb0e..efb122b534 100644 --- a/drivers/video/simple_panel.c +++ b/drivers/video/simple_panel.c @@ -114,11 +114,11 @@ static int simple_panel_probe(struct udevice *dev) const u32 dsi_data = dev_get_driver_data(dev); int ret; - if (CONFIG_IS_ENABLED(DM_REGULATOR) && priv->reg) { - debug("%s: Enable regulator '%s'\n", __func__, priv->reg->name); - ret = regulator_set_enable(priv->reg, true); - if (ret) - return ret; + ret = regulator_set_enable_if_allowed(priv->reg, true); + if (ret && ret != -ENOSYS) { + debug("%s: failed to enable regulator '%s' %d\n", + __func__, priv->reg->name, ret); + return ret; } switch (dsi_data) { -- 2.39.2