Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5714C001B0 for ; Mon, 14 Aug 2023 14:07:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E5D1686768; Mon, 14 Aug 2023 16:07:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 60069867F7; Mon, 14 Aug 2023 16:07:00 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 8E29286679 for ; Mon, 14 Aug 2023 16:06:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 312AA1063; Mon, 14 Aug 2023 07:07:34 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D17933F64C; Mon, 14 Aug 2023 07:06:50 -0700 (PDT) Date: Mon, 14 Aug 2023 15:06:48 +0100 From: Andre Przywara To: Sam Edwards Cc: u-boot@lists.denx.de, Jagan Teki , Samuel Holland , Jernej Skrabec , Icenowy Zheng , Maksim Kiselev Subject: Re: [PATCH 0/3] Allwinner R528/T113s PSCI Message-ID: <20230814150648.1dddd00d@donnerap.manchester.arm.com> In-Reply-To: <20230812003055.74527-1-CFSworks@gmail.com> References: <20230812003055.74527-1-CFSworks@gmail.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Fri, 11 Aug 2023 18:30:52 -0600 Sam Edwards wrote: Hi Sam, many many thanks for sending this, I especially like your clean up around the #ifdef's! The patches looks good on the first glance (apart from some regression in patch 3/3), but I will reply to them individually. Cheers, Andre > Hi list, > > With Andre's R528 support (hopefully) landing soon, I figure now is time to > submit these patches for review. They refactor the ARMv7/sunxi PSCI > implementation to allow for the new NCAT2 CPU complex control registers, and > add support for the R528/T113s. > > Depends on series 365063. > > Thanks, > Sam > > Sam Edwards (3): > sunxi: psci: clean away preprocessor macros > sunxi: psci: refactor register access to separate functions > sunxi: psci: implement PSCI on R528 > > arch/arm/cpu/armv7/sunxi/psci.c | 185 +++++++++++++++++++++----------- > arch/arm/mach-sunxi/Kconfig | 2 + > include/configs/sunxi-common.h | 8 ++ > 3 files changed, 133 insertions(+), 62 deletions(-) >