Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8394DC41513 for ; Mon, 14 Aug 2023 16:38:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229568AbjHNQiQ (ORCPT ); Mon, 14 Aug 2023 12:38:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232918AbjHNQiE (ORCPT ); Mon, 14 Aug 2023 12:38:04 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 759A911D for ; Mon, 14 Aug 2023 09:38:03 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-d62858b0914so9629651276.1 for ; Mon, 14 Aug 2023 09:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692031082; x=1692635882; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=nFQ8vC5XQzgbvA+JsLCqADpM15IC2vMeMSJvkR1GdkU=; b=bLOdGV5zU5g2foKHhovwgNU8bbs6HNM9yzvZqm2zF2ZeIzc0ylmy7dhFi1X777X7kV Cg8bqf7tLDslXr1MWVYqDsJplRRbnXg1F6MLtu2PTPPdnQYFdRJwdXo0LMCmC0zU9Lsb E+0mm5dS8xHK5Zfzdl9zBFgO9TmivGhb+NaXjnrn0/hwgRZkfSQg9ViW6gPGEIWjumHT qD+ZINuoDLt1sCWCHVQ2D6RCLepOUc11T7/JPGhckrwBFfkXL4SFYqvM9/HvgndqN4vt HA5ADHSxUBroAkrsSobeU9I2+XYnYQWA8n7qWndqeQeTYy6hrnFkA6VxoGN03W6uSwDe 80Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692031082; x=1692635882; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nFQ8vC5XQzgbvA+JsLCqADpM15IC2vMeMSJvkR1GdkU=; b=d/ZMFThmcDt+XYUYvraWG35x8jdH6VpIxBedXFLb73zaiQ3FUTJsDhojHFO2tsVpQC 93HQJmARCJDZybuZ2Qy1QSECtuvFYrTolA4gOrXlIrBZmgdw/9xxK300ekGQ32oYmu4u NbKMF+Ch2oa8YZgnfltM7vysIZDXPiIkGmnDMS94Slhcko/oIjAeTGHARh1S6PyTMHGA A6rr6M7itt2f35k9aqflPX535Z6nvVMQMu08fYbsvGSDXNxu0fkTDjWKw/LVkPMtob4a ZgC4EY+QX7jT22XB8IZQ4eySQKzDSp7ZpGLkU8CgCCJViupI66EiciXkC4mukoEW8nte OpJw== X-Gm-Message-State: AOJu0Yz3Fm0ckfVnCTZ6JH6lESKPfXeEcvIL6EwNVBn4h3xz7CY2nn1q +hbVSrh5m3YLLCsQtHSPnglpntzrfyQX X-Google-Smtp-Source: AGHT+IGvxWe5XAH8eHCUck5OYb1/bre01R7f62ujA3WsqNi5U1902cjcsrT+MMekH4kJ+OvWVK4nJEhqw+OR X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:a919:6125:510f:f0ef]) (user=irogers job=sendgmr) by 2002:a25:23c9:0:b0:d47:3d35:1604 with SMTP id j192-20020a2523c9000000b00d473d351604mr179595ybj.2.1692031082702; Mon, 14 Aug 2023 09:38:02 -0700 (PDT) Date: Mon, 14 Aug 2023 09:37:54 -0700 Message-Id: <20230814163757.3077138-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.41.0.640.ga95def55d0-goog Subject: [PATCH v3 0/3] perf list: Remove duplicate PMUs From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Kan Liang , Ravi Bangoria , Kajol Jain , John Garry , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org When there are multiple PMUs, differing by ordered suffixes, by default only display one. This avoids repeated listing of events, in particular when there are 10s of uncore PMUs. If "-v" is passed to "perf list" then still list all PMUs. Listing fewer PMU/event combinations helps speed the all PMU event tests. Before: ``` $ perf list ... uncore_imc_free_running_0/data_read/ [Kernel PMU event] uncore_imc_free_running_0/data_total/ [Kernel PMU event] uncore_imc_free_running_0/data_write/ [Kernel PMU event] uncore_imc_free_running_1/data_read/ [Kernel PMU event] uncore_imc_free_running_1/data_total/ [Kernel PMU event] uncore_imc_free_running_1/data_write/ [Kernel PMU event] ``` After: ``` $ perf list ... uncore_imc_free_running/data_read/ [Kernel PMU event] uncore_imc_free_running/data_total/ [Kernel PMU event] uncore_imc_free_running/data_write/ [Kernel PMU event] ... $ perf list -v ... uncore_imc_free_running_0/data_read/ [Kernel PMU event] uncore_imc_free_running_0/data_total/ [Kernel PMU event] uncore_imc_free_running_0/data_write/ [Kernel PMU event] uncore_imc_free_running_1/data_read/ [Kernel PMU event] uncore_imc_free_running_1/data_total/ [Kernel PMU event] uncore_imc_free_running_1/data_write/ [Kernel PMU event] ... ``` The PMUs are sorted by name then suffix as a part of this change. v3: Add detail to patch 1 sorting commit message about the suffix and why sorting is necessary. v2: List all PMUs when "-v" is passed as suggested by John Garry . Ian Rogers (3): perf pmus: Sort pmus by name then suffix perf pmus: Add scan that ignores duplicates, use for perf list perf pmus: Don't print duplicate PMU suffix in list by default tools/perf/builtin-list.c | 8 +++ tools/perf/util/pmus.c | 120 +++++++++++++++++++++++++++++++-- tools/perf/util/print-events.h | 1 + 3 files changed, 122 insertions(+), 7 deletions(-) -- 2.41.0.640.ga95def55d0-goog