Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7C19C001E0 for ; Tue, 15 Aug 2023 19:09:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E5F3110E26F; Tue, 15 Aug 2023 19:09:14 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0BB7210E26F for ; Tue, 15 Aug 2023 19:09:14 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7681860F77; Tue, 15 Aug 2023 19:09:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DB3AC433C7; Tue, 15 Aug 2023 19:09:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692126552; bh=drMk97XVyKCReqvo0twNj8qWYEWg10p1ckwl8tzVNBA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B4yhcg4O90wKEMrx6eDICyuJ5FVGKESOwrgPDmJj7h5k8Dt9xumIm45W4HXOP+sKe FYo8uYUywe2h0MILLpYTJ5sY4N1Fnh5X85ru4Y7BqmBnDcPJ1rY2Dj6upC9+xcm9XN eRZsx67reSsMDkSu8sY4d/q5n4mylCql0Vn1t0ts5rLlobMDdQ/SlN5Zys5KCNMQyu NMx8HSJdPxQqvNTApHOngRa5KEjLcYUYT1AfvOB9j5Il7SxI2I1oL7eNYjMihrzzCd IW3k2zJoJEhZUzsAQo6+QlXFg6KCT/N47znNx3zabXs+TZiMxTuqfSbWz0DF7K9JGK JzxYRrZ9C+Drw== Date: Tue, 15 Aug 2023 12:09:10 -0700 From: Nathan Chancellor To: Artur Weber Subject: Re: [PATCH] backlight: lp855x: Drop ret variable in brightness change function Message-ID: <20230815190910.GA2908446@dev-arch.thelio-3990X> References: <20230809114216.4078-1-aweber.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230809114216.4078-1-aweber.kernel@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , kernel test robot , Jingoo Han , Helge Deller , Lee Jones , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Aug 09, 2023 at 01:42:16PM +0200, Artur Weber wrote: > Fixes the following warning: > > drivers/video/backlight/lp855x_bl.c:252:7: warning: variable 'ret' is used > uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] > > Signed-off-by: Artur Weber > Fixes: 5145531be5fb ("backlight: lp855x: Catch errors when changing brightness") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202308091728.NEJhgUPP-lkp@intel.com/ Reviewed-by: Nathan Chancellor > --- > drivers/video/backlight/lp855x_bl.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c > index 61a7f45bfad8..da1f124db69c 100644 > --- a/drivers/video/backlight/lp855x_bl.c > +++ b/drivers/video/backlight/lp855x_bl.c > @@ -241,19 +241,17 @@ static int lp855x_bl_update_status(struct backlight_device *bl) > { > struct lp855x *lp = bl_get_data(bl); > int brightness = bl->props.brightness; > - int ret; > > if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK)) > brightness = 0; > > if (lp->mode == PWM_BASED) > - ret = lp855x_pwm_ctrl(lp, brightness, > + return lp855x_pwm_ctrl(lp, brightness, > bl->props.max_brightness); > else if (lp->mode == REGISTER_BASED) > - ret = lp855x_write_byte(lp, lp->cfg->reg_brightness, > + return lp855x_write_byte(lp, lp->cfg->reg_brightness, > (u8)brightness); > - > - return ret; > + return -EINVAL; > } > > static const struct backlight_ops lp855x_bl_ops = { > > base-commit: 21ef7b1e17d039053edaeaf41142423810572741 > -- > 2.41.0 >