Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C4BBC71157 for ; Fri, 18 Aug 2023 14:34:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qX0Xg-00027q-Ct; Fri, 18 Aug 2023 10:33:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qX0Xd-00027d-IL for grub-devel@gnu.org; Fri, 18 Aug 2023 10:33:33 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.219]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qX0XZ-0004VX-Jx for grub-devel@gnu.org; Fri, 18 Aug 2023 10:33:32 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1692369206; cv=none; d=strato.com; s=strato-dkim-0002; b=KFTmrCmOHjKmb8A80yqqoefwwwjupR/mqXOCKtRv8xrBN0XM43J2D9bUp52Bwni21S d6bnO10kT2sedSkGQpAEofgeO3BVGDgg6tlPTxxc7TocAUPMLUjd43+qgD+IaCarllFA phoaZkoObeF6HRmqE1D+G0lH5GQAz8NLO1PBccg7w3TWH0f3AwQdUjWiSoosbWSB0I3o ekE2Bv5k7uWKx4EmgSg/u/Aw6gfLvbe3MGo6YoLzEdP0aeZ+DfrbQ6QjT/+MblT0GIZH 0xcaU8BKzhR9COg3TPtwW/d2QFlvdXsMmRcfW903y+e5yYALcaYXBplOtHHYMzc7D0e4 1gzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1692369206; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=e3xVRqjyk+GnIiUSe3+QgRW/GLgALqd3ARXZ0KUErzY=; b=fNRyOVf6+s40LFkH6jvahh52cwZwpoly1ABTvFCVzY6LG2zVQQxewC+6sVaJnWfK+6 djRsptYZ3SKAdWLzX3i9z2v7rF2p6ArRBnpTW4U0hpg3nc1JNPap/dIZhrREq7nmLGMk uvEqMJds6EWUBuzmZrFLhx7k68o/g9jTWeoHHMioLWYQc5pzWjNFa7Exkg5LrVd5JGyC H5SjSzaKArrKPzpRELiq7dBhoPMyvYKBpAtM9HsDbTj/5mhfQvHtiC7OSqwwLDHdE8fx 77xJNMP1O6EJDSfxdr5fQWvIdfCChRvLW30oiBV1l4XDwC9XslRr4qN4P8PSUcdL1rt/ Ik1w== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1692369206; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=e3xVRqjyk+GnIiUSe3+QgRW/GLgALqd3ARXZ0KUErzY=; b=Q8o64AIs5CwFXLn/sb9i77PdfZ+i9rj55HWRwAIJT8yHpaEP1NydXavrnxxiJwW3D0 W06ClOZ2YpVBymTmOX2AM5N0b6MebNqxCmmFZ+rGkYODJk1ROMWG34iV8OZskyuHVhz0 LGE9yibTAeKteTMP21RvQ+NRdWu7FeR7H94tmLm8ngD3SEN0dwQfaWjHJtgVRCACrgLn Tb5TquzSfomai40eOSu/r5+2rb+HsMgLdRBCofEMA+p+AVzyOqkDCqJNww7LuAQZ9gh0 O2HIcujw4juTwYWDW2BEEwxitvSjoJ+TqdHOm6ty6DloxVog69WjrBdojsAIcjEz1895 dfFQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1692369206; s=strato-dkim-0003; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=e3xVRqjyk+GnIiUSe3+QgRW/GLgALqd3ARXZ0KUErzY=; b=5Jd/YtsJajOPw85N8Bn8ZsoTo63CeAenMaSIls4NxLc1n+Xvkp0+NXpwZrBwYn3FKX oQ4tgdg5NBrdx3WhEwAQ== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisR4UUWIPk3s9GjW1rTEFhlMSmfDklnsWI0rggmn" Received: from sender by smtp.strato.de (RZmta 49.6.6 AUTH) with ESMTPSA id tf602fz7IEXQ8vG (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Fri, 18 Aug 2023 16:33:26 +0200 (CEST) Date: Fri, 18 Aug 2023 16:33:19 +0200 From: Olaf Hering To: Glenn Washburn Cc: The development of GNU GRUB Subject: Re: [PATCH v1] readd build dependency for startup_raw.S Message-ID: <20230818163319.2163e521.olaf@aepfle.de> In-Reply-To: <20230817151104.18331b6b@crass-HP-ZBook-15-G2> References: <20230816095501.18368-1-olaf@aepfle.de> <20230816143343.324debe3@crass-HP-ZBook-15-G2> <20230817110044.238d7c1a.olaf@aepfle.de> <20230817151104.18331b6b@crass-HP-ZBook-15-G2> X-Mailer: Claws Mail 20230724T063118.58ae3d58 hat ein Softwareproblem, kann man nichts machen. MIME-Version: 1.0 Received-SPF: none client-ip=81.169.146.219; envelope-from=olaf@aepfle.de; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: The development of GNU GRUB Content-Type: multipart/mixed; boundary="===============1347211623021488634==" Errors-To: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org Sender: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org --===============1347211623021488634== Content-Type: multipart/signed; boundary="Sig_/F0NU30oijn/W5KszeE21Zdq"; protocol="application/pgp-signature"; micalg=pgp-sha256 Content-Transfer-Encoding: 7bit --Sig_/F0NU30oijn/W5KszeE21Zdq Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Thu, 17 Aug 2023 15:21:44 -0500 Glenn Washburn : > On Thu, 17 Aug 2023 11:00:44 +0200 > Olaf Hering wrote: > > It is the result of my attempt to build just the required binaries, wit= hout docs. > > I came up with this: > > git clean -dffx > > bash bootstrap > > mkdir .b > > cd .b > > ../configure [options] > > make check > > make -C grub-core install-platformDATA install-platformPROGRAMS =20 > And this avoids the compile error for startup_raw.S? No, the other way around: this triggers it. Previously I had a simple 'make= ', followed by the install targets shown above. This builds all dependencies, and also the doc target. To get rid of the doc target, I was under the assumption that install-something already has proper dependencies, but only a subset is built. gnulib.a was missing, and likely others. I did not dig d= eep. =20 > > But thinking further about it, and as others have noted, the real fix w= ould > > be to wade through all targets and express their dependencies properly.= =20 >=20 > What version of automake are you using? I'm on 1.16.3-2 from Debian 11. > rs_decoder.h is ending up in BUILT_SOURCES, so it should get built > before anything is compiled. Can you check ,? For me > rs_decoder.h is included via a few levels of variable expansion, so it > won't be literally in the definition of BUILT_SOURCES. I'm wondering if > maybe you're using an older version of automake with a bug. I have seen it with automake 1.15.1 and 1.16.5.=20 "nodist_lzma_decompress_image_SOURCES" should be part of "BUILT_SOURCES", via "am__append_6232". But another local build, without this change, does indeed fail. The 'check' target does have "BUILT_SOURCES" as dependency, not sure why it does not build the target. With some debug, the content during 'make check' is just: BUILT_SOURCES grub_fstest_init.c grub_script.tab.c grub_script.tab.h grub_s= cript.yy.c grub_script.yy.h libgrub_a_init.c And the real reason is an incorrect invocation of make: 'make check' works in the toplevel, while 'make -C grub-core install-someth= ing' works in the given directory. So for me the fix (to avoid the docs target) = is: make check make -C grub-core check make -C grub-core install-platformDATA install-platformPROGRAMS Sorry for the noise. Olaf --Sig_/F0NU30oijn/W5KszeE21Zdq Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmTfgS8ACgkQ86SN7mm1 DoCHsw//WW+QROFyZ7YBhcniFpKqFKOEH/AjdbWEfrY9UZl7sxmRAhguBMZJi84r 3tCJBQQ1V2ddtPKxuJfQkIXxcqPYJlVfOfoUuVm7i0n64BszgFZlUBvDoFy1t8rA ok23m0brleaW6RPbeS4GJpoWnJy5zAQFPapJUxfv6W2LHVBks4OOThkkfNkiECWm zjVVWuY2Jn45LqQrm6T1A/lzo6TjvwkUUV/vaOjUv9LNzb0Ngw8UhkbH8WRWSsqB w36nGoBAXOJxgACEj+ecA9QbnfzC1qJMvxK1zamQcX2ELoMWCZYnZO0KZgC4kAWx 95MjlUgjFiV8h/1ANVYvkZpjCDWq6hjbvlMbhGVdnTZnZER69KiVAogMD7hFQt2N oVyoHUoA2lpsxOkDj+XgcryyhT109IUkx7a5DYl28b1OJVjHAlEi5dAMmMOmIAjC Gex/oO95R/1cihnPg6zgO/do2fmmho1OqBZjZbD7sIAiUOLf7dqvBL8CjCkimyAf 0Bh1FXAh2gPpG7taPIGjIf+zAxKBRmjyI3tMo7MD+LTUxb94XGjJ3ju1zELCVtnA I9H1YO73d0dkJMtFEnwWYHei4VRwdNHFdjmEsTBAM1D19yH9sbG1/jByZGVwUtqd 3nv2ie9Mx/Hb4PnDPWWk/pc36V9ss1CW9eQ11fogWZlXAOF24PY= =/FyL -----END PGP SIGNATURE----- --Sig_/F0NU30oijn/W5KszeE21Zdq-- --===============1347211623021488634== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KR3J1Yi1kZXZl bCBtYWlsaW5nIGxpc3QKR3J1Yi1kZXZlbEBnbnUub3JnCmh0dHBzOi8vbGlzdHMuZ251Lm9yZy9t YWlsbWFuL2xpc3RpbmZvL2dydWItZGV2ZWwK --===============1347211623021488634==--