Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87969EE498B for ; Fri, 18 Aug 2023 18:35:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCDD5280008; Fri, 18 Aug 2023 14:35:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7E07940012; Fri, 18 Aug 2023 14:35:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1FCA280008; Fri, 18 Aug 2023 14:35:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9F572940012 for ; Fri, 18 Aug 2023 14:35:43 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7398B1A10DA for ; Fri, 18 Aug 2023 18:35:43 +0000 (UTC) X-FDA: 81138078966.13.89EB202 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf20.hostedemail.com (Postfix) with ESMTP id 53BB81C0021 for ; Fri, 18 Aug 2023 18:35:41 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=DtsMQQNk; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf20.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.170 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692383741; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Oz06k/Wemi6J/ldyB6c9tZm1247DSyEcuvZiFNgbP/o=; b=oNp/SJ2NPpA3xkUZ7beTjN9vfMYfgl47LDcltG+FldU9kpQ4odOUh2REPOyIntdzaGB5zh hj9TaO90surPdUCYMkZX+vsEMpWzH5KgExk5UpJdeU3rfrMUMhuUWO1fneNWWvZBeNp4XO 3w9yGyPPumBEW12IkY4HbQJ4W+WXt6A= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=DtsMQQNk; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf20.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.170 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692383741; a=rsa-sha256; cv=none; b=k9F7rU3BEE6ys3DwrjfdDACPXBUjkJ/I8/DSgECZYm8aAD2p0NroKTAxGePi1eoX9o7PP5 W5QdJd26MZzbu42SOX7Mt/OzI8IbM+p1bez691f7jGm1NCv7L04oSnvz5/Qa4TsjFFkXMp fxwBcCQtPOC6P6oGZTdSWDG7AThQUds= Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-76d1dc1ebfdso108346785a.0 for ; Fri, 18 Aug 2023 11:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1692383740; x=1692988540; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Oz06k/Wemi6J/ldyB6c9tZm1247DSyEcuvZiFNgbP/o=; b=DtsMQQNk4Bw3nnmKshQ+7c4Rh2kpkW0GfXbaMoNvPPCBSotCAKqyKPqUpE7cnqxQDg 3NVgdQWv50gPB+xZd95+0eKBdY/vozuftwC8s7uE4FW8nb5nIjP2X9OQ749EhQ4ZI9FN NIJnAzSOhJDd5OAuAAu6GF85ydfquuGL4aReaWtesi88GnMSRQxlDOBlhfSCpVTL3/jl xsMqtR+H10NCVwftvFu8Xtm0Rd/Y7TOZ9ozwxiiqbPuqEKx4TcTwjwQFDmpTbykwjI+8 H7qYx8Rob30SfV3A+Xm4ONoW3BneudCzjgkK9VYwDGry+J30qPVuPQ/bNAmmAGSswHLE rUMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692383740; x=1692988540; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Oz06k/Wemi6J/ldyB6c9tZm1247DSyEcuvZiFNgbP/o=; b=TKJL7qfMyy/qwnlXwFaKsy9N0mrA9V1iNv7KxyZB7tNjYyDbFND9WqRT1UNo6B+bvP m3OQfsiALuceOdB/QsYrHB+SLOz1j0vLDyYuoEDLMdiMvpPAYe2hA+A74lQer4eZkshT l2rLfvHu7G4ZkTcRuEIMqTPCpzj6evPDBeu1SfFwPUPAok/7ds8ewGI7I8JrXbdeytYi Ngk1xv33AfZNhGXpAL/rVN4t21WOTmuhEuxgZPwpG5dvd4yxvJHqHIpL2zLpWZ2afpi+ +llmK66blPuo+BT5bknFoCdnPaRbmYOeNjCoXoL/Ojmihm0PopJjdF7mLQuHKwaMIXMT TYpw== X-Gm-Message-State: AOJu0YzrZRybhXMGlIM9sRZkd6CuFzuneyoh9LDRpqYbaaXrFwsltcgy slYwgW5b1Lg8ZjIYnF+aZTa6GQ== X-Google-Smtp-Source: AGHT+IF7YzSibPnzgxPoJYofHLjKfxo+upoXyv0TzXTpF3VWJPmLvlah9US/Du/r9oTY1p/0jpOSwQ== X-Received: by 2002:a0c:cb0b:0:b0:64b:51d4:6696 with SMTP id o11-20020a0ccb0b000000b0064b51d46696mr28432qvk.5.1692383740251; Fri, 18 Aug 2023 11:35:40 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:75e0]) by smtp.gmail.com with ESMTPSA id o6-20020a0ccb06000000b0063d252a141dsm853148qvk.116.2023.08.18.11.35.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Aug 2023 11:35:39 -0700 (PDT) Date: Fri, 18 Aug 2023 14:35:38 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Yu Zhao , Nhat Pham , akpm@linux-foundation.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH v2] workingset: ensure memcg is valid for recency check Message-ID: <20230818183538.GA142974@cmpxchg.org> References: <20230817164733.2475092-1-nphamcs@gmail.com> <20230817190126.3155299-1-nphamcs@gmail.com> <20230818134906.GA138967@cmpxchg.org> <20230818173544.GA142196@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 53BB81C0021 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 1yguiyng18o1qjd4sn3ahoxw8wsfpikm X-HE-Tag: 1692383741-551224 X-HE-Meta: U2FsdGVkX18oR8yRSp+ZiWU+FrluSECVI2uxAy3dY10EHJCs7NdO2S/BCYfweBD748pYV9ks11q6129Mnshe1v3Qqr84Oj2+oBav9Mc88jYCkfK6j/X4srtC3mGvaIymB6CtyriLLSlkg+dI755Kegvvkj5pqH2Jbn2PzQ/xoJVZX6jF0UUPBBg7iCK1P9RPXpgW7nKhTLE1cFih23oon2qv74gu0Zfh88ILXVS6tfB/t4swx/dy5y5l2Rm3f9PZ2mcPK+wtnMdUM8s3kacaAr7rGMbujpWKUptd2KT1Lz8yhGSm9uRBeN52+Nn+TajlUo/4fZoOb/RBqibMYrWs+3HRJ5QyVHoRTqafLzF2YqZoj9v8B6WOJei4CSomqHjuzFac5fZ09M7iF0eL/Gvvs5tCToY5S1hXXIRf+k/iarWdiFHPQGHl0YbdydSUjJoNIsPtoabKvONMkGjlZwehMbWwI9sBy8lVOkYSwdG9K6hvp5MHjiFYSdrpxaG5COEjkD6bL+VqHxi1EFY2u0pCJwP9PKvh2prFNIPqd9vNGUKwxhZemri3hEnxRZdkj/TjFwHjM7ckJeXjMfYuQPwxlcbpBB/ZKqZxIbAw9D5nIcWaB061Fm+Go4CIOT5oiaD1Do0QPKMm/JZfuK3hNEHlYMVae1t3ln4u7+Lvm7kcpBuxyXJLrH1uG4v0ItLpiPpv4IDQ12kqTNTwRcEJFdt9p8+1vuiebgskNtRWbf20tGPLyGLgbruohSH7Znxbs4BGJlFrd43UhOVqyj1SokYFuH21DTtc9X7+mRQoIA0tyNs5FwplbyIkAKl/RcEjjGYkdRrgtmFqB1cChnLJ8wGBouMP7EmdFGiss4DoRg1eP2nIKQEwsHJDVkKL15GpshVzhDTZpagBB8S6f+mjqpYj1cxcGaEglPp5M68gQOB3H9DbVXIlQodwI6fbUa3xjHJrU6QpSao5shpoCV85swn Wmr2QKbL eUeTWdQ7qTUohoT8xz/ljImRnB4waxiueIQdEp0X5t6dpSEvKLBxvcblBtxO7w13AAkoPaKeZyuuqSYRTmjYBVfeq7/13LFZA0zM/RiEVpAC7vdmcfpJU/opjlg/k2Na69hhSGAxv37UuB9EUiwl9UjbXtiTmknnH4ubM4y2mP3LQmGMpCuSEbacrVIaHcSFOtO1oRuqXS7IkROpd2nEawA1xnc5/PtDKN9Ai1dQnsYouXnF+90PqYAEP6eH/gSZZaPtuCxEmAeUfTcWfdiudvzQB7r5hjeC++aNgO/qhNcyfEla+EHuaroHgzwR4UtsDF/fCzO6Ub/vwKuk/06hDuy3lDjKCWwGDseYNEGdk3p/+9vXPpEPgTbhXAorvSoze32xc8EJWqKw6fqw2pCyN12t1zVu4t2L7+QhP2KP3FRqEnBz9JnYvccsQin1w+fkkAK5JlCcucEEJwy22wyUAtPS5IrWyo8o/WOIb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 18, 2023 at 10:45:56AM -0700, Yosry Ahmed wrote: > On Fri, Aug 18, 2023 at 10:35 AM Johannes Weiner wrote: > > On Fri, Aug 18, 2023 at 07:56:37AM -0700, Yosry Ahmed wrote: > > > If this happens it seems possible for this to happen: > > > > > > cpu #1 cpu#2 > > > css_put() > > > /* css_free_rwork_fn is queued */ > > > rcu_read_lock() > > > mem_cgroup_from_id() > > > mem_cgroup_id_remove() > > > /* access memcg */ > > > > I don't quite see how that'd possible. IDR uses rcu_assign_pointer() > > during deletion, which inserts the necessary barriering. My > > understanding is that this should always be safe: > > > > rcu_read_lock() (writer serialization, in this case ref count == 0) > > foo = idr_find(x) idr_remove(x) > > if (foo) kfree_rcu(foo) > > LOAD(foo->bar) > > rcu_read_unlock() > > How does a barrier inside IDR removal protect against the memcg being > freed here though? > > If css_put() is executed out-of-order before mem_cgroup_id_remove(), > the memcg can be freed even before mem_cgroup_id_remove() is called, > right? css_put() can start earlier, but it's not allowed to reorder the rcu callback that frees past the rcu_assign_pointer() in idr_remove(). This is what RCU and its access primitives guarantees. It ensures that after "unpublishing" the pointer, all concurrent RCU-protected accesses to the object have finished, and the memory can be freed.