Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8B54C83F01 for ; Wed, 30 Aug 2023 14:59:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CED9F863DD; Wed, 30 Aug 2023 16:59:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="DUPcfV1+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CD0CA863DD; Wed, 30 Aug 2023 16:59:45 +0200 (CEST) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C76488646A for ; Wed, 30 Aug 2023 16:59:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=nm@ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 37UExbob061807; Wed, 30 Aug 2023 09:59:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1693407577; bh=Q1tV2N0UysQGKO0OfWgSTO/mE9qDLawr06nIus+nOuA=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=DUPcfV1+u4w7LKUrmhVbAkA0HN4X7V8hPmoDwbEM2y+BPKFARvYFR1zwhipUC7FAB WlHZJCif4qEE9/q+/UmhYv49/NMmvcY7Pa1+qSoHR4HQvRofwgNRSiLGnmT4SmBTAc Ai7yImIkPaXOCtB5RACMgp3DnD5ZSyY1l+qgFvX0= Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 37UExbLf074600 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 30 Aug 2023 09:59:37 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 30 Aug 2023 09:59:37 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 30 Aug 2023 09:59:36 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 37UExaII050162; Wed, 30 Aug 2023 09:59:36 -0500 Date: Wed, 30 Aug 2023 09:59:36 -0500 From: Nishanth Menon To: Andrew Davis CC: Neha Malcom Francis , Simon Glass , Tom Rini , Bryan Brattlof , Praneeth Bajjuri , Robert Nelson , Vignesh Raghavendra , Mattijs Korpershoek , Jan Kiszka , Heinrich Schuchardt , Subject: Re: [RFC PATCH 2/2] configs: Add am62x_beagleplay_* defconfigs Message-ID: <20230830145936.iwl3ew4274adpr4z@litigate> References: <20230829221457.101469-1-afd@ti.com> <20230829221457.101469-3-afd@ti.com> <20230830123151.rp7wkhi5m4leg6ny@ravishing> <0cbbf080-491f-a0fc-300c-d32cbd06ba70@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <0cbbf080-491f-a0fc-300c-d32cbd06ba70@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 09:31-20230830, Andrew Davis wrote: > On 8/30/23 7:31 AM, Nishanth Menon wrote: > > On 17:14-20230829, Andrew Davis wrote: > > > Add am62x_beagleplay_r5_defconfig for R5 SPL and > > > am62x_beagleplay_a53_defconfig for A53 SPL and U-Boot support. > > > > > > These defconfigs are composite defconfigs built from the config fragment > > > board/ti/am62x/beagleplay_*.config applied onto the base > > > am62x_evm_*_defconfig. > > > > > > Signed-off-by: Andrew Davis > > > --- > > > configs/am62x_beagleplay_a53_defconfig | 3 +++ > > > configs/am62x_beagleplay_r5_defconfig | 3 +++ > > > 2 files changed, 6 insertions(+) > > > create mode 100644 configs/am62x_beagleplay_a53_defconfig > > > create mode 100644 configs/am62x_beagleplay_r5_defconfig > > > > > > diff --git a/configs/am62x_beagleplay_a53_defconfig b/configs/am62x_beagleplay_a53_defconfig > > > new file mode 100644 > > > index 00000000000..ad708e15397 > > > --- /dev/null > > > +++ b/configs/am62x_beagleplay_a53_defconfig > > > @@ -0,0 +1,3 @@ > > > +// The BeaglePlay defconfig for A53 core > > > +#include "configs/am62x_evm_a53_defconfig" > > > +#include "board/ti/am62x/beagleplay_a53.config" > > > diff --git a/configs/am62x_beagleplay_r5_defconfig b/configs/am62x_beagleplay_r5_defconfig > > > new file mode 100644 > > > index 00000000000..276b1f81a3e > > > --- /dev/null > > > +++ b/configs/am62x_beagleplay_r5_defconfig > > > @@ -0,0 +1,3 @@ > > > +// The BeaglePlay defconfig for R5 core > > > +#include "configs/am62x_evm_r5_defconfig" > > > +#include "board/ti/am62x/beagleplay_r5.config" > > > -- > > > 2.39.2 > > > > > > > my only complaint is that if we add lets say > > board/ti/am62x/dfu.config, Then: > > > > R5: > > 1. am62x_evm_r5_defconfig = am62x_evm_r5_defconfig > > 2. am62x_beagleplay_r5_defconfig = am62x_evm_r5_defconfig + beagleplay_r5.config > > 3. am62x_evm_r5_dfu_defconfig = am62x_evm_r5_defconfig + dfu.config > > 4. am62x_beagleplay_r5_dfu_defconfig = am62x_evm_r5_defconfig + beagleplay_r5.config + dfu.config > > > > This information can be in a single txt file Rather than have a > > defconfig file for each combination. > > > > Having every combination in a text file vs in a directory of files doesn't > seem like much difference to me. `cat combinations.txt` vs `ls -l configs/`. > But using a file would mean extra tooling and non-standard usage. The .config usage is a standard already in kernel - nothing new there. What we are attempting to solve is CI build coverage and test aspect of things. Thinking aloud here: some sort of board///ci.conf yaml could probably be a better approach with description of build, automated test information, potentially board revisions etc. > Let's simply try to avoid these combinatorial problems by avoiding adding > too many fragments that apply broadly. That adds testing burden. When features The combinations will be valid since the intent is a supported configuration. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D