Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 967B1C83F3E for ; Tue, 5 Sep 2023 12:54:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7BFF8D0002; Tue, 5 Sep 2023 08:54:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2B9F8D0001; Tue, 5 Sep 2023 08:54:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1A748D0002; Tue, 5 Sep 2023 08:54:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BE6178D0001 for ; Tue, 5 Sep 2023 08:54:18 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 80D40140856 for ; Tue, 5 Sep 2023 12:54:18 +0000 (UTC) X-FDA: 81202536996.05.0826CD0 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf19.hostedemail.com (Postfix) with ESMTP id 29DFB1A0016 for ; Tue, 5 Sep 2023 12:54:15 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of yuancan@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=yuancan@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693918456; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references; bh=SKaoLrcGNQZaKvvPDqdTs5HzKWxbNgIGlEgSWoab3ck=; b=SDghv92jCLXhSQSQPtS4uWo3yn1PB9ntyVdWBLB/d+lfFq1FoUJjJudo+4enTZ+NOQhhip eGJst9nLq1Yn88hv8svTyKZv9OIClIMken2jVWRXfpuKRS0txDYK8x14PxwP/7v1LJ8j6C W/X4kCHOZHg/gOgtOKBS+cDi+AxJZzg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693918456; a=rsa-sha256; cv=none; b=XTuoxzSyIXRU6hthGUwu80nR4B6uUan9HxeKUypBKP+K9kHHDzBtmtz8VSSWu5WpaBVcf+ UJyfgJdLb7j8awNgEbQcT5rGrlqZECyh50649GKoVaebZbOEBCsMt+kE7+85SjkiPyMCOv UkXXbc6bwtxsNNMkiJeDqQ+zpzqsQLU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of yuancan@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=yuancan@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Rg53r1w8YzVjvL; Tue, 5 Sep 2023 20:51:36 +0800 (CST) Received: from huawei.com (10.175.112.208) by dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 5 Sep 2023 20:54:11 +0800 From: Yuan Can To: , , , CC: , Subject: [PATCH v2] mm: hugetlb_vmemmap: fix hugetlb page number decrease failed on movable nodes Date: Tue, 5 Sep 2023 20:45:03 +0800 Message-ID: <20230905124503.24899-1-yuancan@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.208] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml100024.china.huawei.com (7.185.36.115) X-CFilter-Loop: Reflected X-Stat-Signature: 999dennad1mb4uj86uyxut1isia55ob1 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 29DFB1A0016 X-Rspam-User: X-HE-Tag: 1693918455-776097 X-HE-Meta: U2FsdGVkX19uprLHYJLzJiRRtdFkSilT+e/7QtTuNUIFMYGHznIYRWWOtlcjYKNfY4b0ALLbk9juHidSH1m48duts5Rpnn4jhWDoDTd7hdsLXR/D9Q0yMObjuLU9B9C4LG7Y5kUm6j3FcIExbzeN88Y2WBozwZ/qTxRj7oVcXVPCTc0ofg7IUROwF6nBU++iBiAnyo8x6tHU0ET+j0LfXgRySYW50rYNSLGc2//F28cOWbZ0MiRHIzuj/gWVnUdniIzGTfGV9jtfIQ0F6+PAMbyDVdUWCEhcWLpK51J6kQyer3vRudAsgKU3TrbRxtnyKdROnqOi/nXRYA0xoMlnhC3UO5DlFrw/jb1rexlXk0AalSidX2ATjtm3fRGIlOBm1//vKSvgMu5l7J19hT5LodeXuTBY56Vj+pNt+fdaPuByB4abHyuVr8vyqGvefxzUnpD3XQYimGtie/KKwoW0O0F7FnXqxQcldpXa0XpOaR36KaQMAxvWr8EV1/02odfCOMRH/FApbDIdGXWMTKji05exuQ7zyrPEIqvSxUnq/LVCxP9bkXvLAUvAYbDSxweXTZbnWcoKI0LPMkeNJOPxCRPHkCOgutmYpGNcCbNO5Clvc2+NRhEHzEiiZGgl+OK+4ihPhUXhv+GqbIKkHGLNAlevrmHk3ae/5jyKCeCwzPmkh5TZqfgCQ1hfieIDtnL+f0W1SuUvR6P745unsCGNi/guFAaKpZ14RlOReRcJqVJQwrOJTKIBzZnh5O6EKe+0utjoLy3JA3yIqono1rwvOx6Cbu8Klx+nrWQpss9m1pTQwP+5zyZTDPtX018fC7cJc5rcPJbcQ74RuuSqtk/VPZmWcuxRTfBh9tzGmXEh+ao1OwzwkqTYSk1DI5Yez+NQ4uQMoA/XTy8mQPKEArzJKBQieZ/HXgQWbs1raAfiQwrQJ345UaFxZc3ZhzPSrjA4E6g58IcbfLL/tdbE4nX 9Hr/WUIf C3a6niqsY5g5OJK1p3w1jtz+hRNO9dwhY+c8g3uQtcJTJpyx4/PYlG2iMJAj1PEDalRugTX5GnCziWmmXseavmYQVXaOwH6b598tMmSUQyJQf82exq91GOpbf3BI5lp1jpXvFp1/PxVux0eOCC2KJ55lns8lSkx1fmIWxVbRX6H0LbuOzo4XUXewsgvj/TmwcivFSAE9MJMXhgAPmFaaCaKOpqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The decreasing of hugetlb pages number failed with the following message given: sh: page allocation failure: order:0, mode:0x204cc0(GFP_KERNEL|__GFP_RETRY_MAYFAIL|__GFP_THISNODE) CPU: 1 PID: 112 Comm: sh Not tainted 6.5.0-rc7-... #45 Hardware name: linux,dummy-virt (DT) Call trace: dump_backtrace.part.6+0x84/0xe4 show_stack+0x18/0x24 dump_stack_lvl+0x48/0x60 dump_stack+0x18/0x24 warn_alloc+0x100/0x1bc __alloc_pages_slowpath.constprop.107+0xa40/0xad8 __alloc_pages+0x244/0x2d0 hugetlb_vmemmap_restore+0x104/0x1e4 __update_and_free_hugetlb_folio+0x44/0x1f4 update_and_free_hugetlb_folio+0x20/0x68 update_and_free_pages_bulk+0x4c/0xac set_max_huge_pages+0x198/0x334 nr_hugepages_store_common+0x118/0x178 nr_hugepages_store+0x18/0x24 kobj_attr_store+0x18/0x2c sysfs_kf_write+0x40/0x54 kernfs_fop_write_iter+0x164/0x1dc vfs_write+0x3a8/0x460 ksys_write+0x6c/0x100 __arm64_sys_write+0x1c/0x28 invoke_syscall+0x44/0x100 el0_svc_common.constprop.1+0x6c/0xe4 do_el0_svc+0x38/0x94 el0_svc+0x28/0x74 el0t_64_sync_handler+0xa0/0xc4 el0t_64_sync+0x174/0x178 Mem-Info: ... The reason is that the hugetlb pages being released are allocated from movable nodes, and with hugetlb_optimize_vmemmap enabled, vmemmap pages need to be allocated from the same node during the hugetlb pages releasing. With GFP_KERNEL and __GFP_THISNODE set, allocating from movable node is always failed. Fix this problem by removing __GFP_THISNODE. Fixes: ad2fa3717b74 ("mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page") Signed-off-by: Yuan Can Reviewed-by: Muchun Song --- Changes in v2: - Add Fixes tag in commit msg - Add Muchun Song's reviewed by mm/hugetlb_vmemmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c index c2007ef5e9b0..0485e471d224 100644 --- a/mm/hugetlb_vmemmap.c +++ b/mm/hugetlb_vmemmap.c @@ -386,7 +386,7 @@ static int vmemmap_remap_free(unsigned long start, unsigned long end, static int alloc_vmemmap_page_list(unsigned long start, unsigned long end, struct list_head *list) { - gfp_t gfp_mask = GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_THISNODE; + gfp_t gfp_mask = GFP_KERNEL | __GFP_RETRY_MAYFAIL; unsigned long nr_pages = (end - start) >> PAGE_SHIFT; int nid = page_to_nid((struct page *)start); struct page *page, *next; -- 2.17.1