Date: Wed, 13 Sep 2023 05:28:04 +0800
From: kernel test robot <lkp@intel.com>
To: Kairui Song <ryncsn@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC PATCH v2 3/5] workingset: simplify lru_gen_test_recent
Message-ID: <202309130510.9aYS6aMZ-lkp@intel.com>
References: <20230912184511.49333-4-ryncsn@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230912184511.49333-4-ryncsn@gmail.com>

Hi Kairui,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.6-rc1]
[cannot apply to akpm-mm/mm-everything next-20230912]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kairui-Song/workingset-simplify-and-use-a-more-intuitive-model/20230913-024648
base:   linus/master
patch link:    https://lore.kernel.org/r/20230912184511.49333-4-ryncsn%40gmail.com
patch subject: [RFC PATCH v2 3/5] workingset: simplify lru_gen_test_recent
config: i386-tinyconfig (https://download.01.org/0day-ci/archive/20230913/202309130510.9aYS6aMZ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230913/202309130510.9aYS6aMZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309130510.9aYS6aMZ-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   mm/workingset.c: In function 'lru_refault':
   mm/workingset.c:243:43: warning: unused variable 'inactive' [-Wunused-variable]
     243 |         unsigned long workingset, active, inactive, inactive_file, inactive_anon = 0;
         |                                           ^~~~~~~~
   mm/workingset.c:243:23: warning: unused variable 'workingset' [-Wunused-variable]
     243 |         unsigned long workingset, active, inactive, inactive_file, inactive_anon = 0;
         |                       ^~~~~~~~~~
   mm/workingset.c: In function 'workingset_test_recent':
>> mm/workingset.c:503:67: warning: passing argument 3 of 'lru_gen_test_recent' makes pointer from integer without a cast [-Wint-conversion]
     503 |                 return lru_gen_test_recent(eviction_lruvec, file, eviction);
         |                                                                   ^~~~~~~~
         |                                                                   |
         |                                                                   long unsigned int
   mm/workingset.c:415:74: note: expected 'struct lruvec **' but argument is of type 'long unsigned int'
     415 | static bool lru_gen_test_recent(void *shadow, bool file, struct lruvec **lruvec,
         |                                                          ~~~~~~~~~~~~~~~~^~~~~~
>> mm/workingset.c:503:24: error: too few arguments to function 'lru_gen_test_recent'
     503 |                 return lru_gen_test_recent(eviction_lruvec, file, eviction);
         |                        ^~~~~~~~~~~~~~~~~~~
   mm/workingset.c:415:13: note: declared here
     415 | static bool lru_gen_test_recent(void *shadow, bool file, struct lruvec **lruvec,
         |             ^~~~~~~~~~~~~~~~~~~


vim +/lru_gen_test_recent +503 mm/workingset.c

   459	
   460	/**
   461	 * workingset_test_recent - tests if the shadow entry is for a folio that was
   462	 * recently evicted. Also fills in @workingset with the value unpacked from
   463	 * shadow.
   464	 * @shadow: the shadow entry to be tested.
   465	 * @file: whether the corresponding folio is from the file lru.
   466	 * @workingset: where the workingset value unpacked from shadow should
   467	 * be stored.
   468	 *
   469	 * Return: true if the shadow is for a recently evicted folio; false otherwise.
   470	 */
   471	bool workingset_test_recent(void *shadow, bool file, bool *workingset)
   472	{
   473		struct mem_cgroup *eviction_memcg;
   474		struct lruvec *eviction_lruvec;
   475		int memcgid;
   476		struct pglist_data *pgdat;
   477		unsigned long eviction;
   478	
   479		unpack_shadow(shadow, &memcgid, &pgdat, &eviction, workingset);
   480	
   481		/*
   482		 * Look up the memcg associated with the stored ID. It might
   483		 * have been deleted since the folio's eviction.
   484		 *
   485		 * Note that in rare events the ID could have been recycled
   486		 * for a new cgroup that refaults a shared folio. This is
   487		 * impossible to tell from the available data. However, this
   488		 * should be a rare and limited disturbance, and activations
   489		 * are always speculative anyway. Ultimately, it's the aging
   490		 * algorithm's job to shake out the minimum access frequency
   491		 * for the active cache.
   492		 *
   493		 * XXX: On !CONFIG_MEMCG, this will always return NULL; it
   494		 * would be better if the root_mem_cgroup existed in all
   495		 * configurations instead.
   496		 */
   497		eviction_memcg = mem_cgroup_from_id(memcgid);
   498		if (!mem_cgroup_disabled() && !eviction_memcg)
   499			return false;
   500		eviction_lruvec = mem_cgroup_lruvec(eviction_memcg, pgdat);
   501	
   502		if (lru_gen_enabled())
 > 503			return lru_gen_test_recent(eviction_lruvec, file, eviction);
   504	
   505		return lru_refault(eviction_memcg, eviction_lruvec, eviction, file,
   506				   EVICTION_BITS, bucket_order);
   507	}
   508	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki