Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8230B17C3 for ; Thu, 14 Sep 2023 01:55:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4E86C43395; Thu, 14 Sep 2023 01:55:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694656533; bh=gXVhJOHHu42wAbkHvrobBuAxMZhcTwxM0j4OPJEY6D0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rc2EudUBL+agLnM+IlYu1giwshvIgqCIDJGGugWsBvw93G+oIRPtaSjhSETFEVvj6 cr1YfvsxjZZWHJQ5CeiLyKU6OdEkKcJi1FVApLpVHKrJQ2iuNbS5V1JFx12QMw/79F UtD6+VYCfEOxdgKtRbAY6nbOD8K3sHnJH9DjabeZ3TXMct55eGVWKyoC3AOW964AK1 IB8gBUFWJ7QGKcJuOc5/MCxaydMoG+/4/LLqAnvsZNS6LwGO3EcfD+vT0tMbjcpRbz ILkPQmQiXS3evewpY5COUP+xgRLqVN/Vih4Y0vgy89TpbJgjQ4pmjsqGQuuqCQQUeQ /WUh/Y0VR/z6g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tobias Schramm , Mark Brown , Sasha Levin , wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH AUTOSEL 6.1 5/6] spi: sun6i: reduce DMA RX transfer width to single byte Date: Wed, 13 Sep 2023 21:55:15 -0400 Message-Id: <20230914015523.51894-5-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230914015523.51894-1-sashal@kernel.org> References: <20230914015523.51894-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.53 Content-Transfer-Encoding: 8bit From: Tobias Schramm [ Upstream commit 171f8a49f212e87a8b04087568e1b3d132e36a18 ] Through empirical testing it has been determined that sometimes RX SPI transfers with DMA enabled return corrupted data. This is down to single or even multiple bytes lost during DMA transfer from SPI peripheral to memory. It seems the RX FIFO within the SPI peripheral can become confused when performing bus read accesses wider than a single byte to it during an active SPI transfer. This patch reduces the width of individual DMA read accesses to the RX FIFO to a single byte to mitigate that issue. Signed-off-by: Tobias Schramm Link: https://lore.kernel.org/r/20230827152558.5368-2-t.schramm@manjaro.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-sun6i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c index 23ad052528dbe..2bfe87873edb3 100644 --- a/drivers/spi/spi-sun6i.c +++ b/drivers/spi/spi-sun6i.c @@ -200,7 +200,7 @@ static int sun6i_spi_prepare_dma(struct sun6i_spi *sspi, struct dma_slave_config rxconf = { .direction = DMA_DEV_TO_MEM, .src_addr = sspi->dma_addr_rx, - .src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES, + .src_addr_width = DMA_SLAVE_BUSWIDTH_1_BYTE, .src_maxburst = 8, }; -- 2.40.1