Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADC04EE6459 for ; Fri, 15 Sep 2023 11:30:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234325AbjIOLaG (ORCPT ); Fri, 15 Sep 2023 07:30:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234243AbjIOLaG (ORCPT ); Fri, 15 Sep 2023 07:30:06 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 661181AD for ; Fri, 15 Sep 2023 04:30:00 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DB94EE4; Fri, 15 Sep 2023 13:28:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1694777305; bh=kcaoTGt0jrV89mq5ALxH0jIw4/ByV0YBfyHZo8RowFY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Yo1l42ajpzY3ZXEpGWxOrhZ/omfdGJ8R1kSrI/xqbr6mGYIyPQw3/NEbYkMcTb46G i8n800HUhucRNhpF8GdQcC5WNfg1xZhDQ2TVx/E7MOf8iKxKP4h7R2o8fynhcP+0x0 evPhfURinbRfqrTUp61e8W/cS2RCeO5vDq093/bs= Date: Fri, 15 Sep 2023 14:30:12 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, Tianshu Qiu , Bingbu Cao , Tomi Valkeinen , Jacopo Mondi Subject: Re: [PATCH 5/7] media: ov2740: Enable runtime PM before registering the async subdev Message-ID: <20230915113012.GJ14641@pendragon.ideasonboard.com> References: <20230915072809.37886-1-sakari.ailus@linux.intel.com> <20230915072809.37886-6-sakari.ailus@linux.intel.com> <20230915094239.GF14641@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Sep 15, 2023 at 10:09:37AM +0000, Sakari Ailus wrote: > On Fri, Sep 15, 2023 at 12:42:39PM +0300, Laurent Pinchart wrote: > > On Fri, Sep 15, 2023 at 10:28:07AM +0300, Sakari Ailus wrote: > > > Enable runtime PM before registering the async sub-device as the ipu > > > bridge may try to resume the device immediately after the async sub-device > > > > I wouldn't mention ipu bridge there, as this driver is not specific to a > > particular CSI-2 receiver. > > > > > has been registered. If runtime PM is still disabled, this will fail. > > > > > > Signed-off-by: Sakari Ailus > > > --- > > > drivers/media/i2c/ov2740.c | 14 ++++++++------ > > > 1 file changed, 8 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c > > > index 41d4f85470fd..319dc00e47b4 100644 > > > --- a/drivers/media/i2c/ov2740.c > > > +++ b/drivers/media/i2c/ov2740.c > > > @@ -1172,6 +1172,12 @@ static int ov2740_probe(struct i2c_client *client) > > > goto probe_error_v4l2_ctrl_handler_free; > > > } > > > > > > + /* Set the device's state to active if it's in D0 state. */ > > > + if (full_power) > > > + pm_runtime_set_active(&client->dev); > > > > I wonder why we need this in drivers. If ACPI has powered the device on > > prior to calling probe(), couldn't it also set the PM runtime state > > accordingly ? > > What happens here is that the ipu bridge creates a VCM device and it > resumes the related sensor before instantiating that device (see > ipu_bridge_instantiate_vcm_work()). However this may take place already > right after registering the async sub-device. Resuming the sensor will fail > if runtime PM isn't enabled. > > I'll add something along these lines to the commit message. I understand this, but that doesn't answer my question :-) Why is there a need to call pm_runtime_set_active(), couldn't it be done somewhere in common code ? > > > + pm_runtime_enable(&client->dev); > > > + pm_runtime_idle(&client->dev); > > > + > > > > With the commit message fixed, > > > > Reviewed-by: Laurent Pinchart > > Thank you. > > > > ret = v4l2_async_register_subdev_sensor(&ov2740->sd); > > > if (ret < 0) { > > > dev_err_probe(dev, ret, "failed to register V4L2 subdev\n"); > > > @@ -1182,16 +1188,12 @@ static int ov2740_probe(struct i2c_client *client) > > > if (ret) > > > dev_warn(&client->dev, "register nvmem failed, ret %d\n", ret); > > > > > > - /* Set the device's state to active if it's in D0 state. */ > > > - if (full_power) > > > - pm_runtime_set_active(&client->dev); > > > - pm_runtime_enable(&client->dev); > > > - pm_runtime_idle(&client->dev); > > > - > > > return 0; > > > > > > probe_error_media_entity_cleanup: > > > media_entity_cleanup(&ov2740->sd.entity); > > > + pm_runtime_disable(&client->dev); > > > + pm_runtime_set_suspended(&client->dev); > > > > > > probe_error_v4l2_ctrl_handler_free: > > > v4l2_ctrl_handler_free(ov2740->sd.ctrl_handler); -- Regards, Laurent Pinchart