Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F1EFCD13D8 for ; Mon, 18 Sep 2023 12:23:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232601AbjIRMXK (ORCPT ); Mon, 18 Sep 2023 08:23:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241995AbjIRMXE (ORCPT ); Mon, 18 Sep 2023 08:23:04 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 778CDBA for ; Mon, 18 Sep 2023 05:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695039778; x=1726575778; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=34P6LCMy7MR9sHmTEGsozsuHqaUZg+bAh1kkIm0FO7M=; b=PBk9i8c8/nMDBGu4fWSCCw0vWW6gl2yBYHR3OJBZ5StRtcIPxyfDuZ8E 5PAqArfofYYfYF2/FNH4mkpkUjvX/exe7L3lwP7Pfwm9YXoH7h1zIyQkk fS/4sx9UjY3zqoNM41SONzfCgMFrvwrTPNRLOfOIhKG4Rj4GDk3g7fmHw FMzZ0Lq6JP+kgHx/pCqBfPhfPvt7JQh0iqllj7zGhWK1LTEVQWiH4moap ISEDuKp5zLk0z+wURe7MtqiFjySfAKodtipOqpKrkfIi96QyIuAO+J0Bg C68SCDyXHJa3kH4KNnIsJ0gX/zinlTlhNTjJHoCbMRp1dvYDv5BVWa63v w==; X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="446099606" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="446099606" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 05:22:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="889036582" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="889036582" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 18 Sep 2023 05:22:11 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 959211CA; Mon, 18 Sep 2023 15:22:52 +0300 (EEST) Date: Mon, 18 Sep 2023 15:22:52 +0300 From: Mika Westerberg To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: Bjorn Helgaas , Kuppuswamy Sathyanarayanan , Vidya Sagar , "Rafael J. Wysocki" , Kai-Heng Feng , Michael Bottini , "David E . Box" , Tasev Nikola , Mark Enriquez , Thomas Witt , Koba Ko , Werner Sembach , linux-pci@vger.kernel.org Subject: Re: [PATCH v2] PCI/ASPM: Add back L1 PM Substate save and restore Message-ID: <20230918122252.GT1599918@black.fi.intel.com> References: <20230911073352.3472918-1-mika.westerberg@linux.intel.com> <20230918120916.GS1599918@black.fi.intel.com> <28b140a3-8fe9-373d-d66f-20ab104230cc@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <28b140a3-8fe9-373d-d66f-20ab104230cc@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Ilpo, On Mon, Sep 18, 2023 at 03:17:41PM +0300, Ilpo Järvinen wrote: > > > > + */ > > > > + val = cap[1] & PCI_EXP_LNKCTL_ASPMC; > > Given this line, it just felt pretty obvious because why would the code > & PCI_EXP_LNKCTL_* with some random register (value) that isn't LNKCTL :-). That's a fair point :) Okay I can drop the comment in the next version.