Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A624CE7A94 for ; Mon, 25 Sep 2023 10:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xGiKTSEGTwnKUAasubdCFW4dmkuTOTAbl4YR+MC6Uew=; b=KldkHAxtT54dco DatREsjnTxLCUMFEX3BG9r14BI8rVPLFduBoODbrStD1XVmkBOD+bJ0Cp08OI2qFw6bkuNnvbXCzN GLgCrVInYbuqovh7U4p9I3waSsK9qnsiPKCwSIaWRu9jtXJNDXurQ5gICu1YIi/lAzNmC8LPmGm74 5w5WVWMzNiclEvewbzA32SDGT7eZ4E1u8p3e5FHtYqt3v8BJgNp8W8b+w4pnZhg03tTc2/PEO+LYm FeOw8q7VNgefp76Q3vqi3GS4fbdYoA14NrG0fL8UcEwS8cWAYvTBkRYMk8CU0dC6ctopeLUCKPJ7D TQFZ79LK6IAvlDy8TD1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkiVq-00DwIQ-1M; Mon, 25 Sep 2023 10:08:22 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkiVp-00DwHt-2M for linux-arm-kernel@bombadil.infradead.org; Mon, 25 Sep 2023 10:08:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Y7E2bQ4BW1hdfSm1jmBqima+v3SGUmJwYC5NN1UQOGs=; b=BwDRgNfNuC128GwhOi5yLtjQFJ 5iPjYYCJ3ixmHKGM/6B+7Innix6B5Yocgt73ouQKyvklSfFGIdhUt6q4iZ+tXqj7QeqDFbX9ZCRqA 6Gv6Hl9cHTHJngWHbud9hY0ARV730WrmidC7Llj05Qu0fzJkAcCMmyXJHx+dnpHpegxJ/iWAfyT85 FndGq+/Czwf8pWl9Lq88DNJ1FRVYlYBiNYdqxWJBr3ytQN6ACd6INvlblqzFADbmEVeOHMT4XQgsa 5iVwombFguHPNRON890voSS+vKXDUU3sH0DUc/rYESAqYYocCompaJgrgA+ohkjQKbmNOG/m7/9Gj e9pZwXPw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qkiVh-001Z9v-28; Mon, 25 Sep 2023 10:08:16 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id C108E30027E; Mon, 25 Sep 2023 12:08:14 +0200 (CEST) Date: Mon, 25 Sep 2023 12:08:14 +0200 From: Peter Zijlstra To: Ming Qian Cc: mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, eagle.zhou@nxp.com, tao.jiang_2@nxp.com, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] wait: don't wake up freezable wait by freezing fake signal Message-ID: <20230925100814.GA31921@noisy.programming.kicks-ass.net> References: <20230822074547.8037-1-ming.qian@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230822074547.8037-1-ming.qian@nxp.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 22, 2023 at 03:45:47PM +0800, Ming Qian wrote: > kernel may try to wake up task with fake signal when freezing task, > if the task is waiting event using wait_event_freezable, > it's better to freeze the wait, instead of breaking it. > > otherwise the caller may need to retry the wait, > maybe like below code: > > if (rc == -ERESTARTSYS && freezing(current)) { > clear_thread_flag(TIF_SIGPENDING); > goto again; > } I'm not sure I get it -- is there an actual problem, or are you trying to optimize something? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel