Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88A6CE81E01 for ; Fri, 6 Oct 2023 14:35:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232433AbjJFOf5 (ORCPT ); Fri, 6 Oct 2023 10:35:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231129AbjJFOf4 (ORCPT ); Fri, 6 Oct 2023 10:35:56 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32B53CA for ; Fri, 6 Oct 2023 07:35:54 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D73CD1F896; Fri, 6 Oct 2023 14:35:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1696602952; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KeB0SmHf5xxqC0L7Ojwgzas1ilX/ROAIfugbCKnNHwI=; b=UneBO1oU4cQa2SvkPpaR69KCpV3ILR6d1IwpWxUiiTRcRcCkkz8DwKR5CSQNNjVY53O1jF 8Qw8abakp/G/aLIWrHz0WmP+fbP6AhvknGsb+Nb6Z1vJI+geLAk2d5VU9XIbxq8aQ5AVew BhOaYIf8UYnxPdiD//dEdVEg3t3A+xY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1696602952; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KeB0SmHf5xxqC0L7Ojwgzas1ilX/ROAIfugbCKnNHwI=; b=1BvSl5+KcRtHoyuWEBYuTut2gLcuKle4qYD9IgDqJEOKvE8yTOnDKZHpJqEWOWt0CjS4ok Tis2Duz7wQGPVkAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BE02713586; Fri, 6 Oct 2023 14:35:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bKKLLUgbIGVqYgAAMHmgww (envelope-from ); Fri, 06 Oct 2023 14:35:52 +0000 Date: Fri, 6 Oct 2023 16:29:09 +0200 From: David Sterba To: fdmanana@kernel.org Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH 0/6] btrfs: fix some data races during fsync and cleanups Message-ID: <20231006142909.GD28758@twin.jikos.cz> Reply-To: dsterba@suse.cz References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Oct 04, 2023 at 11:38:47AM +0100, fdmanana@kernel.org wrote: > From: Filipe Manana > > The following remove some data races affecting mostly fsync. In general > these are mostly harmless from a functional perspective, though there are > a few cases that could cause some unexpected results but should be very > rare to hit. There's also a couple cleanups here. > More details on the changelogs. > > Filipe Manana (6): > btrfs: add and use helpers for reading and writing last_log_commit > btrfs: add and use helpers for reading and writing log_transid > btrfs: add and use helpers for reading and writing fs_info->generation > btrfs: add and use helpers for reading and writing last_trans_committed > btrfs: remove pointless barrier from btrfs_sync_file() > btrfs: update comment for struct btrfs_inode::lock Added to misc-next as the changes are straightforward, if there's any fixup needed for the increments I'll do that in the commits after we agree. Thanks.