From: Andrew Jones Date: Tue, 24 Oct 2023 17:23:56 +0200 Subject: [PATCH v2 2/5] riscv: Use SYM_*() assembly macros instead of deprecated ones In-Reply-To: <20231024132655.730417-3-cleger@rivosinc.com> References: <20231024132655.730417-1-cleger@rivosinc.com> <20231024132655.730417-3-cleger@rivosinc.com> Message-ID: <20231024-e122c317599cd4c6db53c015@orel> List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Oct 24, 2023 at 03:26:52PM +0200, Cl?ment L?ger wrote: ... > diff --git a/arch/riscv/lib/uaccess.S b/arch/riscv/lib/uaccess.S > index 09b47ebacf2e..3ab438f30d13 100644 > --- a/arch/riscv/lib/uaccess.S > +++ b/arch/riscv/lib/uaccess.S > @@ -10,8 +10,7 @@ > _asm_extable 100b, \lbl > .endm > > -ENTRY(__asm_copy_to_user) > -ENTRY(__asm_copy_from_user) > +SYM_FUNC_START(__asm_copy_to_user) > > /* Enable access to user memory */ > li t6, SR_SUM > @@ -181,13 +180,13 @@ ENTRY(__asm_copy_from_user) > csrc CSR_STATUS, t6 > sub a0, t5, a0 > ret > -ENDPROC(__asm_copy_to_user) > -ENDPROC(__asm_copy_from_user) > +SYM_FUNC_END(__asm_copy_to_user) > EXPORT_SYMBOL(__asm_copy_to_user) > +SYM_FUNC_ALIAS(__asm_copy_from_user, __asm_copy_to_user) > EXPORT_SYMBOL(__asm_copy_from_user) I didn't see any comment about the sharing of debug info among both the from and to functions. Assuming it isn't confusing in some way, then Reviewed-by: Andrew Jones Thanks, drew