Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D03F6C4332F for ; Fri, 3 Nov 2023 13:08:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A37728001D; Fri, 3 Nov 2023 09:08:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 653C828000F; Fri, 3 Nov 2023 09:08:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51C5228001D; Fri, 3 Nov 2023 09:08:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4160028000F for ; Fri, 3 Nov 2023 09:08:22 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 182FDB5F33 for ; Fri, 3 Nov 2023 13:08:22 +0000 (UTC) X-FDA: 81416671644.02.64EF090 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 25F3518000B for ; Fri, 3 Nov 2023 13:08:18 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bbOoB+IO; dmarc=none; spf=none (imf06.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699016900; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FVKgUj0uIHkMY78KC2G3LoMl8HM52HmVt0kx80HproA=; b=KQ5weC7/3vFGwQCUGOfvFZ5wd9WPd3ihFvZDkLZIn2Oz8n3QVOoG4YVLsLGtzGXxazg7o7 +wdauqZJli9Ld6rzAiXs4qPgmP9nZeaVYzHaNGixhs+y0W5CL8fqjvQCx8czU48KnOO097 FkTMGCOBAkdakL4kMNVdRmV9lYnuroQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bbOoB+IO; dmarc=none; spf=none (imf06.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699016900; a=rsa-sha256; cv=none; b=EaKU47dNVBr2i+yLrXYNDarTSV9bfaLymuEDOzvQkd/5j3NQfBTZIsfM7IdHqyJrE4I9q1 //RY0iCaTxFavjhlf6PywNBHWrKDUJdW8b8ZR2DnA/rw+WHUXPKOb40hqrBsGdu2Sod/RK ofTDdmAoUAHlPH0LOduqziFwsoEFs0w= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FVKgUj0uIHkMY78KC2G3LoMl8HM52HmVt0kx80HproA=; b=bbOoB+IOaYQ7ibWjfJ0UuoeNc9 tqG6JFZK+5q/P5hbo3bF24UolPUzIHBjInC9ad/2V4q8sMTi2PeKiAhIdoE9tUgBfF5ejOLGmQOKL hvPT68kZzruopT6g92dRJ5stja0/mnoWKg+4ykIFhdh9d8RqtBG/8vQJuqJQgYrIUGwo7FCBqRmZy mqx61wXt+mhGOh1n7qXCNtAMTvA0zFrFszr00Nt31MdL4IvEOR0aBFlY2eJKmiNBNzcMl2OLnjkw9 fIqyiGQBItdk26uVw/BtIObjQK9Rp2+QIvDlZW3bBuEOiI8KvUXjQVJ4Qenhu4xziGBXDI96ri8cM Zk5Ib0xQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qytuI-005WWa-EH; Fri, 03 Nov 2023 13:08:15 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id C451D30027B; Fri, 3 Nov 2023 14:08:14 +0100 (CET) Date: Fri, 3 Nov 2023 14:08:14 +0100 From: Peter Zijlstra To: David Hildenbrand Cc: John Hubbard , Linus Torvalds , Andrew Morton , Peter Xu , Shuah Khan , Nathan Chancellor , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML , Muhammad Usama Anjum , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built Message-ID: <20231103130814.GC8262@noisy.programming.kicks-ass.net> References: <20230606071637.267103-1-jhubbard@nvidia.com> <20230606071637.267103-12-jhubbard@nvidia.com> <20231103121652.GA6217@noisy.programming.kicks-ass.net> <20231103124606.GB8262@noisy.programming.kicks-ass.net> <15ff806d-59ab-46ab-8891-05ab917a1528@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15ff806d-59ab-46ab-8891-05ab917a1528@redhat.com> X-Rspamd-Queue-Id: 25F3518000B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: adzd96ja7it5bdgij33jak9j3i97s5xt X-HE-Tag: 1699016898-684880 X-HE-Meta: U2FsdGVkX199K3hCj8fF7EJ93HSe2VUKGF5hrJlQytWePpD0+8IdGQgVx2zP7p36Ln5zgBC+3vjN45KRPG7FhKay6FIpvLkWx+p+gNq0L9N7tmiv7TggYxFtPX7oI9a+pM8IlSPD+gHK4QOdEdW91cmpPKs/CCINpOUkYgf5iEHiiOnS7cnDMNs0k6ZjPHlq17hfQffZViUpiIXUujQIvFtdtQ3jYJSjoPAYW5dVTHZwLWP4hA7HpHWCKjIX731jX+OQEeR5AqlfthDlHJIbggfF0Dm91X/gmXQBAaTkx5BpOGZrwD9cIYsPItraHAad6m3qVdmyjEGzOAAE73lu42jc9INe5Cax7Hl5JrlWIQZ9gHAu5EphhyWlFhXiXX/Fip0IiVdbdgSZhAwSx7RmjLYPKb7UakPpPsO+3WGpZyqNFbVCnUVPv48venXX+xqRMEBjx0cHCHCo89WQdUkszWFw/MGRj9J34ncPWD8yQPJpHVTPYKpN60OgLrpBQe8aFB30BQEsFEJlgsIk2tbXr8ygi/EXRw4aVutU6VQFroQKIL5je+TNuK1Uvm+w/evLrotHU4FDEAnyukGguLTzhPnbtdXnfT9x1FGnfE45NRrlWAm6ab80d6ilQaOBaj3nbkrGarYIXpE4VFokr6YZAtHKCiIRE8V8SRztfcB6KwjdVQniB9+WAUS9HoGpDfS4+autkKAEQrPGzRgDkfNSVibgiULx32Og4mhKDcopV5cpVvlhcr1fENWZXsqoReZGgh+0Loos+aUEFBqJxJp7dcJc9pPPGNpq9Ney2Svc3cNohNpRJ8JibXKeBaxoNZURhpll7HaWmPnMrjvWwU1k6nxBCz0ZKrlNoy2i5HvpdyZaGiXAZblIvLCEJymn8gAOgjxA1VBgZ1YcH0hQYYE1PwtzfKvzPJ2i3zVmYRWpkSxLQz/l/mI1cs8u6tYV0xR6kjHsXUGS8rIcoRHxKqr +r/ft884 2HrtOikr6yOTENw5s+avb6X2qZwTablHYjz/9XQjKUFP1/vQeWLNvXmG/Fk3gO0nt/0Eitfk77loVS5RjAkVLJOwOfc5uw1/1SvPp5Xe7c/3qfjeEtnSfzD/e+zGo4fpiZ+eioNDHsbqODPA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 03, 2023 at 01:59:28PM +0100, David Hildenbrand wrote: > Okay. the question is if your workflow can be easily adjusted, or if we can > improve that header handling as a whole. So on IRC the following was suggested: make O=defconfig-build headers ; make O=defconfig-build -C tools/testing/selftests/x86 But that makes absolutely no sense to me; because the headers and selftests are not .config dependent. Furthermore I don't want them in a kernel build dir. > The problem I had with this recently: just because we did a "make headers" > once in a git tree doesn't mean that it is still up-to-date. > > So once some selftest changes showed up that require newer headers, building > the selftests again fails without a hint that another round of "make > headers" would be required. Yeah, so I've been adding #ifndef guards all over the place for decades and that just works. You need it in normal userspace too. This super reliance on the very latestesetst headers is just a total pain.