Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81D6D6D38 for ; Thu, 9 Nov 2023 05:30:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from 66-220-155-178.mail-mxout.facebook.com (66-220-155-178.mail-mxout.facebook.com [66.220.155.178]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D22312696 for ; Wed, 8 Nov 2023 21:30:44 -0800 (PST) Received: by devbig309.ftw3.facebook.com (Postfix, from userid 128203) id A9F9F298DF593; Wed, 8 Nov 2023 21:30:29 -0800 (PST) From: Yonghong Song To: bpf@vger.kernel.org Cc: Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , kernel-team@fb.com, Martin KaFai Lau Subject: [PATCH bpf-next] selftests/bpf: Fix pyperf180 compilation failure with llvm18 Date: Wed, 8 Nov 2023 21:30:29 -0800 Message-Id: <20231109053029.1403552-1-yonghong.song@linux.dev> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable With latest llvm18 (main branch of llvm-project repo), when building bpf = selftests, [~/work/bpf-next (master)]$ make -C tools/testing/selftests/bpf LLVM=3D= 1 -j The following compilation error happens: fatal error: error in backend: Branch target out of insn range ... Stack dump: 0. Program arguments: clang -g -Wall -Werror -D__TARGET_ARCH_x86= -mlittle-endian -I/home/yhs/work/bpf-next/tools/testing/selftests/bpf/tools/include -I/home/yhs/work/bpf-next/tools/testing/selftests/bpf -I/home/yhs/w= ork/bpf-next/tools/include/uapi -I/home/yhs/work/bpf-next/tools/testing/selftests/usr/include -idir= after /home/yhs/work/llvm-project/llvm/build.18/install/lib/clang/18/incl= ude -idirafter /usr/local/include -idirafter /usr/include -Wno-compare-distinct-pointer-types -DENABL= E_ATOMICS_TESTS -O2 --target=3Dbpf -c progs/pyperf180.c -mcpu=3Dv3 -o /home/yhs/work/bpf-next/tools/te= sting/selftests/bpf/pyperf180.bpf.o 1. parser at end of file 2. Code generation ... The compilation failure only happens to cpu=3Dv2 and cpu=3Dv3. cpu=3Dv4 i= s okay since cpu=3Dv4 supports 32-bit branch target offset. The above failure is due to upstream llvm patch [1] where some inlining b= ehavior are changed in llvm18. To workaround the issue, previously all 180 loop iterations are fully unr= olled. Now, the fully unrolling count is changed to 90 for llvm18 and later. Thi= s reduced some otherwise long branch target distance, and fixed the compilation fai= lure. [1] https://github.com/llvm/llvm-project/commit/1a2e77cf9e11dbf56b5720c= 607313a566eebb16e Signed-off-by: Yonghong Song --- tools/testing/selftests/bpf/progs/pyperf180.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/tools/testing/selftests/bpf/progs/pyperf180.c b/tools/testin= g/selftests/bpf/progs/pyperf180.c index c39f559d3100..3c38f3e12836 100644 --- a/tools/testing/selftests/bpf/progs/pyperf180.c +++ b/tools/testing/selftests/bpf/progs/pyperf180.c @@ -1,4 +1,17 @@ // SPDX-License-Identifier: GPL-2.0 // Copyright (c) 2019 Facebook #define STACK_MAX_LEN 180 + +/* llvm upstream commit at llvm18 + * https://github.com/llvm/llvm-project/commit/1a2e77cf9e11dbf56b5720c= 607313a566eebb16e + * changed inlining behavior and caused compilation failure as some bran= ch + * target distance exceeded 16bit representation which is the maximum fo= r + * cpu v1/v2/v3. To workaround this, for llvm18 and later, let us set un= roll_count + * to be 90, which reduced some branch target distances and resolved the + * compilation failure. + */ +#if __clang_major__ >=3D 18 +#define UNROLL_COUNT 90 +#endif + #include "pyperf.h" --=20 2.34.1