Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C5B0C04A95 for ; Fri, 10 Nov 2023 11:04:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AoMOk6HvKFfeZEPV9ZJl5ueValkt3oJBVQ8MLqYZ6ZY=; b=0wi3St/+rwOaO8 8gBqhkPw35uoG38PTIOMMZhC26xqXHp/ozZZ4Wm7Vg+3FTfKewjhXas6ifPl9W69BX2aWEiEZaM3K ZtsYKwQfbYkVwqw6N//GxYgEw937OpQTiRj836gpcgRYNRgp52exmiAVXW2SvAd0SN2YW5mpvM0E4 WC+opcTqV1KMlIuQQ/pMp6WJJ8DuOjuZJ9UlRQDDUoZh17nlG5DW2ln+F5tyeoS6G/5YXWXTNd4mR 8PuToZH0QVloBFLXQgBbswzH3PtAcxrnxtmU2/NY5oX9Z9qEsAuUWfELJcvgWrQbf7m3U/BCiP366 uXg4o2oxQpj/Fh8nJBAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1PJH-008LwO-0S; Fri, 10 Nov 2023 11:04:23 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1PJD-008Ls1-12 for linux-um@lists.infradead.org; Fri, 10 Nov 2023 11:04:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=UTRfli/F+K5IFdcx4q5ybvkO8+GLoNcg66HV01o11RE=; t=1699614258; x=1700823858; b=xWzcypos0GFcbiJTVz20ishx31iR8cQWdHNRvV/GkPIY2qJ J8IsFUcWp4vxEpU8bHl0f4PpgbREGja59uWt3XDg2IZz0eg7SWTSy6zoWEXwTQ1RVEznwaqcGh7+6 wh3m83opqlBmhHxTdWXvvDDt+U29U08sTB/rr8pj86s5WvPKFFkjOZ6BUpt3HnPIUqK9HD7WXU5TD eFUM9ujHqp2gmrMWsK8q8nO/opsQx3XGM9Wk4E22yu/RYc3r+4mPlme9fDWIGhjIY3WLze2pbb898 Bq1+RiZvB9QhfmCpMxLV10vXGco3WNkNrFf+TWa/Z5AJAkiVOiYQkDzwjvU7TqyA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1r1PJ9-00000002xHc-1Nnq; Fri, 10 Nov 2023 12:04:15 +0100 From: benjamin@sipsolutions.net To: linux-um@lists.infradead.org Cc: Benjamin Berg Subject: [PATCH v3 04/11] um: Don't use vfprintf() for os_info() Date: Fri, 10 Nov 2023 12:03:41 +0100 Message-ID: <20231110110348.1815612-5-benjamin@sipsolutions.net> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231110110348.1815612-1-benjamin@sipsolutions.net> References: <20231110110348.1815612-1-benjamin@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231110_030419_360732_25488D37 X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org From: Benjamin Berg The threads allocated inside the kernel have only a single page of stack. Unfortunately, the vfprintf function in standard glibc may use too much stack-space, overflowing it. To make os_info safe to be used by helper threads, use the kernel vscnprintf function into a smallish buffer and write out the information to stderr. Signed-off-by: Benjamin Berg --- arch/um/os-Linux/util.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/arch/um/os-Linux/util.c b/arch/um/os-Linux/util.c index fc0f2a9dee5a..1dca4ffbd572 100644 --- a/arch/um/os-Linux/util.c +++ b/arch/um/os-Linux/util.c @@ -173,23 +173,38 @@ __uml_setup("quiet", quiet_cmd_param, "quiet\n" " Turns off information messages during boot.\n\n"); +/* + * The os_info/os_warn functions will be called by helper threads. These + * have a very limited stack size and using the libc formatting functions + * may overflow the stack. + * So pull in the kernel vscnprintf and use that instead with a fixed + * on-stack buffer. + */ +int vscnprintf(char *buf, size_t size, const char *fmt, va_list args); + void os_info(const char *fmt, ...) { + char buf[256]; va_list list; + int len; if (quiet_info) return; va_start(list, fmt); - vfprintf(stderr, fmt, list); + len = vscnprintf(buf, sizeof(buf), fmt, list); + fwrite(buf, len, 1, stderr); va_end(list); } void os_warn(const char *fmt, ...) { + char buf[256]; va_list list; + int len; va_start(list, fmt); - vfprintf(stderr, fmt, list); + len = vscnprintf(buf, sizeof(buf), fmt, list); + fwrite(buf, len, 1, stderr); va_end(list); } -- 2.41.0 _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um