Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 022FD20B2D for ; Mon, 13 Nov 2023 16:12:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="V+dXfJmM" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3F0010F4 for ; Mon, 13 Nov 2023 08:12:12 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7698B29A; Mon, 13 Nov 2023 17:11:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1699891906; bh=0H0SobTVWoMIt35IXmK4t2u4vxKWawLKprExuxq8Y7c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V+dXfJmMK+FuQrzwRbBowXVn5Dw4cHq1pKohDrKxBk+pSAGWQWhwImZMszUNvKqZY NdZoy7SicCSRbrEcqjkmCjMrvgQ6JlbToi8HvQhHDHwhqTgnqza3qA0PsZJ4jBcb9j N8C5DikJpmjFuQjcuFFbNsLaCUPtD/ZEll7XH9Pc= Date: Mon, 13 Nov 2023 18:12:17 +0200 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, hdegoede@redhat.com Subject: Re: [PATCH v3 5/6] media: ccs: Better separate CCS static data access Message-ID: <20231113161217.GI24338@pendragon.ideasonboard.com> References: <20231113160601.1427972-1-sakari.ailus@linux.intel.com> <20231113160601.1427972-6-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231113160601.1427972-6-sakari.ailus@linux.intel.com> On Mon, Nov 13, 2023 at 06:06:00PM +0200, Sakari Ailus wrote: > Separate CCS static data read-only register access in ccs-reg-access.c by > naming them differently. > > The code in this file generally deals with reading and writing registers > where as static data (when it comes to ccs_static_data_read_ro_reg()) > contains the read-only register values but no hardware registers are > accessed in that case. > > Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/ccs/ccs-reg-access.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/drivers/media/i2c/ccs/ccs-reg-access.c b/drivers/media/i2c/ccs/ccs-reg-access.c > index 25993445f4fe..03daaa8310a6 100644 > --- a/drivers/media/i2c/ccs/ccs-reg-access.c > +++ b/drivers/media/i2c/ccs/ccs-reg-access.c > @@ -197,8 +197,8 @@ static int __ccs_read_addr(struct ccs_sensor *sensor, u32 reg, u32 *val, > return 0; > } > > -static int __ccs_read_data(struct ccs_reg *regs, size_t num_regs, > - u32 reg, u32 *val) > +static int __ccs_static_data_read_ro_reg(struct ccs_reg *regs, size_t num_regs, > + u32 reg, u32 *val) > { > unsigned int width = ccs_reg_width(reg); > size_t i; > @@ -235,16 +235,17 @@ static int __ccs_read_data(struct ccs_reg *regs, size_t num_regs, > return -ENOENT; > } > > -static int ccs_read_data(struct ccs_sensor *sensor, u32 reg, u32 *val) > +static int > +ccs_static_data_read_ro_reg(struct ccs_sensor *sensor, u32 reg, u32 *val) > { > - if (!__ccs_read_data(sensor->sdata.sensor_read_only_regs, > - sensor->sdata.num_sensor_read_only_regs, > - reg, val)) > + if (!__ccs_static_data_read_ro_reg(sensor->sdata.sensor_read_only_regs, > + sensor->sdata.num_sensor_read_only_regs, > + reg, val)) > return 0; > > - return __ccs_read_data(sensor->mdata.module_read_only_regs, > - sensor->mdata.num_module_read_only_regs, > - reg, val); > + return __ccs_static_data_read_ro_reg(sensor->mdata.module_read_only_regs, > + sensor->mdata.num_module_read_only_regs, > + reg, val); > } > > static int ccs_read_addr_raw(struct ccs_sensor *sensor, u32 reg, u32 *val, > @@ -253,7 +254,7 @@ static int ccs_read_addr_raw(struct ccs_sensor *sensor, u32 reg, u32 *val, > int rval; > > if (data) { > - rval = ccs_read_data(sensor, reg, val); > + rval = ccs_static_data_read_ro_reg(sensor, reg, val); > if (!rval) > return 0; > } -- Regards, Laurent Pinchart