Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hbMK9hG0" Received: from mail-ed1-x54a.google.com (mail-ed1-x54a.google.com [IPv6:2a00:1450:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AC021988 for ; Fri, 24 Nov 2023 09:30:40 -0800 (PST) Received: by mail-ed1-x54a.google.com with SMTP id 4fb4d7f45d1cf-5400c8c6392so1627191a12.1 for ; Fri, 24 Nov 2023 09:30:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1700847038; x=1701451838; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:from:to:cc:subject:date :message-id:reply-to; bh=cE5rDFH6x5j4SoKk4DtVJx1DhUKwtpy6ptWA1YpaYbc=; b=hbMK9hG07y4xsOwCBLf2mCkaVBU2eI8Vmkh1TsB1CzqRUIeusDsFLTrQzHq1mjd0XY MacG7AIZEbySfS4dFT/aI5OzB5F7ZxTWtjusc71+VjfzOJ7FgVbVWFJmr0TreCEL5cJi QYPVvvCqCXRwrdsWHASyZjBWWGLSMM0HJ8EVxpKI/YJ/LDQVG+KYvMznTMiM3QQSGxOF qLctIFcEShT8b7FedfgFDiKTcjwI9F7zve1jB1w2MRTKVsXgKMAUYVtnZG3a3OStBM+4 yrl1RJRDDgnVJXELOdbhCUPaXAbMqwE6UcY53D6cbk+cVNQlFROcNZgG4mYcbvt8GC0D 9flQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700847038; x=1701451838; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=cE5rDFH6x5j4SoKk4DtVJx1DhUKwtpy6ptWA1YpaYbc=; b=P0XMzViBMXI8ywC/Ye8OnFhmV/x9sTT3iqTYaYskF0RsV8R/8g8mUXu6UGcUvv/Z0V +xJ3HStyqpORWQxn23FtKdpdBpPpsTa3ckGhW2g5nGlZqVAsE900M2y93PJNdiRZOCIB Q8fBjuflYvtF1J36htVqhoHLQ6fZaiVcXM4sa8ebaxcsvDs3fiRLkKtUdr6vtgFs2zZH 7KG++eZF5dtqjHPyZOPPlzUM/HlNUtWl/5IZhSpTpjkgF3IVRCf1CX9jpscyyc1rrcrh 5ONQ5Iwz/Tf8bg0SIesaztfudjG+oRuJbK8466R/Wu22rD4u+l10v5uFSFNv4aG8+WV8 i9/g== X-Gm-Message-State: AOJu0Yz2zJJDCX3v9wzmtMfnwXYP/m7GV8SkiVcYGhGbD41HidyXwq37 GwWIFirjqvQ51aO1UwQyHNmYPdWVK1Q= X-Google-Smtp-Source: AGHT+IETe/Dbs3vmeQMZmBig8gIXuHSA29s90JqKtKtH66znmXRynNfy2ka1k2f1tqw+AlU2RXXCzWLwV68= X-Received: from sport.zrh.corp.google.com ([2a00:79e0:9d:4:9429:6eed:3418:ad8a]) (user=gnoack job=sendgmr) by 2002:a05:6402:11c9:b0:540:37c6:677c with SMTP id j9-20020a05640211c900b0054037c6677cmr44850edw.6.1700847038708; Fri, 24 Nov 2023 09:30:38 -0800 (PST) Date: Fri, 24 Nov 2023 18:30:20 +0100 In-Reply-To: <20231124173026.3257122-1-gnoack@google.com> Message-Id: <20231124173026.3257122-4-gnoack@google.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20231124173026.3257122-1-gnoack@google.com> X-Mailer: git-send-email 2.43.0.rc1.413.gea7ed67945-goog Subject: [PATCH v6 3/9] landlock: Optimize the number of calls to get_access_mask slightly From: "=?UTF-8?q?G=C3=BCnther=20Noack?=" To: linux-security-module@vger.kernel.org, "=?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?=" Cc: Jeff Xu , Jorge Lucangeli Obes , Allen Webb , Dmitry Torokhov , Paul Moore , Konstantin Meskhidze , Matt Bobrowski , linux-fsdevel@vger.kernel.org, "=?UTF-8?q?G=C3=BCnther=20Noack?=" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This call is now going through a function pointer, and it is not as obvious any more that it will be inlined. Signed-off-by: G=C3=BCnther Noack --- security/landlock/ruleset.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/security/landlock/ruleset.c b/security/landlock/ruleset.c index 789c81b26a50..e0a5fbf9201a 100644 --- a/security/landlock/ruleset.c +++ b/security/landlock/ruleset.c @@ -723,11 +723,12 @@ landlock_init_layer_masks(const struct landlock_rules= et *const domain, /* Saves all handled accesses per layer. */ for (layer_level =3D 0; layer_level < domain->num_layers; layer_level++) = { const unsigned long access_req =3D access_request; + const access_mask_t access_mask =3D + get_access_mask(domain, layer_level); unsigned long access_bit; =20 for_each_set_bit(access_bit, &access_req, num_access) { - if (BIT_ULL(access_bit) & - get_access_mask(domain, layer_level)) { + if (BIT_ULL(access_bit) & access_mask) { (*layer_masks)[access_bit] |=3D BIT_ULL(layer_level); handled_accesses |=3D BIT_ULL(access_bit); --=20 2.43.0.rc1.413.gea7ed67945-goog