Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89514C4167B for ; Wed, 29 Nov 2023 13:46:56 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 420E53CC28F for ; Wed, 29 Nov 2023 14:46:54 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id EB0293CC28F for ; Wed, 29 Nov 2023 14:46:42 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 16B2D1400FB3 for ; Wed, 29 Nov 2023 14:46:41 +0100 (CET) Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EFBCC1FCE6; Wed, 29 Nov 2023 13:46:40 +0000 (UTC) Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id CCFD41376F; Wed, 29 Nov 2023 13:46:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id vHJDMcBAZ2XtIwAAn2gu4w (envelope-from ); Wed, 29 Nov 2023 13:46:40 +0000 Date: Wed, 29 Nov 2023 14:46:39 +0100 From: Petr Vorel To: Jan Kara Message-ID: <20231129134639.GA1426618@pevik> References: <20231129114617.12660-1-jack@suse.cz> <20231129115440.19100-3-jack@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231129115440.19100-3-jack@suse.cz> Authentication-Results: smtp-out2.suse.de; none X-Rspamd-Server: rspamd2 X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Queue-Id: EFBCC1FCE6 X-Virus-Scanned: clamav-milter 1.0.1 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 3/6] fanotify: Switch event and mark tests to *_on_fs() variant X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Jan, Amir, > Switch event availability and mark type availability tests to be > performed on the filesystem actually used for testing instead of on the > current directory. This is more reliable as not all filesystems support > the same set of features. Jan, unfortunately this commit breaks fanotify09 and fanotify10 on SLES15 based kernels: # ./fanotify09 tst_device.c:97: TINFO: Found free device 0 '/dev/loop0' tst_test.c:1106: TINFO: Formatting /dev/loop0 with ext2 opts='' extra opts='' mke2fs 1.46.4 (18-Aug-2021) tst_test.c:1120: TINFO: Mounting /dev/loop0 to /tmp/LTP_fanRt2Q1k/fs_mnt fstyp=ext2 flags=0 tst_test.c:1690: TINFO: LTP version: 20230929-156-gf7f69b7ef tst_test.c:1576: TINFO: Timeout per run is 0h 00m 30s fanotify.h:210: TBROK: fanotify_mark (3, FAN_MARK_ADD, ..., AT_FDCWD, fs_mnt) failed: EINVAL (22) ... # ./fanotify10 tst_device.c:97: TINFO: Found free device 0 '/dev/loop0' tst_test.c:1106: TINFO: Formatting /dev/loop0 with ext2 opts='' extra opts='' mke2fs 1.46.4 (18-Aug-2021) tst_test.c:1120: TINFO: Mounting /dev/loop0 to /tmp/LTP_fanTNt5os/fs_mnt fstyp=ext2 flags=0 tst_test.c:1690: TINFO: LTP version: 20230929-156-gf7f69b7ef tst_test.c:1576: TINFO: Timeout per run is 0h 00m 30s fanotify.h:210: TBROK: fanotify_mark (3, FAN_MARK_ADD, ..., AT_FDCWD, fs_mnt) failed: EINVAL (22) fanotify10.c:948: TWARN: unlink(fs_mnt/testdir/testfile) failed: ENOENT (2) fanotify10.c:949: TWARN: rmdir(fs_mnt/testdir/testdir2) failed: ENOENT (2) fanotify10.c:950: TWARN: rmdir(fs_mnt/testdir) failed: ENOENT (2) fanotify10.c:951: TWARN: rmdir(mntpoint) failed: ENOENT (2) ... I suppose the problem is somewhere in fanotify_flags_supported_on_fs(), i.e. in the first commit. It works well on Tumbleweed, which uses latest official stable kernel. Can you please have look on the issue? Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp