Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2928C07E97 for ; Tue, 5 Dec 2023 11:27:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A1AD510E4F9; Tue, 5 Dec 2023 11:27:32 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5008010E4F9 for ; Tue, 5 Dec 2023 11:27:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701775650; x=1733311650; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=S0ssUHOtV78W1cwAHhTeXIzW8rS0MAZgUdtLQNji59M=; b=VlsUL/VGkNmzIQXDhTmQILMqU8buVNVKCSMHKvnE0yyqG1LA1VyZZEgo olKtxGssvpoPLUNSfxj6ZWpWpUT9AVX/rErF0kIc7XL+yvwNpvjQ6TPnI iXrIovv4im8h89uNjcLJgDvMhFQblPHySsgcNvEDSmw5inG834bK8ftdP GvHSnfqpHkV9ETpqGGaLYDmYp6GkyPfDAgTponnrXtQA5X+cRcEPjsWWD ueZaGMvng5pM1NqakSrG92LQseRnhsPM1qkUK0ejdGbifXhVEria/aGjN Y6JClYF6wqbpgGWhGK6WFZGkUFJf2TOLN+D7Jhj+khYHVSFxXlYc6MsES Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="396675977" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="396675977" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 03:27:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="774606540" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="774606540" Received: from bergbenj-mobl1.ger.corp.intel.com (HELO jhogande-mobl1.intel.com) ([10.249.33.227]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 03:27:28 -0800 From: =?UTF-8?q?Jouni=20H=C3=B6gander?= To: intel-xe@lists.freedesktop.org Date: Tue, 5 Dec 2023 13:27:09 +0200 Message-Id: <20231205112717.1349830-2-jouni.hogander@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231205112717.1349830-1-jouni.hogander@intel.com> References: <20231205112717.1349830-1-jouni.hogander@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Transfer-Encoding: 8bit Subject: [Intel-xe] [PATCH v4 1/9] Revert "FIXME: drm/i915: xe intel_fb.c framebuffer init and destroy xe changes" X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Jouni=20H=C3=B6gander?= Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" This reverts commit 14d1d786caacdb3438d07ab86fabf2e36c8151cc. Revert this as we are about to introduce implementation without any ifdefs. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_fb.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c index 16c37a508552..f7675284907f 100644 --- a/drivers/gpu/drm/i915/display/intel_fb.c +++ b/drivers/gpu/drm/i915/display/intel_fb.c @@ -1891,17 +1891,6 @@ static void intel_user_framebuffer_destroy_vm(struct drm_framebuffer *fb) if (intel_fb_uses_dpt(fb)) intel_dpt_destroy(intel_fb->dpt_vm); -#ifndef I915 - if (intel_fb_obj(fb)->flags & XE_BO_CREATE_PINNED_BIT) { - struct xe_bo *bo = intel_fb_obj(fb); - - /* Unpin our kernel fb first */ - xe_bo_lock(bo, false); - xe_bo_unpin(bo); - xe_bo_unlock(bo); - } - xe_bo_put(intel_fb_obj(fb)); -#endif } static void intel_user_framebuffer_destroy(struct drm_framebuffer *fb) @@ -2174,10 +2163,6 @@ int intel_framebuffer_init(struct intel_framebuffer *intel_fb, intel_fb->dpt_vm = vm; } -#ifndef I915 - /* Hold a reference to object while fb is alive */ - xe_bo_get(obj); -#endif ret = drm_framebuffer_init(&dev_priv->drm, fb, &intel_fb_funcs); if (ret) { -- 2.34.1