Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 420E71804D for ; Sat, 9 Dec 2023 21:21:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=konsulko.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=konsulko.com header.i=@konsulko.com header.b="Bzg/sQVT" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-5d3c7ef7b31so30117077b3.3 for ; Sat, 09 Dec 2023 13:21:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1702156872; x=1702761672; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dWYEzt/JC2Z8AthVY0z4aaE5tJR8wjrC4ZyUvou7s0Y=; b=Bzg/sQVTUHfGjG1daUbbDuQqWGvB47VL3ZJwBW0HpM6oz4L/02x0ai24OTsZ6Ntn4f zZSn6GuJUpkcswSGmBX9tKq7HuYoQlUP969Rnbw/NZevt+dUqTrEAlO7k802Q8rK4QFd ffetK87UREppv3Lbaaor+BaKLKqarSu0gN6/M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702156872; x=1702761672; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dWYEzt/JC2Z8AthVY0z4aaE5tJR8wjrC4ZyUvou7s0Y=; b=Dgks3CBGh2wcqJDHlGQc8nUANmTej7stq9b6HzDNovNfIdgmJN5jzvHywVVJc41Uzh wzqn+AlmnilR/kSEe0Yn59D4fwhYSv6iapuCM0HO+YSDgc1HHzp7LA2kjrJmKmYrj8Rg Y8e59lGopAHRxq8UrZpsKBA6z0WWdRLMsoRnOjF7nsl4sZxREf9pM67CcMi1AIOHFHsO 3fq4eKgJmoVcFup8pa7h2mvXGBQIkA7WujXrWVo0zmbzGeLD4zuWsyvvnZrTtHL36BUd 5WqTUNLpMDZkVuzzA5Ett5BQqfTWXMpLlT+lOLNUnfRe9lmnmxOZSiBbKUDuOW9+QNev n05Q== X-Gm-Message-State: AOJu0Yxl8QeS6rqgyRwp8+dX8kqGsOKqzfNGftTs8K+Puxg4+JV10SIZ kcnUuzq6a/P2bQ91OumEcjDg/Q== X-Google-Smtp-Source: AGHT+IErZtQqDmM3eqB131gFAASHR5BvDLNCxkjRmpgmNhAKDT0YaM0iahqMyPU7IVacjVvDFqjbKg== X-Received: by 2002:a81:4a84:0:b0:5d7:cfe5:a476 with SMTP id x126-20020a814a84000000b005d7cfe5a476mr1586418ywa.74.1702156871723; Sat, 09 Dec 2023 13:21:11 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-b2bd-da43-c83a-80e1.res6.spectrum.com. [2603:6081:7b00:6400:b2bd:da43:c83a:80e1]) by smtp.gmail.com with ESMTPSA id b125-20020a0dc083000000b005d8ef6a1b0fsm1732152ywd.0.2023.12.09.13.21.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Dec 2023 13:21:11 -0800 (PST) Date: Sat, 9 Dec 2023 16:21:09 -0500 From: Tom Rini To: Dragan Simic Cc: Andre Przywara , Jagan Teki , Simon Glass , Vignesh R , Jaehoon Chung , Jernej Skrabec , Samuel Holland , Mikhail Kalashnikov , Piotr Oniszczuk , Bob McChesney , Stephen Graf , u-boot@lists.denx.de, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 1/3] mtd: spi-nor: Add support for zBIT ZB25VQ128 Message-ID: <20231209212109.GL2513409@bill-the-cat> References: <20231204005954.13201-1-andre.przywara@arm.com> <20231204005954.13201-2-andre.przywara@arm.com> <20231206162443.7f0692d7@donnerap.manchester.arm.com> <20231209203423.GF2513409@bill-the-cat> <3c6b3fe41f54a2d2a391d433684e80d9@manjaro.org> <20231209204336.GG2513409@bill-the-cat> <5f898df3e85bb46df5e3dbaa81525047@manjaro.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PhclFjmZha0vVzIe" Content-Disposition: inline In-Reply-To: <5f898df3e85bb46df5e3dbaa81525047@manjaro.org> X-Clacks-Overhead: GNU Terry Pratchett --PhclFjmZha0vVzIe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 09, 2023 at 10:02:09PM +0100, Dragan Simic wrote: > On 2023-12-09 21:43, Tom Rini wrote: > > On Sat, Dec 09, 2023 at 09:37:28PM +0100, Dragan Simic wrote: > > > On 2023-12-09 21:34, Tom Rini wrote: > > > > On Wed, Dec 06, 2023 at 04:24:43PM +0000, Andre Przywara wrote: > > > > > On Mon, 4 Dec 2023 00:59:52 +0000 > > > > > Andre Przywara wrote: > > > > > > > > > > Hi, > > > > > > > > > > > Add support for the zBIT ZB25VQ128 (128M-bit) SPI NOR flash mem= ory chip, > > > > > > as used on the Xunlong Orange Pi Zero 3 board. > > > > > > > > > > does anyone have any objections against this patch? I wanted to t= ake > > > > > this > > > > > via the sunxi tree, as this blocks some board support patches. > > > > > > > > > > IIUC Linux gave up on adding rather generic entries up for each a= nd > > > > > every > > > > > SPI NOR chip, if there is nothing special about them: > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi= t/commit/?id=3D773bbe1044 > > > > > Should we follow suit here? > > > > > > > > And we could then start trimming the table we do have as well, to > > > > reclaim space? > > >=20 > > > In general, yes, but we'd also need to consume a bit more space with > > > the > > > additional auto-detection logic. > >=20 > > Maybe part one of the series is backport that logic, part two is remove > > all the easy to remove tables? Or at least a number of them so the > > series is a wash and then a targeted series of drop-an-entry and cc the > > person that added it so they can run-time verify it's still fine? >=20 > Sounds like a plan to me and I'm willing to work on that. Though, I think > we'll inevitably end up with increasing the resulting image sizes a bit, = but > that might be an acceptable trade-off for making supporting more SPI chips > and more new boards much easier in the future. Yeah, this is where we need to go overall long term if nothing else. --=20 Tom --PhclFjmZha0vVzIe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmV02jsACgkQFHw5/5Y0 tyw3Mwv/ecYW0OWuokbkW8/K58T7E8bbI/aWUEdOK9lW3CfWQPKzaQaSJCHsGqy6 EFXoLOWHQvf9G65o7rebB9hzJ7sUEHAKT4JvdhRbSqH3yv78/JkWdFxs0fEcK9j7 wAmJxLagyQT2RgDzyLsUuAzzTJ83cw+XCwrx6Jmd0ilCtMd++chs7lBkAAYUwxh0 O3ym4E+C1AUovD4pdtvRWr8Wde3zSt9AveOnIpiOztfX8tPtNVs+fYPGtsh5wvTW 8XbvGj8yMAtRKKjFlEdPmS/KbJKfoEgCkMgD76tZHV/0eoMf/cX+kf971/zVJzEx 1WzSmDHxXt7pMTQoRAGCtnWSyeLdPDYOHcVMxU4r1ITVJlqlxi/L9h3syYui+GI3 8ww3pK0CMZuKaNBka40BypClZsYh5bliIu1SaWGSya8EvqpsG0ArzKFy3qqATLgH 8ipQ3lG/Elgcsi46XBIJA5m2sCYlXb8G6y92qtg0E48zaF0CdB5AW8riSSA49yDX kWQ8IcOE =lDq2 -----END PGP SIGNATURE----- --PhclFjmZha0vVzIe--