Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0ED19C46CD2 for ; Wed, 27 Dec 2023 12:25:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 701DC877D9; Wed, 27 Dec 2023 13:25:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="DJhoWmrv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 03E3187811; Wed, 27 Dec 2023 13:25:33 +0100 (CET) Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 605A0877B1 for ; Wed, 27 Dec 2023 13:25:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=nm@ti.com Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3BRCPHgN042045; Wed, 27 Dec 2023 06:25:17 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1703679918; bh=7PtLhf3grooIp9KxmwLoLHzBEImDZxgKVHdrp6T/Wx0=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=DJhoWmrvz9pqUz6FeFp+9mBPoUZWGVjaPkhXanCfEadRVZWhbMgjsdyS0+xEKYLr6 oB/D6DuXCzW6BG4/ardnI4xRLNBZLzc5QmkkkGDtgsBP2SPgPBKThZGLumo+pfhPU2 PSr1eDTOXHvWunFs26sEEAFswZqySUQeCBlTfbVM= Received: from DLEE111.ent.ti.com (dlee111.ent.ti.com [157.170.170.22]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3BRCPHan072890 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 27 Dec 2023 06:25:17 -0600 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 27 Dec 2023 06:25:17 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 27 Dec 2023 06:25:17 -0600 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3BRCPHdi017422; Wed, 27 Dec 2023 06:25:17 -0600 Date: Wed, 27 Dec 2023 06:25:17 -0600 From: Nishanth Menon To: Bryan Brattlof CC: Tom Rini , UBoot Mailing List , Vignesh Raghavendra , Andrew Davis , Neha Malcom Francis , Manorit Chawdhry , Martyn Welch , Svyatoslav Ryhel , Marcel Ziswiler , Simon Glass Subject: Re: [PATCH 12/26] arm: dts: k3-am654: add needed regs to udmap nodes Message-ID: <20231227122517.ph565albc5ktut4l@blast> References: <20231221174412.210807-1-bb@ti.com> <20231221174412.210807-13-bb@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231221174412.210807-13-bb@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 11:43-20231221, Bryan Brattlof wrote: > Ethernet is one of a few IPs in U-Boot that depend on DMA to operate. > However there are a few missing registers ranges in the udmap nodes > need to properly setup DMA for the am65x. > > A fix has been added to the Linux kernel[0] to add these ranges however > they have not made it to a Linux tag. To keep DMA operational until the > next DT sync from Linux, add these ranges to the *-u-boot.dtsi with a > note for our future selves. > > [0] https://lore.kernel.org/r/20231213135138.929517-2-vigneshr@ti.com > Signed-off-by: Bryan Brattlof > --- > arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 32 ++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm/dts/k3-am654-base-board-u-boot.dtsi b/arch/arm/dts/k3-am654-base-board-u-boot.dtsi > index 9cd8c353c515b..645241da322a5 100644 > --- a/arch/arm/dts/k3-am654-base-board-u-boot.dtsi > +++ b/arch/arm/dts/k3-am654-base-board-u-boot.dtsi > @@ -260,3 +260,35 @@ > &mcu_r5fss0 { > ti,cluster-mode = <0>; > }; > + > +/* The DMA driver requires a few extra register ranges > + * which are missing for the am65x. A patch has been > + * sent and will be synced after the v6.8-rc1 linux > + * tag is published > + */ Please fix multi-line comment style: /* * blah blah */ instead of /* blah blah * more stuff */ > +&main_udmap { > + reg = <0x0 0x31150000 0x0 0x100>, > + <0x0 0x34000000 0x0 0x100000>, > + <0x0 0x35000000 0x0 0x100000>, > + <0x0 0x30b00000 0x0 0x10000>, > + <0x0 0x30c00000 0x0 0x10000>, > + <0x0 0x30d00000 0x0 0x8000>; > + reg-names = "gcfg", "rchanrt", "tchanrt", > + "tchan", "rchan", "rflow"; > +}; > + > +/* The DMA driver requires a few extra register ranges > + * which are missing for the am65x. A patch has been > + * sent and will be synced after the v6.8-rc1 linux > + * tag is published > + */ and here. > +&mcu_udmap { > + reg = <0x0 0x285c0000 0x0 0x100>, > + <0x0 0x2a800000 0x0 0x40000>, > + <0x0 0x2aa00000 0x0 0x40000>, > + <0x0 0x284a0000 0x0 0x4000>, > + <0x0 0x284c0000 0x0 0x4000>, > + <0x0 0x28400000 0x0 0x2000>; > + reg-names = "gcfg", "rchanrt", "tchanrt", > + "tchan", "rchan", "rflow"; > +}; > -- > 2.43.0 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D