Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A7BFC3DA6E for ; Thu, 28 Dec 2023 20:32:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A350087A75; Thu, 28 Dec 2023 21:32:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Uqpdd6nu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0905687A72; Thu, 28 Dec 2023 21:32:16 +0100 (CET) Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C6CA887A08 for ; Thu, 28 Dec 2023 21:32:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-5c85e8fdd2dso53822577b3.2 for ; Thu, 28 Dec 2023 12:32:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1703795532; x=1704400332; darn=lists.denx.de; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ua/+LSP8qEmi8u8U7bui2a7+7/ZLwmw7r0Rdiu5I8po=; b=Uqpdd6nugPIDboM5cck989mmMoxWgleL3McVR3NIVZZ7/0jezxHl9nnbKF1UVqlci0 BcayI/j7h2JQvjmb75BF/vVf0IQ8PFQwFTVRQMimWYdag80hoMNpKfyoshcEAEaOkYX/ iAJmseGzuHrnCZ/k75zIwtCXADgl731wtVYDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703795532; x=1704400332; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ua/+LSP8qEmi8u8U7bui2a7+7/ZLwmw7r0Rdiu5I8po=; b=KJawAjQenWeNZ/EzJjH1V92H3qqbUjIh9+JZ77vSr+AuakDYrtVHcwGEYBgYWncFxX 5glV4u4KZe8rHP1OW9CWSo01E3Nqgu7QcgTu91IKp0PujBMGJZ9vkRhkXFA4vzoq7lTD WFrWHIyeQ6wcawSDpyKfHt6IuNHgrO5B/BeRdInTEDuNjLMFX/gGBqfqym2lZ1gGJ78V J03aX3UZ9nNJhlBC2oh5uLOrxGLt3MkswxrtNV1Yr2mM63KgcEa5PlM8+vDkP/RgDokk 3vAs0Y8Ua0NO92lAJGiNWTV3rq9gdfmvyFeDBvQ7Py4JTZJMKqCBuP64PeT2turGqVje MQFg== X-Gm-Message-State: AOJu0YyvCIVLr/On4ND/NFVHzGGqubM8mP2zVyK9E5qSoKhpAtQfjrXA 0lKDnLm2hA+T6iUlZX1lLcS/Ixf2fHCCVw== X-Google-Smtp-Source: AGHT+IHPeVjLgZTrEOkYORx4qXd+LcJftuRMb8Y1Kko3UshK1j15ZlxbE3hq9D7qOeB7YpyIQOKJVw== X-Received: by 2002:a81:4c95:0:b0:5ec:2eb3:e80e with SMTP id z143-20020a814c95000000b005ec2eb3e80emr3640247ywa.1.1703795532524; Thu, 28 Dec 2023 12:32:12 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-3119-0000-0000-0000-1001.res6.spectrum.com. [2603:6081:7b00:3119::1001]) by smtp.gmail.com with ESMTPSA id a128-20020a0df186000000b005c5a08c5c15sm7789805ywf.136.2023.12.28.12.32.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Dec 2023 12:32:11 -0800 (PST) Date: Thu, 28 Dec 2023 15:32:09 -0500 From: Tom Rini To: Simon Glass Cc: Sumit Garg , u-boot@lists.denx.de, u-boot-amlogic@groups.io, u-boot-custodians@lists.denx.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor@kernel.org, neil.armstrong@linaro.org, caleb.connolly@linaro.org, ff@shokubai.tech, daniel.thompson@linaro.org, dgilmore@fedoraproject.org, pbrobinson@gmail.com, ilias.apalodimas@linaro.org, maxim.uvarov@linaro.org, b.galvani@gmail.com, xypron.glpk@gmx.de, michal.simek@amd.com, seanga2@gmail.com, rasmus.villemoes@prevas.dk, peng.fan@nxp.com, jh80.chung@samsung.com, rfried.dev@gmail.com, marex@denx.de, mibodhi@gmail.com Subject: Re: [PATCH v3 7/8] dts: meson-gxbb: Switch to using upstream DT Message-ID: <20231228203209.GP2652760@bill-the-cat> References: <20231228115804.3626579-1-sumit.garg@linaro.org> <20231228115804.3626579-8-sumit.garg@linaro.org> <20231228135642.GA2652760@bill-the-cat> <20231228152504.GF2652760@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rRyu3akwzoxGppym" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --rRyu3akwzoxGppym Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 28, 2023 at 07:48:13PM +0000, Simon Glass wrote: > Hi Tom, >=20 > On Thu, Dec 28, 2023 at 3:25=E2=80=AFPM Tom Rini wro= te: > > > > On Thu, Dec 28, 2023 at 03:09:41PM +0000, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, Dec 28, 2023 at 1:56=E2=80=AFPM Tom Rini = wrote: > > > > > > > > On Thu, Dec 28, 2023 at 01:37:11PM +0000, Simon Glass wrote: > > > > > Hi Sumit, > > > > > > > > > > On Thu, Dec 28, 2023 at 11:59=E2=80=AFAM Sumit Garg wrote: > > > > > > > > > > > > Although there were still some variations in board DTS files ba= sed on > > > > > > meson-gxbb SoC but I think those were minor differences from up= stream > > > > > > and shouldn't impact boot on these devices. > > > > > > > > > > > > So switch to upstream DT via mirroring amlogic/ directory from > > > > > > devicetree-rebasing/src/arm64/amlogic/ directory. And thereby d= irectly > > > > > > building DTB from there including *-u-boot.dtsi files from > > > > > > arch/$(ARCH)/dts/ directory. > > > > > > > > > > > > Reviewed-by: Neil Armstrong > > > > > > Signed-off-by: Sumit Garg > > > > > > --- > > > > > > > > > > > > Changes in v3: > > > > > > -------------- > > > > > > - Dropped Makefile portion and enabled OF_UPSTREAM for SoC inst= ead. > > > > > > > > > > > > Changes in v2: > > > > > > -------------- > > > > > > - Picked up review tag > > > > > > > > > > > > arch/arm/mach-meson/Kconfig | 1 + > > > > > > configs/nanopi-k2_defconfig | 2 +- > > > > > > configs/odroid-c2_defconfig | 2 +- > > > > > > configs/p200_defconfig | 2 +- > > > > > > configs/p201_defconfig | 2 +- > > > > > > configs/videostrong-kii-pro_defconfig | 2 +- > > > > > > configs/wetek-hub_defconfig | 2 +- > > > > > > configs/wetek-play2_defconfig | 2 +- > > > > > > dts/arch/arm64/amlogic | 1 + > > > > > > 9 files changed, 9 insertions(+), 7 deletions(-) > > > > > > create mode 120000 dts/arch/arm64/amlogic > > > > > > > > > > > > > > > > Reviewed-by: Simon Glass > > > > > > > > > > > diff --git a/arch/arm/mach-meson/Kconfig b/arch/arm/mach-meson/= Kconfig > > > > > > index d6c89058061..8ddb59161a0 100644 > > > > > > --- a/arch/arm/mach-meson/Kconfig > > > > > > +++ b/arch/arm/mach-meson/Kconfig > > > > > > @@ -25,6 +25,7 @@ choice > > > > > > config MESON_GXBB > > > > > > bool "GXBB" > > > > > > select MESON_GX > > > > > > + imply OF_UPSTREAM > > > > > > help > > > > > > Select this if your SoC is an S905 > > > > > > > > > > > > diff --git a/configs/nanopi-k2_defconfig b/configs/nanopi-k2_de= fconfig > > > > > > index 41dbf7981f8..2e1c756bf7a 100644 > > > > > > --- a/configs/nanopi-k2_defconfig > > > > > > +++ b/configs/nanopi-k2_defconfig > > > > > > @@ -6,7 +6,7 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=3Dy > > > > > > CONFIG_CUSTOM_SYS_INIT_SP_ADDR=3D0x20000000 > > > > > > CONFIG_ENV_SIZE=3D0x2000 > > > > > > CONFIG_DM_GPIO=3Dy > > > > > > -CONFIG_DEFAULT_DEVICE_TREE=3D"meson-gxbb-nanopi-k2" > > > > > > +CONFIG_DEFAULT_DEVICE_TREE=3D"amlogic/meson-gxbb-nanopi-k2" > > > > > > CONFIG_OF_LIBFDT_OVERLAY=3Dy > > > > > > CONFIG_DM_RESET=3Dy > > > > > > CONFIG_DEBUG_UART_BASE=3D0xc81004c0 > > > > > > > > > > So now I am wondering if we can (later) have the SoC be implied w= hen > > > > > using OF_UPSTREAM so we can do: > > > > > > > > > > CONFIG_DEFAULT_DEVICE_TREE=3D"meson-gxbb-nanopi-k2" > > > > > > > > > > and it will add the 'amlogic/' automatically? > > > > > > > > > > Perhaps that might be a way to bridge the gap in terms of file la= yout? > > > > > > > > That's going to start to look real ugly real quick I suspect and I'= m not > > > > sure what it really gets us? It seems to me that the convention of > > > > "vendor/board" has already been well enough adapted outside of the > > > > kernel, with the odd sticking point being getting everyone used to > > > > whatever will be happening for 32bit boards long term. So I think h= iding > > > > the vendor part of the string here will be more, not less, confusing > > > > long term. > > > > > > Now that I dig in a bit, I see that the devicetree-rebasing tree does > > > not have any Makefiles in it. How does Linux build with it? Does > > > anyone have instructions? > > > > Linux doesn't build with it, it's the relevant parts of the kernel tree > > extracted for other projects to more easily use (more or less). >=20 > Hmmm, in that case can we add Makefiles into the U-Boot version of the > tree, for U-Boot use? No? Why would we do that? I think you're missing how the amlogic conversion works. --=20 Tom --rRyu3akwzoxGppym Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmWN20kACgkQFHw5/5Y0 tyxMJQv7Bc09zQHFh6GMjIEM5tOgzRQv4OYN+BE/wpHovFZ7N3oA01K4KpGzGXFo qwTrJaaj0VOE6N9BruRrlMwMdxBycJonbDh/74tt2DHXUra9fEdim2BxAFwpJ3ki jGbdAKTqtaZ6xSbBA3o6qea3owsOAey6yjp55Bxq4jOJ9+YCl6ltSo3B16TpvP+x qe+sKdmYLqfeVdxiWSidCgA7hRDekEb9cIIyhjvECtE+TzKdUxA3L4tTfAXVfNQI pHcl2vxsFpqAtOXP3MXGiHis4DDBspdz7cN8eGyAANWhoKue4xELak4+PPYELr2P iAKmgb9wtgP+ZiMewsiP6XcFwlFTRqVTMqgL7X0wFHwku/CRbf8+Pk7y2F3kcfaJ 60fCNWte+Q/YiH+FOs0P/Jf8p0U0HDuYuzdGiHJackeXMHziBIhZIwUz5TSoZR0i NcdNArshrJiGtmjKhACe3XocAoFFg8cYWEduIuACTbJbjDHcAuH3BZpvVlNHJhIU +nq5JM7k =Za0o -----END PGP SIGNATURE----- --rRyu3akwzoxGppym--