Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FCE0C47079 for ; Fri, 5 Jan 2024 08:01:38 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id C627B2CADE for ; Fri, 5 Jan 2024 08:01:35 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id AD23C986602 for ; Fri, 5 Jan 2024 08:01:35 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id A040B9865D6; Fri, 5 Jan 2024 08:01:35 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 9305C9865D9 for ; Fri, 5 Jan 2024 08:01:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WDiPin9nXwVhb1iwICONUNLfPtLXaGk7UIo68TmDnJG+S/8eGVYR+dpTPIM7P+GPugyrRwh7GuWuIkvpKC8mHHLc0zQ/jLn50ZJnuf1ABxZIwoE1iDqWzdm1WvZpZweurcGW7cKuo1S3sPLBhW9yC9bDiJmYXLcLeRg2LRswBqEGhWpOKeNt58eAI0zbmsGznQxsohXJkYu1sDShBSlo6AuFWAEI7bpGy8HgVevYwlwHOkb058MX/rwnGxVGc+tnXXeTxJjeaaytYLdv3hnht0NB1j5y1uUEEaZX2rNhDzRY1dkYevI3727ZKxvoMVG1/T7/pxJ418R90Od/ti8cDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GQtF1uUnXlfTFmAEhMRomSiJ3r4Ku7GB87n9ftblCk8=; b=ZkcbPjLeyH8A5npTiaSIfQRFuKN1aMXGvJyYgUHEXkcyVL9E/vZKg81lKAtJuG7+lxuWz70QVIrKF1puK/XQhQro7WxRY5zX7/t8B6u5S9zrGV1FvfAADFaQ7KDsaiiLy8TusaRB2/z5EdpK+FkJ3Vh9JkBI9A5HvEHXgZmuYg7PKfKtCbmU0PnOiOW+OWKqsqQkLoYa1A7tqOBp9QK4KftOWACCaX1lX+KzbVDgbuDKT4YRyRIuqoTts2ICI0JX6KHGHkzd8Ztsv1MXhc+o8lVquddnhRnBkd/s2zPrShel+xWE1PE5rk+TL1xbu9RkwNPhRLJb6N3claXV7CTbuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=lists.oasis-open.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C From: Parav Pandit To: , , CC: , , , Parav Pandit Date: Fri, 5 Jan 2024 10:00:55 +0200 Message-ID: <20240105080055.3459531-3-parav@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240105080055.3459531-1-parav@nvidia.com> References: <20240105080055.3459531-1-parav@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F4:EE_|CY5PR12MB6406:EE_ X-MS-Office365-Filtering-Correlation-Id: f59cbbbc-1240-4039-7848-08dc0dc487c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E1iYHt0l36o0i2xy/iqIpBHMRX1VNVppMgYF0t1+PlYdhkwh7Vzu7Xb9GmRp6lI2y+DH2Mx/xr3FOmjT9ug2GBcqRFM6LpXRBi2YUjkey+o+moTmp/fipdsEawKCCCmrzK0UnvGGavBQuRPDm3ckFkx1CqAgcU2kWwRPp2yYzlLzrB3gPB1g6dXkW0tbABAKNwwz/4bofSdjUL2yezb6OlbXoozLFZGzGRTKPnrbJDyTE4zu7+9NDXzHmJoAOQ83nBGbWmbjSesSi7qyKhBERvEJmy8GVeJt4t2x0cUNkhHKpb8PAyLo1LfzGgtts/dslplZbP9h2DaFQeqtI4isxPnfu8ti/OzsqeMsfXfp8wTInX1bDX1EbdFtua6+10GRMj5iD+Nx5942ZK9SuVIDXBN9KfOHqDf2yODJIB36+bjNy8oxntRuKyhp5MA6ZSCeQO1dyjzN+GfYqztYBi57PkJvLOF83v0wrVbmnaAP7zTdZczUg2gxjCrC8B7P2tXuZHIp7ZIdOM09qYUiBht7Zg9kRBzkZ+FNgkdZ1iTj4LU0Az+sCicaA5YhT+DCMJnRSyPR7dLZI8Ljlj+AGWT0oSXxYXnT0Meo4cj8J51cdbm0GZIr7h9n6ghLZxCZqHgzVoiymdiA8lLzvv+OFogycueoZ9jSOGGo5Jb1WA7G42SS/6PterPAgZ4iQZOA3h5A0OGqQcQ5tOzmwAZ8a9lVPPbCxNtmAEDxHmIdL+i/DM/NsZKa8RpuTEVdQ7PTYdwVQtErCxRsvyJhu+HJ0uf+lDSKQdc8PsYBu0mjBlWgvao= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230031)(4636009)(346002)(136003)(396003)(376002)(39860400002)(230922051799003)(186009)(82310400011)(1800799012)(64100799003)(451199024)(36840700001)(46966006)(40470700004)(2906002)(4326008)(36860700001)(8936002)(47076005)(8676002)(5660300002)(36756003)(82740400003)(7636003)(356005)(41300700001)(6666004)(2616005)(478600001)(1076003)(26005)(336012)(426003)(966005)(316002)(107886003)(54906003)(70586007)(16526019)(110136005)(70206006)(40480700001)(40460700003)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 08:01:32.1709 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f59cbbbc-1240-4039-7848-08dc0dc487c9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F4.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6406 Subject: [virtio-comment] [PATCH v1 2/2] virtio-net: Clarify the size of the struct virtio_net_hdr for tx The feature VIRTIO_NET_F_HASH_REPORT only applies to the receive side. However, when VIRTIO_NET_F_HASH_REPORT feature was introduced, it was not clarified that the size of the struct virtio_net_hdr on the packet transmission also uses higher size when VIRTIO_NET_F_HASH_REPORT is negotiated. Explicitly clarify this. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/183 Signed-off-by: Parav Pandit --- changelog: v0->v1: - addressed comments from Xuan to rewrite tx normative --- device-types/net/description.tex | 3 +++ 1 file changed, 3 insertions(+) diff --git a/device-types/net/description.tex b/device-types/net/description.tex index a1f40f7..d86beee 100644 --- a/device-types/net/description.tex +++ b/device-types/net/description.tex @@ -528,6 +528,9 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De \drivernormative{\paragraph}{Packet Transmission}{Device Types / Network Device / Device Operation / Packet Transmission} +The driver MUST use the same size of the field \field{struct virtio_net_hdr} +for transmit and receive packet buffers. + The driver MUST set \field{num_buffers} to zero. If VIRTIO_NET_F_CSUM is not negotiated, the driver MUST set -- 2.34.1 This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/