Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [91.216.245.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9875E4F8B5 for ; Wed, 10 Jan 2024 22:57:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=strlen.de Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1rNhVy-0003YU-Bu; Wed, 10 Jan 2024 23:57:38 +0100 Date: Wed, 10 Jan 2024 23:57:38 +0100 From: Florian Westphal To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org, fw@strlen.de Subject: Re: [PATCH nft 4/4] Revert "datatype: do not assert when value exceeds expected width" Message-ID: <20240110225738.GB28014@breakpoint.cc> References: <20240110194217.484064-1-pablo@netfilter.org> <20240110194217.484064-5-pablo@netfilter.org> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240110194217.484064-5-pablo@netfilter.org> User-Agent: Mutt/1.10.1 (2018-07-13) Pablo Neira Ayuso wrote: > # nft -f ruleset.nft > ruleset.nft:3:28-35: Error: expression is not a concatenation > ip protocol . th dport { tcp / 22, } > ^^^^^^^^ > > Therefore, a852022d719e ("datatype: do not assert when value exceeds > expected width") not needed anymore after two previous fixes. We can't rely on the expression soup coming from nftables.