Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A892548E0 for ; Thu, 22 Feb 2024 19:06:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708628790; cv=none; b=cP6X0M+XM4TX2bWo7ZXqmR+v/S4LS0lkSXGyPgbeqUGXwqm6QBkaepvj1GuN+KrEJyyBZC+eioGF77fB05X0TxUEygRLcH0HbAI+0E9j9bWC5Hp8I5G5u2WK4G8V/AumlV/xIsBnoeI2CL+nBEgO8WEsDUA3TPBtdguUb784P+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708628790; c=relaxed/simple; bh=nieUYnH4dj1j92uddbXN4kJMJyMCVisTdazPsZdBPn8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=HO6+oUoPsIBJXSCOfI9TuWQ7JrRf/PqdgCFAWz+/+9bfz+pDAgyp5IUeSjzlREFG49zHyPVnMUTtkbROD6MG42VJMxMvtsPVAP7tSrmdAm7p0x419vjcydKNnFhiJPvqf6K6f+YFnNRzXH4zt7wnvAk2DM0kgwmhrmd/JJp3c/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=K+Kfykx9; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="K+Kfykx9" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-6047a047f58so1000517b3.3 for ; Thu, 22 Feb 2024 11:06:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708628777; x=1709233577; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=3ntMGhr684dTjFjW5K9N11e4M8SUGzq3A8ac/2w/QBo=; b=K+Kfykx9Hq+ykAkYNd4G4I85Sjt9YcnQ4siJNsHr2te3tcKrZdZllffe8rBFSIkLGd BDQ/C1Ay+W8/Tz91cWU6OofJ1tfDPEY5XDXXst0d/jsBYrT65Pnp5H+z4bYxI2aoaFD5 w7d8Dcz7zTbdxZMQs5bzoVTeLyRO0dqIlL1ZsKo86ueEB9bDD2E3QFR9mlte87HADtBt aKzT1cX3xQN80xT53oxMNGPaDp2KDzNKfovzwIxbz9JKm1iNQfgK5GroprazRUXK2S8j VqBeCRPvPa2jRrfFbvA7+bW1R8O8qSUF77rm24zvjQRIwodF8TFWc0vaBXMzLoARdZ5U RNnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708628777; x=1709233577; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3ntMGhr684dTjFjW5K9N11e4M8SUGzq3A8ac/2w/QBo=; b=Qk1xC/yDKD8oCzUTmf40AVc8T5SaGUcMM48uk5/u1B6LZ/LWTRCm3FQvMTKLW3DTB+ njDfyZJdplzTQajraH15i2NtlvZtwRum8uB7tPyuJyHeR+b3EFN/AxJXYv7VyhaXqX5L uITw8j88Ppmp1xyHJPxilr9ZigjMwtQnu564vGCRPiIJ0ZgoIi/T+NV/tbIW0nynKo8V NcJ8RLfmKER3DxUxeZsTcm7R/O21KkR4TICe43uoX4dJaJaUixEUwDy8LPfScIVYejtT 5sUNYim1je9r5D1pJ7gs/e0ECanPHAbtQs1sllcufhF5wb3ulqVDTgESMA/F+5kCYSKb YMuQ== X-Gm-Message-State: AOJu0YzHSoSRBR1aRkJI6E5DFMqBO7BoQsVjXYBiOjW3BLvOk6w6Kztc VMKmOnjigsjNoF3enkLwxsIMlulgDsY8wOpYHhfTHgWBgyfoGAsV4f5Sbi9zfvl1nC9oe/y/NcO QGQ== X-Google-Smtp-Source: AGHT+IGJTwZNTDdlTJ5vrQNg9sqTJ09fKYXStOw2msJafDEAYLjbX78aWrh79pmG9gxDUQhCFn+wShlhb8g= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:160b:0:b0:dc7:7ce9:fb4d with SMTP id 11-20020a25160b000000b00dc77ce9fb4dmr5036ybw.12.1708628776828; Thu, 22 Feb 2024 11:06:16 -0800 (PST) Reply-To: Sean Christopherson Date: Thu, 22 Feb 2024 11:06:08 -0800 In-Reply-To: <20240222190612.2942589-1-seanjc@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240222190612.2942589-1-seanjc@google.com> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog Message-ID: <20240222190612.2942589-2-seanjc@google.com> Subject: [PATCH 1/5] KVM: Make KVM_MEM_GUEST_MEMFD mutually exclusive with KVM_MEM_READONLY From: Sean Christopherson To: Paolo Bonzini , Sean Christopherson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Fuad Tabba , Michael Roth , Isaku Yamahata , Yu Zhang , Chao Peng Content-Type: text/plain; charset="UTF-8" Disallow creating read-only memslots that support GUEST_MEMFD, as GUEST_MEMFD is fundamentally incompatible with KVM's semantics for read-only memslots. Read-only memslots allow the userspace VMM to emulate option ROMs by filling the backing memory with readable, executable code and data, while triggering emulated MMIO on writes. GUEST_MEMFD doesn't currently support writes from userspace and KVM doesn't support emulated MMIO on private accesses, i.e. the guest can only ever read zeros, and writes will always be treated as errors. Cc: Fuad Tabba Cc: Michael Roth Cc: Isaku Yamahata Cc: Yu Zhang Cc: Chao Peng Fixes: a7800aa80ea4 ("KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory") Signed-off-by: Sean Christopherson --- virt/kvm/kvm_main.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index eb0dfcd157f4..0f9f78f4f7cf 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1617,7 +1617,13 @@ static int check_memory_region_flags(struct kvm *kvm, valid_flags &= ~KVM_MEM_LOG_DIRTY_PAGES; #ifdef CONFIG_HAVE_KVM_READONLY_MEM - valid_flags |= KVM_MEM_READONLY; + /* + * GUEST_MEMFD is incompatible with read-only memslots, as writes to + * read-only memslots have emulated MMIO, not page fault, semantics, + * and KVM doesn't allow emulated MMIO for private memory. + */ + if (!(mem->flags & KVM_MEM_GUEST_MEMFD)) + valid_flags |= KVM_MEM_READONLY; #endif if (mem->flags & ~valid_flags) -- 2.44.0.rc0.258.g7320e95886-goog