Received: by 2002:a17:906:489:b0:a44:3ba0:e9d1 with SMTP id f9csp290853eja; Thu, 29 Feb 2024 02:23:24 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUGQIfS5KkASu3+PLDFobg17BsnZW0ndpoJJq0p1ElwpmCWJtUsp7zZMPF3v9LKlSdBkEU0T3rSR8ifOvhMc169vi+h9hsR X-Google-Smtp-Source: AGHT+IH8GbHrICQQn4XGbUGeOtnf2X5r62SuBxxYzbnQtgRb42pRbY1PHqN6SIBFbmnQnV+CPO6J X-Received: by 2002:a1f:ed43:0:b0:4d3:2f29:fdf4 with SMTP id l64-20020a1fed43000000b004d32f29fdf4mr1499075vkh.2.1709202203998; Thu, 29 Feb 2024 02:23:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1709202203; cv=none; d=google.com; s=arc-20160816; b=ux/XEHC9aQ4p6NL6PE8D4h6Pxg99yyLr7t2phhmSCBKuAylGOfkwN+xrA4ikZUydyl ZO36ivtpf2FUOThJQZu6FEXdooroM1OTaAZGTTMhphxhcF3OFG3mTMdKyJ01hVnnmxlx MFO69bvGsxBZAG5GVY4SQnAjRnGQgHLH/Bapc1h5iF8zIvMVqF4wZwBL517mkvsSsu9w kMmes7HqXhB4OxUhX/QQksvK5w3+EbI/B3KbiKpgz4KF4BqRfqmvWKYru8fegqj8Yxur UUWfUALaLAL96TC73AP853jiKRpWXf1DwatwC4GcmLtEoDzpQwXGaxZyTeHG52iKXVGF NVJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:from:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:date; bh=nHi70kko3TylY9Lb2wfs8L8OS0N4q7b3Cj3nGYvJ47c=; fh=kHLsR3jjhMqS3cla2gydHFs9zLFbxmJgpnxriC7JI/Y=; b=NXVoTvP4SAB5eFkUvZZEQg3P397iQdlrW740YbB8shaewhllFupSRugqfK5Rq5ZC0c 640gOGws5o09+WXpvTqqB/U4dDZCRC4RLPoHUUtX/8XX0fKJTemM6zrjOPrjcZWGotNU Z1768HIqRK5BwsPb5NotRF/Wj0sSyLYcBVC8yplX9Ozv/Qc0vvUG6WXaMR4/4sz+PzJD o6hz9QMn6Bcqu5T8ObqMbdFj7BtvzYIOJOqZLHP/LegwB2iLgBju6jEaY6fXFvKBjyKC jdOr4U446NkNFMkrsBImsyddePgL6j/0Ge+JtwcTEBwTeB6BO6eVC6CqVoOTgXR+V1HS 71YA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t25-20020ac865d9000000b0042e6e43d5f5si998054qto.629.2024.02.29.02.23.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Feb 2024 02:23:23 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nongnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rfdZ0-0005ti-M9; Thu, 29 Feb 2024 05:22:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfdYy-0005t3-Pc; Thu, 29 Feb 2024 05:22:52 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfdYw-0003kS-92; Thu, 29 Feb 2024 05:22:52 -0500 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TlnH11gCjz6K65v; Thu, 29 Feb 2024 18:18:05 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id EC0DC140A35; Thu, 29 Feb 2024 18:22:32 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 29 Feb 2024 10:22:31 +0000 Date: Thu, 29 Feb 2024 10:22:30 +0000 To: Ankit Agrawal CC: Markus Armbruster , Jason Gunthorpe , "alex.williamson@redhat.com" , "clg@redhat.com" , "shannon.zhaosl@gmail.com" , "peter.maydell@linaro.org" , "ani@anisinha.ca" , "berrange@redhat.com" , "eduardo@habkost.net" , "imammedo@redhat.com" , "mst@redhat.com" , "eblake@redhat.com" , "david@redhat.com" , "gshan@redhat.com" , Zhi Wang , Matt Ochs , "pbonzini@redhat.com" , Aniket Agashe , Neo Jia , Kirti Wankhede , "Tarun Gupta (SW-GPU)" , Vikram Sethi , "Andy Currid" , Dheeraj Nigam , Uday Dhoke , "qemu-arm@nongnu.org" , "qemu-devel@nongnu.org" Subject: Re: [PATCH v7 1/2] qom: new object to associate device to numa node Message-ID: <20240229102230.00004277@Huawei.com> In-Reply-To: References: <20240223124223.800078-1-ankita@nvidia.com> <20240223124223.800078-2-ankita@nvidia.com> <8734td3uty.fsf@pond.sub.org> <20240228135504.00005d12@Huawei.com> <87bk80vaft.fsf@pond.sub.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100005.china.huawei.com (7.191.160.25) To lhrpeml500005.china.huawei.com (7.191.163.240) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: CX3yVieHqJAj On Wed, 28 Feb 2024 16:50:30 +0000 Ankit Agrawal wrote: > >>> Jonathan, you pointed out interface design issues in your review of v2.> > >> Are you fully satisfied with the interface in v3? > >> > >> Yes. I'm fine with the interface in this version (though it's v7, so I'm lost > >> on v2 vs v3!) > > > > Looks like I can't count to 7! > > > > With NUMA capitalized in the doc comment, QAPI schema > > Acked-by: Markus Armbruster > > > > Thanks! > > Thanks! Will fix that in the next version. The following is really me arguing with myself, so can probably be ignored, but maybe it will spark an idea from someone else! One trivial tweak that might make our life easier if anyone adds support in the future for the other device handle type might be to go with simply dev rather than pci-dev. There is a sticky corner though if a device is a PCI device and in ACPI DSDT so maybe we are better off adding acpi-dev to take either pci-dev or acpi-dev? Annoyingly for generic ports, (I'm reusing this infrastructure here) the kernel code currently only deals with the ACPI form (for CXL host bridges). Given I point that at the bus of a PXB_CXL it is both a PCI device, and the only handle we have for getting to the Root Bridge ACPI handle. So I think I've argued myself around to thinking we need to extend the interface with another optional parameter if we ever do support the ACPI handle for generic initiators :( Jonathan