Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F6C7C54798 for ; Sat, 9 Mar 2024 12:02:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rivOf-0006Ji-Qo; Sat, 09 Mar 2024 07:01:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rivOd-0006Iq-KA for qemu-riscv@nongnu.org; Sat, 09 Mar 2024 07:01:47 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rivOc-00031t-1e for qemu-riscv@nongnu.org; Sat, 09 Mar 2024 07:01:47 -0500 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-55a5e7fa471so2052912a12.1 for ; Sat, 09 Mar 2024 04:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1709985704; x=1710590504; darn=nongnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RJqc3GVHJNhinJapfRd05vALzWAJlTFCioGI0MWgKzc=; b=cyLx2cEagYfZmi4mfB37w0mBr5RQLOF1gDiq+oKM/X2DZThtcuYQYDvHDpVKA/F8vn Pboy3pbJD/IPLuBCINL0VdaVEaUc2+Y4vup/dSkf5yrRRf0uV8t9miR4LZbL8hinFJv+ ScjS0EsxutRa9MbqlZ6UExBeQC8DnRuyUlbt9amGHq0hx5CVRtuyM1L5uCF5uLrtuCjo 3A0GuRjsPzFoj8utQcxJiOixza+gbdeTq7XdK2FrnluwKoANoYCfYh85r+L5valYDDUn ZBRNm2M0HCtKuH46bEwOWmHbLt7iZPf4b7iEXNsnfRlkm9WPK6JeK8TyI5inplEHrVVc Q8Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709985704; x=1710590504; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RJqc3GVHJNhinJapfRd05vALzWAJlTFCioGI0MWgKzc=; b=wqrU9POKUijn/7ybCsjb4kYalFx+Rz5ttL27/OmSeEVXn3EY9R2D38NVgjZCiPIP34 ipK6c7UvGWiPtYl7GVGoH0QNH3IF1vr1xYbzt8g+NN6n1lfL0iKgjfAXEj3stLTMZbeo Nj3WgdHJyCkWaTeeAyIDqfL0NYb3cGUPkM8l8pe5XbyhuTeE5OL5kj0d/fjW0u0ZJslc VmJgM5p02+92uram74fXkJ+Uzljmy2pzMId5jqKqzBo/nPSf+OK/nz3YX6qorDWEBJHi FdjZyYN4KlC+N33loCFmz/Z5yusW3ubnG4rVK2HoVv3tH/DYzii9e/mStfYtJ/fVnPrx oeaA== X-Forwarded-Encrypted: i=1; AJvYcCXY3pwekXw1cLfepwh93ZJOJsfL09c0Lb782z/QKsFr0omt1DeiJmH3fouAN09ociD0RjB601JN7VZFCBRgEPlQFJzD8pQ= X-Gm-Message-State: AOJu0YxkEn07A3ICncLZh8dJhR3HtsaQgWLY8fGExr2DG//aX6ZVsqox nByRFUNce4V6T/rna80ZHkBuJKty81UzAjxJ4lJ2tGb4T3/rmcUKjE/jxbzC3V0= X-Google-Smtp-Source: AGHT+IEDSOSVCuoeolmQ50TK9YE2xZ8nTwcSl3/X5EjvSAuecZAGLp4x3E9QSi1uLGwnSNCY6mn9yA== X-Received: by 2002:a50:f681:0:b0:566:c388:ceb4 with SMTP id d1-20020a50f681000000b00566c388ceb4mr1268630edn.28.1709985703676; Sat, 09 Mar 2024 04:01:43 -0800 (PST) Received: from localhost (cst2-173-16.cust.vodafone.cz. [31.30.173.16]) by smtp.gmail.com with ESMTPSA id 9-20020a0564021f4900b00567e27c72c4sm798372edz.62.2024.03.09.04.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Mar 2024 04:01:42 -0800 (PST) Date: Sat, 9 Mar 2024 13:01:36 +0100 From: Andrew Jones To: Richard Bagley Cc: Palmer Dabbelt , qemu-devel@nongnu.org, qemu-riscv@nongnu.org, Alistair Francis , bmeng@tinylab.org, liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com, dbarboza@ventanamicro.com Subject: Re: [PATCH] disas/riscv: Further correction to LUI disassembly Message-ID: <20240309-ee813e971e7c5850d652b295@orel> References: <20230810-c9e1f2783168b48bc07a1aa2@orel> <20230810-e160f9edae60ded9d2606b8b@orel> <20230811-bc15b48d336b79d9ec1f0936@orel> <20230811-52e2c90dc3b91e108eb5e4e8@orel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=ajones@ventanamicro.com; helo=mail-ed1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On Fri, Mar 08, 2024 at 08:22:01PM -0800, Richard Bagley wrote: > post-nack, one further comment: > > One could argue that this change also aligns QEMU with supporting tools (as > Andrew observed), and it makes sense to merge this change into QEMU until > those tools update to supporting signed decimal numbers with immediates. > > As it is, both GNU assembler and the LLVM integrated assembler (or llvm-mc) > throws an error with examples such as > auipc s0, -17 > > On the other hand, I have only seen this problem with the output of the > COLLECT plug-in, not (as yet) with QEMU execution proper. > If the problem is confined to COLLECT, perhaps the argument for aligning > with other tools is not as strong. > > In the meantime, I have adjusted my change locally to include AUIPC, and > written a substantive, and I hope, clear commit description. > If you would like me to resubmit a patch with this updated change, please > let me know. Since the patch is ready for posting, then it might as well be posted (even if it may not get merged right away). If the issue arises again, then we can refer to the latest proposed patch, which will be preserved in the mail archives. Thanks, drew