Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D285F60DD8 for ; Wed, 13 Mar 2024 19:13:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710357186; cv=none; b=SRevKqmZB8uvKUe6JCW8McCNl6Lujgq2l/jISSeox1Mv2WCTwoOanmtbrL5GOKqJ7x1kne9DEbhMgIJuJK9l8r56Xo6xSH6CcuP2CfH/Gzetpzcn5DmytjdwC8QLaB8DkCRswa/J2oo6FYsfBVwbyYVoFOyo1BhayYIwssWwIXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710357186; c=relaxed/simple; bh=M8RD58/cNttAdCEHl7U2vt+aBLbX7RXRphQy+VgV3Q8=; h=Date:To:From:Subject:Message-Id; b=QiM4BPEgsBfiQj6HZRnrRyGn+jCV0Ln700Y6IXtOnDnlUkGdEkaW7MebEpFCzkfymhpGjMlX7O95/m8izF/D0pzK/EeBxetZYHPZpCFza20s8DtokVA/rSVvxrGLp1CQUNEYzaCSJJDR7wScrA5Nz1O+7kyNj1Ad3a6MPHlW5y8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=EwtZfYek; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="EwtZfYek" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54282C433F1; Wed, 13 Mar 2024 19:13:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1710357186; bh=M8RD58/cNttAdCEHl7U2vt+aBLbX7RXRphQy+VgV3Q8=; h=Date:To:From:Subject:From; b=EwtZfYekNSy0icpEpJ3/jL17yKf4pwtxKQLXif3K2AXsyd3dLHM9KjJRHpjG5NyJy qDREFN7VsQD8GpREHXHC/vAvTlGm3E0V60nRIvRGr69v9BrIhQ33x+daBO9yZhL1I0 7NE6H+6wNj0h75zkR5zW8fniVFx5ovy2p12N/olU= Date: Wed, 13 Mar 2024 12:13:05 -0700 To: mm-commits@vger.kernel.org,zhouchengming@bytedance.com,yosryahmed@google.com,vitaly.wool@konsulko.com,sjenning@redhat.com,nphamcs@gmail.com,herbert@gondor.apana.org.au,hannes@cmpxchg.org,ddstreet@ieee.org,davem@davemloft.net,chrisl@kernel.org,v-songbaohua@oppo.com,akpm@linux-foundation.org From: Andrew Morton Subject: [merged mm-stable] mm-zswap-remove-the-memcpy-if-acomp-is-not-sleepable.patch removed from -mm tree Message-Id: <20240313191306.54282C433F1@smtp.kernel.org> Precedence: bulk X-Mailing-List: mm-commits@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The quilt patch titled Subject: mm/zswap: remove the memcpy if acomp is not sleepable has been removed from the -mm tree. Its filename was mm-zswap-remove-the-memcpy-if-acomp-is-not-sleepable.patch This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm ------------------------------------------------------ From: Barry Song Subject: mm/zswap: remove the memcpy if acomp is not sleepable Date: Thu, 22 Feb 2024 21:11:35 +1300 Most compressors are actually CPU-based and won't sleep during compression and decompression. We should remove the redundant memcpy for them. This patch checks if the algorithm is sleepable by testing the CRYPTO_ALG_ASYNC algorithm flag. Generally speaking, async and sleepable are semantically similar but not equal. But for compress drivers, they are basically equal at least due to the below facts. Firstly, scompress drivers - crypto/deflate.c, lz4.c, zstd.c, lzo.c etc have no sleep. Secondly, zRAM has been using these scompress drivers for years in atomic contexts, and never worried those drivers going to sleep. One exception is that an async driver can sometimes still return synchronously per Herbert's clarification. In this case, we are still having a redundant memcpy. But we can't know if one particular acomp request will sleep or not unless crypto can expose more details for each specific request from offload drivers. Link: https://lkml.kernel.org/r/20240222081135.173040-3-21cnbao@gmail.com Signed-off-by: Barry Song Tested-by: Chengming Zhou Reviewed-by: Nhat Pham Acked-by: Yosry Ahmed Reviewed-by: Chengming Zhou Acked-by: Chris Li Acked-by: Johannes Weiner Cc: Dan Streetman Cc: David S. Miller Cc: Herbert Xu Cc: Seth Jennings Cc: Vitaly Wool Signed-off-by: Andrew Morton --- mm/zswap.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/mm/zswap.c~mm-zswap-remove-the-memcpy-if-acomp-is-not-sleepable +++ a/mm/zswap.c @@ -162,6 +162,7 @@ struct crypto_acomp_ctx { struct crypto_wait wait; u8 *buffer; struct mutex mutex; + bool is_sleepable; }; /* @@ -951,6 +952,7 @@ static int zswap_cpu_comp_prepare(unsign goto acomp_fail; } acomp_ctx->acomp = acomp; + acomp_ctx->is_sleepable = acomp_is_async(acomp); req = acomp_request_alloc(acomp_ctx->acomp); if (!req) { @@ -1078,7 +1080,7 @@ static void zswap_decompress(struct zswa mutex_lock(&acomp_ctx->mutex); src = zpool_map_handle(zpool, entry->handle, ZPOOL_MM_RO); - if (!zpool_can_sleep_mapped(zpool)) { + if (acomp_ctx->is_sleepable && !zpool_can_sleep_mapped(zpool)) { memcpy(acomp_ctx->buffer, src, entry->length); src = acomp_ctx->buffer; zpool_unmap_handle(zpool, entry->handle); @@ -1092,7 +1094,7 @@ static void zswap_decompress(struct zswa BUG_ON(acomp_ctx->req->dlen != PAGE_SIZE); mutex_unlock(&acomp_ctx->mutex); - if (zpool_can_sleep_mapped(zpool)) + if (!acomp_ctx->is_sleepable || zpool_can_sleep_mapped(zpool)) zpool_unmap_handle(zpool, entry->handle); } _ Patches currently in -mm which might be from v-songbaohua@oppo.com are