Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 507681353E2 for ; Wed, 3 Apr 2024 11:18:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.188.207 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712143121; cv=none; b=CVsH3athFlA6pP2FISiwLuRH70ytmGTR+8uG3rjgU7OLWbfJyuBRWFTEpuNC+7EKVlV+VOEhy2MUYUVX2IOMIqLxuY56s4ZsBHNBemxWRCZwbrg+3cLhS83HQM7PykEZSrvtbeo37rQYmZ0L4R/StgvAMlBaPc/qRkNITjG1jM4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712143121; c=relaxed/simple; bh=VbECTiPBnr/S6qIBEZZwW+FHOUfxLgiBVWOVNPejisY=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gRfoyBxGD80OZ4/yQd+lrkfMRYxNljje1Rr2zzvemyzkIuOd/AB66es15E5YPvD/Lj+FY69/dXUjpvjRKycbjJ9ekZnklm9Rhaez22yrOxbqzl9H0gp1ZienK6FnHO7HJuWKVB/EZM5jGBuUmV1fzMMduZg5wW27ZHP+CVMjq7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=netfilter.org; arc=none smtp.client-ip=217.70.188.207 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=netfilter.org From: Pablo Neira Ayuso To: netfilter-devel@vger.kernel.org Subject: [PATCH nf,v2 2/4] netfilter: nf_tables: release mutex after nft_gc_seq_end from abort path Date: Wed, 3 Apr 2024 13:18:30 +0200 Message-Id: <20240403111832.234325-2-pablo@netfilter.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240403111832.234325-1-pablo@netfilter.org> References: <20240403111832.234325-1-pablo@netfilter.org> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The commit mutex should not be released during the critical section between nft_gc_seq_begin() and nft_gc_seq_end(), otherwise, async GC worker could collect expired objects and get the released commit lock within the same GC sequence. nf_tables_module_autoload() temporarily releases the mutex to load module dependencies, then it goes back to replay the transaction again. Move it at the end of the abort phase after nft_gc_seq_end() is called. Cc: stable@vger.kernel.org Fixes: 720344340fb9 ("netfilter: nf_tables: GC transaction race with abort path") Reported-by: Kuan-Ting Chen Signed-off-by: Pablo Neira Ayuso --- v2: no changes net/netfilter/nf_tables_api.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index ffcd3213c335..0d432d0674e1 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -10651,11 +10651,6 @@ static int __nf_tables_abort(struct net *net, enum nfnl_abort_action action) nf_tables_abort_release(trans); } - if (action == NFNL_ABORT_AUTOLOAD) - nf_tables_module_autoload(net); - else - nf_tables_module_autoload_cleanup(net); - return err; } @@ -10672,6 +10667,14 @@ static int nf_tables_abort(struct net *net, struct sk_buff *skb, WARN_ON_ONCE(!list_empty(&nft_net->commit_list)); + /* module autoload needs to happen after GC sequence update because it + * temporarily releases and grabs mutex again. + */ + if (action == NFNL_ABORT_AUTOLOAD) + nf_tables_module_autoload(net); + else + nf_tables_module_autoload_cleanup(net); + mutex_unlock(&nft_net->commit_mutex); return ret; -- 2.30.2