Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D7CC4345F for ; Sat, 20 Apr 2024 06:30:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B4A66B007B; Sat, 20 Apr 2024 02:30:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 363316B0083; Sat, 20 Apr 2024 02:30:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22C3E6B0085; Sat, 20 Apr 2024 02:30:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 047EC6B007B for ; Sat, 20 Apr 2024 02:30:03 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3D868A1734 for ; Sat, 20 Apr 2024 06:30:03 +0000 (UTC) X-FDA: 82028935086.17.11D59AF Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf11.hostedemail.com (Postfix) with ESMTP id 7784840007 for ; Sat, 20 Apr 2024 06:30:01 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=C3TARYIB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of hyunminlr@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=hyunminlr@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713594601; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=HCRsTxJ9ZCKcjUBAUt+/BoQxy9wMll4XPFUnZIhsbkA=; b=hJlt/SaCzzdgWozEnBiI46VGmeO9qcMS+MHlYX3OcdceDd6Yt5be9IzLL2rPh0lXJbYeWF GlUPD1PIzdgW2rO2hpSUooOYKGBWGqmiliZprGTNdI51WzFw9qs+ceJETlHXkZ4T9pNxDs q4oyP8Q8eSfNLo8KExUtE5b1C9AHooQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=C3TARYIB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of hyunminlr@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=hyunminlr@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713594601; a=rsa-sha256; cv=none; b=MtavhsnfOOS8Cgq4zK3YxyJ//ZOklVZh8MCIFc7KEUkGhM5zdTJXbxppkuwNmOw51du2uF Ru7CyfWqm6mwHp4qePYISbpyetgYZcC+huNkrGP+nOQIuPpQvwbbGn+i1fQdyF+zYSKigH BD9Prg3TJsqBhDFfU4eNEJ0EYe8C3Xc= Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6ed627829e6so3074790b3a.1 for ; Fri, 19 Apr 2024 23:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713594599; x=1714199399; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HCRsTxJ9ZCKcjUBAUt+/BoQxy9wMll4XPFUnZIhsbkA=; b=C3TARYIBy0kOlMfRJ/P90PXTl6OnfpZfQ3kmS/Yuys1L7RBJ21Jg3tFjZUau+U6P/Y +BShRnHaRG+SLEgHwZfXtin7ZA2/ZgV0kOzEcKYBqO+CQkSN3BZXrFQsko5NUNjbEZoV DlnpzqUZgoP7ZktbrY6Xj2+SXOj+cgOGv7XhuiD0/J7bEbOfoyK0vrf3wTiCkEzMSdzn b0irtMBvRH8IlaU8gHwHXssmC80Q8zxHXn/BA6M3shg8MQtebnavQArrUTWZNEbqvuD/ 3oJUL2A6/JObRI24lagYGokX1HxwFm6pDwwjJzIT1j/u+Erj27feT/ScreUKyhp2hgfu un5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713594599; x=1714199399; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HCRsTxJ9ZCKcjUBAUt+/BoQxy9wMll4XPFUnZIhsbkA=; b=WVuQvVYpOvPYny8LUr79MWbRHI5fKf0+s65OzTfNd98Wt63Nf/RtiQTAEkt+aStwWg k7BMqfWk12Wp0gniwLlEFrGigHrQmIEQJx+N+qAhVkWAVW6ezimHiufrSX8Io5PcHn0+ bm7CylHgq+Ff6Pxyf6lzehsAuOVVIWap/lfEJJ2uUKKYvZwpg8BxSb71992G+ZzMaCtF 2B8U9+AOzuTuTdC7c6GhJ6rmOSd5mUwGBnSHebV0fIixLpzwxbZ4LJUugCOqw7AAUnpm SGVqGyGN6YaU2eHWfb/I0lDfJByTDGU9Yt0mNGm7imPj9Jc07DB1s1J+JNu05HVP2vCt sZKA== X-Gm-Message-State: AOJu0YwjFOSEr9fAqtoHF5w+H51m1cf9PyujF9Ifc3EAORBsH+k1Cd/Z z7Ef/UxPxb7lTNj7KgYNfXeDV4XGxRZ8onmRQy11lGnQHmfGSIAo7t/WbLviIXQ= X-Google-Smtp-Source: AGHT+IHPz7MrLZMWPw7lfoZEfCFOme4jaRjjBv4cAPWnsnPogT0kFsmd+Ws3Y9f4EQd9nodIhn0+Tw== X-Received: by 2002:a05:6a20:3216:b0:1a9:3cf2:508d with SMTP id hl22-20020a056a20321600b001a93cf2508dmr4797887pzc.38.1713594599411; Fri, 19 Apr 2024 23:29:59 -0700 (PDT) Received: from MinsLaptop.localdomain ([125.177.3.166]) by smtp.gmail.com with ESMTPSA id ay12-20020a17090b030c00b002a5cf58aae2sm4109866pjb.11.2024.04.19.23.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 23:29:58 -0700 (PDT) From: Hyunmin Lee To: linux-mm@kvack.org Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: [PATCH] mm/slub: create kmalloc 96 and 192 caches regardless cache size order Date: Sat, 20 Apr 2024 15:29:54 +0900 Message-Id: <20240420062954.6816-1-hyunminlr@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7784840007 X-Stat-Signature: bx6zefjra5ax7benykmjmqtoejzsmkcy X-HE-Tag: 1713594601-632351 X-HE-Meta: U2FsdGVkX1/ux8DtZCxJtpdRoZfBKRhr0/Y4uCHvBjGFAVUYPcpHBEVEznddSW6dym29xLCOJbNv0fO4UTtrm2MbIWcaFS4pSMv/4uV5nkhc2pizs76bx6d8W4+2ui+GHRGltsNlK3yfNOuGIKgq24tR4zuZSRQxJRArgz5kPqALzwf7B1hP87g+7gN1EvsXVhr/rZCJMR+CHAImAmujcS0lhojhe2gfG7IRz2EgpE/q3Mc1h3aCMy/oL0SDZnQLYND1DTbeCIi1JrBmj6iKAz/OnXtub0ik7oIBC1RJtvtM1zgomi8pfj+LRd+0EKujKmfIZGSonDrfc9UfzzrM29OlTkHCbUh3RdTGMlkJ4Mz3OUrf0DlFnrR4XYNCBVCZQOdz4FswgykGCGxuDc/LBUF0otuAz37GJhTLoIpwKPH4IpUpVu5E2er5JQbn+Zkm0g/OLAFD2x4mCxK7800rF4rIxKTSNoK5xkwvoSHoKEGeIUk7/jzX4OdMOEgaNs7HT7HWmU2BT9GtxRosRgxIpyzdpLVN10HB7E1taOS1NRQphE2IyoDAbFyBdu4s3cn2pBFn9HAm89/9BxhuIo2y9fjd/oKoM8JPIUX1dlJzyYupjvxISpvCWe4OF4pAedxQ0/pBSTVS/4HrPplbnPcvdsfRyc8VmojEA7nIbe1j8cMNcOS9W+J14SkWGagV1bCxR27ecjpS+nxzU26A9ig6L/dnIJnqDj6RJ9BI3rih1tPXQpR1ufzMDp312/NJvcoaY91cFvd3Iwza7kLNzI3M5LhOxA/0XI6AQP2DUzSJSnx1MObzM3rauCyWGCXDzubSIcKsxGpQttUDpk24t9DKD6VGoLkfCCpMAT3qQXtlZX1bVK8BDa6FMdGt2y0QT0ZeuS4HalOQw927MOihzAOHzA7IlcekRVNrc+8tOgMIRP7RJdfYAlC39bhJrWm/YtEnnWU7kXcArcfWO7Lw058 WtOD5H8U Eo66uwa/8z3syyuWAhGA7YKKQrCNSLX6/kBFpLbvN2o1ukx6c/M+XX1sI3FCBlq5VgY5CuDgIg2XQQQJLcIl1/ieoyR9axvwemy7owOL7Wo8RieSotON4jbJEgeN3VU5+9w3LyqOYkb+Dae5HLLjsqbTi9DcJcw4+UFCck37dgEM1piXqbcpzqJVsx1/CGd94ETYfmt1FWPBS7a0fE8AYyNwx25lElto/7tiu0pQQX3ABaVYAq76idfQo9NOB4WCyn4uFzcEGNbuVizEes5vkOJE/axoaIHuiibiTSaBtYBVxqrG+Bipip5x3Tbof7ftvBfxzM5OxQFfi+gtcEpekqKKm5tLwQBlj1RKXM1cAmuqSFuymKTP5LvNq9pvueriRlmHXr31TC/iNtyFQwgbkf7wwRD2uoWYIn2fgy8qI0wLkOgNC6++J8YoQUeL/RZ2wyylOMGIjD5/cvlmPM+F/VtGfW+rCnk+MSAPQ/swUfY+UkZINGUdXp6bm+TzjixfgmyeJUIfrNT/ocyg0iAL8iNFKl3G6415bLPdi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: For SLAB the kmalloc caches needed to be created in ascending sizes in order. However, the constraint is not necessary anymore because SLAB has been deprecated and SLUB doesn't need to comply with the constraint. Thus, kmalloc 96 and 192 caches can be created after the other size kmalloc caches are created instead of checking every time to find their order to be created. Also, this change could prevent engineers from being confused by the deprecated constraint. Signed-off-by: Hyunmin Lee Co-developed-by: Jeungwoo Yoo Signed-off-by: Jeungwoo Yoo Co-developed-by: Sangyun Kim Signed-off-by: Sangyun Kim Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Gwan-gyeong Mun --- mm/slab_common.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/mm/slab_common.c b/mm/slab_common.c index 3179a6aeffc5..c3271b17eb76 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -919,19 +919,12 @@ void __init create_kmalloc_caches(void) for (i = KMALLOC_SHIFT_LOW; i <= KMALLOC_SHIFT_HIGH; i++) { if (!kmalloc_caches[type][i]) new_kmalloc_cache(i, type); - - /* - * Caches that are not of the two-to-the-power-of size. - * These have to be created immediately after the - * earlier power of two caches - */ - if (KMALLOC_MIN_SIZE <= 32 && i == 6 && - !kmalloc_caches[type][1]) - new_kmalloc_cache(1, type); - if (KMALLOC_MIN_SIZE <= 64 && i == 7 && - !kmalloc_caches[type][2]) - new_kmalloc_cache(2, type); } + + if (KMALLOC_MIN_SIZE <= 32 && !kmalloc_caches[type][1]) + new_kmalloc_cache(1, type); + if (KMALLOC_MIN_SIZE <= 64 && !kmalloc_caches[type][2]) + new_kmalloc_cache(2, type); } #ifdef CONFIG_RANDOM_KMALLOC_CACHES random_kmalloc_seed = get_random_u64(); -- 2.34.1